Results 1 to 7 of 7

Thread: 19183: Fix maximizer to allow club with other offhands. This should also work for +k

  1. #1
    Feed Reader RSS Bot's Avatar
    Join Date
    Jul 2009
    Posts
    11,710

    RSS 19183: Fix maximizer to allow club with other offhands. This should also work for +k

    Fix maximizer to allow club with other offhands.

    This should also work for +knife and other similar keywords.

    Nominally tested.

    by heeheehee on 2019-04-22 03:38:58

    M /src/net/sourceforge/kolmafia/maximizer/Evaluator.java (view) (diff)
    M /test/net/sourceforge/kolmafia/MaximizerTest.java (view) (diff)
    Download the latest KolMafia build here.
    Every new revision posted within the hour.
    New EXE builds every Monday.

  2. #2
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,630

    Default

    Can't say I'm happy with what the maximizer is doing today.

    Code:
    Unexpected error, debug log printed.
    class java.lang.ArrayIndexOutOfBoundsException: -1
    java.lang.ArrayIndexOutOfBoundsException: -1
    	at net.sourceforge.kolmafia.maximizer.Evaluator.enumerateEquipment(Evaluator.java:1535)
    	at net.sourceforge.kolmafia.maximizer.Maximizer.maximize(Maximizer.java:175)
    	at net.sourceforge.kolmafia.maximizer.Maximizer.maximize(Maximizer.java:126)
    	at net.sourceforge.kolmafia.textui.RuntimeLibrary.maximize(RuntimeLibrary.java:6785)

  3. #3
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,630

    Default

    Here was the maximizer string I submitted:

    Code:
    item drop +effective +equip gate transceiver +equip high-friction boots +equip geological sample kit +equip shark jumper, spell damage percent
    Last edited by Veracity; 04-22-2019 at 05:06 AM.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,630

    Default

    Same thing with another character.

    Code:
    Unexpected error, debug log printed.
    Script execution aborted (java.lang.ArrayIndexOutOfBoundsException: -1): (VeracitySpacegate.ash, line 2261)
    Maximizer string:

    Code:
    item drop +effective +equip gate transceiver +equip high-friction boots +equip geological sample kit +equip shark jumper
    Until/unless this is fixed, I guess I will not be running turns today.

  5. #5
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,630

    Default

    Yeah, that's a little dramatic. I did:

    svn merge -r HEAD:19182 .

    to rollback this commit, rebuilt, and I am able to proceed.

    Please fix. Thanks.

  6. #6
    Developer
    Join Date
    Aug 2009
    Posts
    2,916

    Default

    Ugh, sorry.

  7. #7
    Developer
    Join Date
    Aug 2009
    Posts
    2,916

    Default

    "maximize weapon damage +club" reproduces the crash locally with r19183, does not with r19184 (and does generate brimstone bludgeon + stick-knife)..

    I believe the issue is that tests didn't account for two-handed weapons.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •