Results 1 to 4 of 4

Thread: 19173: Add synchronization to getStash(). Per https://kolmafia.us/showthread.php?234

  1. #1
    Feed Reader RSS Bot's Avatar
    Join Date
    Jul 2009
    Posts
    11,902

    RSS 19173: Add synchronization to getStash(). Per https://kolmafia.us/showthread.php?234

    Add synchronization to getStash().

    Per https://kolmafia.us/showthread.php?23496, there is some weird
    interaction that causes many stash refreshes, possibly tied to the
    maximizer.

    From my earlier analysis, it turns out that we may enqueue many of these
    stash refresh requests, since we only set ClanManager.stashRetrieved when
    the request succeeds. This synchronization should change this behavior to
    only enqueue one request.

    by heeheehee on 2019-04-13 03:51:02

    M /src/net/sourceforge/kolmafia/session/ClanManager.java (view) (diff)
    Download the latest KolMafia build here.
    Every new revision posted within the hour.
    New EXE builds every Monday.

  2. #2
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,385

    Default

    I'm thinking maybe this wasn't such a good idea.

    I finished a DG run, went to free the king and then got caught in an infinite loop trying to refresh the stash and offer me a class choice. Things were so bolloxed up that after killing KoLmafia I could not log back in. I had to go to plain vanilla KOL to accept the class choice.

  3. #3
    Developer
    Join Date
    Aug 2009
    Posts
    2,956

    Default

    Sorry, r19175 reverts this change.

  4. #4
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,385

    Default

    Sorry, r19175 reverts this change.
    Originally Posted by heeheehee View Post
    No problem.
    Well, thank you.
    Originally Posted by Veracity View Post

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •