Results 1 to 3 of 3

Thread: [Patch] Modifier Maximizer does not prioritize boolean modifiers over shortcuts

  1. #1
    Senior Member
    Join Date
    Apr 2018
    Posts
    187

    Default [Patch] Modifier Maximizer does not prioritize boolean modifiers over shortcuts

    Right now, the Modifier Maximizer parses input with the following precedence:
    1. Exact name of numeric modifier
    2. Abbreviations and shortcuts
    3. Exact name of boolean modifier
    4. Error

    There is an obvious problem with this: certain boolean modifiers cannot be specified, as they are ignored in favor of shortcuts that happen to match them. In particular, “Adventure Underwater” is never evaluated properly, as the code finds a case-insensitive match for “adv*”, concludes the correct modifier is “Adventures”, and moves on.

    The patch I am submitting simply moves the existing code around, changing the precedence to:
    1. Exact name of numeric modifier
    2. Exact name of boolean modifier
    3. Abbreviations and shortcuts
    4. Error

    Boolean Modifiers.patch

  2. #2
    Senior Member
    Join Date
    Jun 2016
    Posts
    292

    Default

    I'm not sure why you would want to use Adventure Underwater when 'sea' is a thing, but that aside, this patch makes sense.

  3. #3
    Senior Member
    Join Date
    Apr 2018
    Posts
    187

    Default

    I'm not sure why you would want to use Adventure Underwater when 'sea' is a thing, but that aside, this patch makes sense.
    Originally Posted by the dictator View Post
    I made a script to automatically use Unaccompanied Miner with Anemone Mine, and accessing it requires a way to breathe underwater. It does not require your familiar to breathe underwater, though, and it is actually helpful not to have that: adventuring normally does require that, and that makes it a useful way to catch mistakes.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •