Results 1 to 10 of 10

Thread: Updating sniffs based on spading

  1. #1
    Developer
    Join Date
    Jan 2007
    Posts
    93

    Default Updating sniffs based on spading

    I've made a patch to address The Dictator's spading on sniffing.

    There is a breaking change here because it seems that gallapagos monster is reset on rollover and thus needs a leading underscore.
    Attached Files

  2. #2

    Default

    That patch looks good. And after thinking about it some, I think a counter for those seems reasonable.

    Since Latte tracking ends at rollover, the counter should also be cleared at the first login of the day. Without checking, I believe that would be in KoLmafia.java or KoLCharacter.java.

  3. #3
    Developer
    Join Date
    Apr 2010
    Posts
    5,129

    Default

    Quite a lot of other handling needed I'm afraid. Need to handle it in AreaCombatData, ValhallaManager, defaults.txt, and Latte one would need to use startCountingTemporary, as it only lasts til rollover.

  4. #4
    Developer
    Join Date
    Jan 2007
    Posts
    93

    Default

    I'll sort those out. Looking at the code, it looks like lostcalpolydude's issue would be covered by using startCountingTemporary?
    Last edited by gausie; 01-16-2019 at 06:49 PM.

  5. #5
    Developer
    Join Date
    Jan 2007
    Posts
    93

    Default

    Ok that is those changes sorted.
    Attached Files

  6. #6
    Developer
    Join Date
    Apr 2010
    Posts
    5,129

    Default

    Nearly there, looking good.

    AreaCombatData will need to only add to monsters whilst the relevant counter exists, similar to how Olfaction does.

  7. #7
    Developer
    Join Date
    Jan 2007
    Posts
    93

    Default

    Extremely good point (attached)
    Attached Files

  8. #8

    Default

    It looks like startCountingTemporary was added by me, and it's actually for counters that don't start until the next "normal" encounter (for a weird definition) rather than being related at all to clearing them at rollover.

  9. #9
    Developer
    Join Date
    Jan 2007
    Posts
    93

    Default

    Ok I solved that by stopping counting it in the same place we stop counting wanderers.

    I also noticed that part of the spading was the chatterboxing banish expires at rollover, so updated that too.
    Attached Files

  10. #10

    Default

    19083.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •