Results 1 to 6 of 6

Thread: [Patch] Track usage of Jerks' Health™ Magazine

  1. #1
    Senior Member
    Join Date
    Apr 2018
    Posts
    186

    Default [Patch] Track usage of Jerks' Health™ Magazine

    This patch adds usage tracking for Jerks' Health™ Magazine, in the same manner that Meteorite-Ade is already tracked.

    JerksPatch.patch
    Last edited by Saklad5; 01-07-2019 at 01:11 PM.

  2. #2
    Senior Member
    Join Date
    Apr 2018
    Posts
    186

    Default

    I’ve changed the patch to account for the fact that you can multi-use magazines.

  3. #3

    Default

    19061. You will probably get a conflict for defaults.txt because I reordered a few settings unrelated to this patch.

  4. #4
    Senior Member
    Join Date
    Apr 2018
    Posts
    186

    Default

    Patches only contain changes, not the entire file that was changed. So long as the reordering didn’t affect anything near the changed lines, that shouldn’t be an issue.

  5. #5

    Default

    And that type of response makes me regret caring about anything you ever post. The values are right next to the one you added, which is why I noticed them and changed them. And the setting you added is a few lines off to go with that reordering. But instead of looking at that, you seem to assume a lack of competence by everyone else.

  6. #6
    Senior Member
    Join Date
    Apr 2018
    Posts
    186

    Default

    I’m very sorry. I’m rather preoccupied right now, so I didn’t check. Rather than assuming “unrelated” meant “not close to the lines changed”, I should have forgone replying entirely until I had that time.

    That being said, it isn’t as obvious as you seem to assume. I only know that adjacent lines are included in the patch because I manually looked at the patch file. If this project used Git, for example, adjacent lines would not be a conflict in a commit. I didn’t assume a lack of competence, just a lack of familiarity similar to my own.
    Last edited by Saklad5; 01-08-2019 at 05:53 PM.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •