Bug - Fixed 0 prices updated at login

AlbinoRhino

Active member
PHP:
Session data refreshed.
3 days until Halloween, Mysticism bonus today     (not tomorrow).
Using data override: data/mallprices.txt
0 prices     updated from https://kolmafia.us/scripts/updateprices.php?action=getmap

It seems, since the switch to SSL, that no prices have updated when I log in. Did the price sharing get broken with the change somehow?
 

fronobulax

Developer
Staff member
PHP:
Session data refreshed.
3 days until Halloween, Mysticism bonus today     (not tomorrow).
Using data override: data/mallprices.txt
0 prices     updated from https://kolmafia.us/scripts/updateprices.php?action=getmap

It seems, since the switch to SSL, that no prices have updated when I log in. Did the price sharing get broken with the change somehow?

Happened to me too. I have a vague recollection that there were different connection methods for http and https in the code so a simple sub of http to https would not work. I will try and investigate later today if no one else has done so.

There is a file name test against https:// that needs to pass for files to be added to the update list. That needs to be https:// or http:// OR https://

Since my visitors just arrived I will look and test later.
 
Last edited:

fronobulax

Developer
Staff member
So I'm running this in the debugger with the "http or https" check I added. I am clearly reading the file. Interested parties can delete mallprices.txt, run mafia (with my change) and see that the file is (re)created.

I then looked at the code writing the updated prices and after submitting the file, the response contains
Unable to write the updated data file. Hey, Z! Check those file permissions.

If the file on the server is never updated then folks will get zero prices updated.

I'm going to check in my OR fix in the hopes that the problem will got away when the server side file permissions are tweaked.
 

fewyn

Administrator
Staff member
So I'm running this in the debugger with the "http or https" check I added. I am clearly reading the file. Interested parties can delete mallprices.txt, run mafia (with my change) and see that the file is (re)created.

I then looked at the code writing the updated prices and after submitting the file, the response contains

If the file on the server is never updated then folks will get zero prices updated.

I'm going to check in my OR fix in the hopes that the problem will got away when the server side file permissions are tweaked.

Can you try it now?
 
Top