Page 1 of 2 1 2 LastLast
Results 1 to 10 of 11

Thread: 18917: Lightly tested. Add Party Fair quest progress in relay browser.

  1. #1
    Feed Reader RSS Bot's Avatar
    Join Date
    Jul 2009
    Posts
    11,528

    RSS 18917: Lightly tested. Add Party Fair quest progress in relay browser.

    Lightly tested. Add Party Fair quest progress in relay browser.

    by darzil on 2018-09-29 11:19:44

    M /src/net/sourceforge/kolmafia/RequestEditorKit.java (view) (diff)
    M /src/net/sourceforge/kolmafia/persistence/QuestDatabase.java (view) (diff)
    M /src/net/sourceforge/kolmafia/session/QuestManager.java (view) (diff)
    M /src/net/sourceforge/kolmafia/webui/UseLinkDecorator.java (view) (diff)
    Download the latest KolMafia build here.
    Every new revision posted within the hour.
    New EXE builds every Monday.

  2. #2
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,204

    Default

    Did the clear the party quest in the relay browser. The fight ending (center panel) said there were 0 party goers left. The left panel (status) counted down the number of party goers as expected. If the 0 left message comes from KoLmafia then there might be some more work to do :-)

  3. #3
    Developer
    Join Date
    Apr 2010
    Posts
    4,949

    Default

    That’s interesting. Have done that quest a couple of times since I added the tracking, and progress has updated. Will investigate as I thought all I had changed was adding display

  4. #4
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,204

    Default

    Hold on? I ran it with one character and saw zeros. But I just started it with another and it is correct. Maybe wait for more data? One had the invitation, the other used a guest pass, one has never ascended, one may have had some text mangling effect....

  5. #5
    Developer
    Join Date
    Apr 2010
    Posts
    4,949

    Default

    Check the _questPartyFair values. It is possible the text is different for guest pass, or maybe it got mangled, such that it was not known which quest they were on. Visit to quest log should sort that, if so. If guest pass is different, we should fix that.

  6. #6
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,204

    Default

    After completion, but both character have

    _questPartyFair=finished
    _questPartyFairProgress
    _questPartyFairQuest
    I'll try and check tomorrow while things are in progress.

  7. #7
    Developer
    Join Date
    Apr 2010
    Posts
    4,949

    Default

    You'll get that whatever quest step when you hand in the quest.

  8. #8
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,204

    Default

    Not sure this is still the right place.

    DJ Quest.

    The relay browser tells me how much meat I gained but not how much remains. It looks like it is printing a string value that is blank or null instead.

    Still have ~700 meat to collect

    _questPartyFair=step1
    _questPartyFairProgress
    _questPartyFairQuest
    Character used the invitation, not the guest pass and this time does not have any text mangling, althought I am not usre that was true at the instant I accepted the quest.

    P.S.

    Code:
    You collect 742 Meat for the DJ. ( Meat remaining)

    Side panel says 17 meat left.

  9. #9
    Developer
    Join Date
    Apr 2010
    Posts
    4,949

    Default

    So, not sure if it is different text when using a guest pass, but you are still not getting the quest recognised. Can you get me the html from the choice when you use guest pass? I suspect that might be the issue here.

    Code:
    			if ( text.contains( "talk to him and help him get more booze" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "booze" );
    			}
    			else if ( text.contains( "Think you can help me clean the place up?" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "trash" );
    			}
    			else if ( text.contains( "helping her with whatever problem she's having with the snacks" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "food" );
    			}
    			else if ( text.contains( "megawoots right now" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "woots" );
    			}
    			else if ( text.contains( "taking up a collection from the guests" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "dj" );
    			}
    			else if ( text.contains( "all of the people to leave" ) )
    			{
    				Preferences.setString( "_questPartyFairQuest", "partiers" );
    			}
    Looks like this bit isn't working for some reason.

  10. #10
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,204

    Default

    Can you get me the html from the choice when you use guest pass?
    Originally Posted by Darzil View Post
    Sure.

    "tomorrow is another day"
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •