Results 1 to 4 of 4

Thread: Actual reality goggles can break faxbot because the username is changed

  1. #1

    Default Actual reality goggles can break faxbot because the username is changed

    Occasionally my scripts fail when trying to receive a fax from Easyfax - the message is sent, but the response is not parsed properly because it seems to come from a user called "WEirDEaSyfaXPOweR". Anyway, I wrote a patch that I think probably fixes it, but I haven't been able to reproduce the bug to test it. Faxing does still work using the resulting build though.

    Perhaps a nicer solution would be to not trust the name we get through from a chat message and always look up the real user by their playerid, but that's probably overly server-heavy. The best solution in my opinion though would be to have any relevant function across the whole codebase be able to either take a String playerName or an int playerId and just stick to that, but that seems like too much of a change for a first contribution?

    gausie

    fix-faxbot-name.patch

  2. #2
    Senior Member
    Join Date
    Apr 2009
    Posts
    1,821

    Default

    > not trust the name we get through from a chat message

    With CDM's magic, this is actually a thing, at least in /hardcore

  3. #3

    Default

    I kind of want to throw this in the pile of items that you shouldn't equip if you want mafia to handle everything properly. Especially since it has no effect other than changing names in chat, and that's the very thing that causes the issue here.

  4. #4

    Default

    I kind of want to throw this in the pile of items that you shouldn't equip if you want mafia to handle everything properly. Especially since it has no effect other than changing names in chat, and that's the very thing that causes the issue here.
    Originally Posted by lostcalpolydude View Post
    Yes that is extremely true, although I think it was possibly equipped by the maximizer cause I had nothing else for that slot.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •