Page 1 of 2 1 2 LastLast
Results 1 to 10 of 12

Thread: Matters arising from Monster Name Case Sensitivity

  1. #1
    Developer
    Join Date
    Apr 2010
    Posts
    4,894

    Default Matters arising from Monster Name Case Sensitivity

    From GD:

    I get spammed with msgs to change the name of knob goblin embezzler to Knob Goblin Embezzler and other mobs and I cant fix it because mafia custom combat editor forces text to lowercase. (and by spammed i mean the msg pops up like 15 times in a single combat) It doesnt break anything but I can't make it go away.

  2. #2
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,459

    Default

    Why does the CCS editor give a message? Shouldn't messages only be given for ASH scripts?
    I'll look at this.

  3. #3
    Developer
    Join Date
    Apr 2010
    Posts
    4,894

    Default

    Yeah, mine was quick fix, not great fix.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,459

    Default

    It "fixed" lower case monsters in ASH scripts, but broke substring matching for monster names.
    I'll see what I can do.

  5. #5
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,608

    Default

    In case this information is helpful: I also am getting exactly 11 messages at the start of combat for every monster with a capital letter in its name, telling me to change the all-lowercase name to the correct name. Neither my CCS nor my consult script contains the monster name. It's ridiculous. It's not even funny.
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

  6. #6
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,459

    Default

    Revision 18843 should take care of this issue. It still has temporary code in it.

    - findMonster( name ) - a single argument - looks only for exact case-sensitive matches.
    Use this when looking up monsters KoL gives us.
    - findMonster( name, boolean substrings, boolean case-sensitive ) - will do fuzzy matching and/or exact match case-insensitive matching.
    Use this when parsing user input - including ASH, for now.
    Also specifically used in CCS, since encounterKey is lower-cased...
    I notice that substring matches does lower case matching, since fuzzy matching uses "canonical" strings.
    - I removed the "friendly warning". It'll have to go into ASH, with additional support to recognize ambiguity and case-sensitivity; fuzzy matching doesn't quite make it.
    - When parsing combats.txt, print error message to gCli if a monster name is not an exact case-sensitive match to a monster in monsters.txt
    - I added brushfire, 25 skeletons, and 100 skeletons to monsters.txt with pseudo ids. We have no data for them, but it's fun to see the images in the Encyclopedia.
    And it makes combat.txt parsing not print aforementioned error messages.

    I think the code in findMonster to handle substrings & case-insensitivity is not what we really want long-term, but it hides the ASH script issue, for now.

  7. #7
    Developer
    Join Date
    Apr 2010
    Posts
    4,894

    Default

    Not matching monsters like The Muff and The Bush in Hole in the Sky (not decorating, as it isn't recognising them, presumably due to "The Muff" not matching "Muff").

    Code:
    [139] The Hole in the Sky
    Preference lastEncounter changed from The Bush to The Muff
    Encounter: The Muff
    Preference _lastCombatStarted changed from 20180903180406 to 20180903180419
    Round 0: darzil loses initiative!
    Round 1: You lose 44 hit points
    Round 1: You lose 46 hit points

  8. #8
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,459

    Default

    Revision 18847

  9. #9
    Developer
    Join Date
    Apr 2010
    Posts
    4,894

    Default

    Cheers, I'm sure I'll be able to verify tomorrow.

  10. #10
    Developer
    Join Date
    Apr 2010
    Posts
    4,894

    Default

    Pretty sure this is fixed.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •