Page 7 of 7 FirstFirst ... 5 6 7
Results 61 to 70 of 70

Thread: Rollover Management

  1. #61
    Senior Member Pazleysox's Avatar
    Join Date
    Feb 2009
    Posts
    366

    Default

    That's going to return 0, because the numeric_modifier command only supports a single modifier, not a linear combination like the maximizer does.
    Originally Posted by the dictator View Post
    Well, then that makes sense that there's an error in my script! I've fixed it, hopefully it works properly now.
    Scripts I have written:
    Unlock Dread A Script to save you a bunch of clicks.
    Standard Rollover Bonus A Script that shows best items to pull/equip for bonus turns.
    Standard PVP Bonus A Script that shows the best items to pull/equip for bonus PVP Fights.
    Rollover Management A Script that does all the daily deeds you might have forgotten, or might have missed.
    Chatbot A Chatbot script. Simple start for those who want/need one for their clan.
    Zap Wand A Dungeon of Doom ZAP WAND getting script.

  2. #62
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    Well, then that makes sense that there's an error in my script! I've fixed it, hopefully it works properly now.
    Originally Posted by Pazleysox View Post
    new version errors out with the message
    Code:
    WARNING: Unreachable code (Rollover Management.ash, line 371)
    Function     'maximize( string )' undefined. This script may require a more recent     version of KoLmafia and/or its supporting scripts. (Rollover     Management.ash, line 411)
    ----

    Can you please tell me what gear you have on when this happens?
    Originally Posted by Pazleysox View Post
    It says which items I had in the CLI log I posted in that post, let me repost just the relevant part:

    Code:
    2016 combinations checked, best score 326.00
    Putting     on insulting hat...
    Equipment changed.
    Holding sturdy cane...
    Equipment     changed.
    Putting on Corporal Fennel's Lonely Clubs Club Jacket...
    Equipment     changed.
    Putting on psychic's pslacks...
    Equipment changed.
    Putting     on offensive moustache...
    Equipment changed.
    Putting on Bram's     choker...
    Equipment changed.
    Putting on hamethyst necklace...
    Equipment     changed.
    ----
    Also, it seems to be still doing first adventure optimization and then pvp optimization. But that is redundant now that you are using
    1 PVP, 10 ADV, -tie
    or
    10 PVP, 1 ADV, -tie

    those two would automatically put adv / pvp boosting stuff in the empty slots. So you only need to run the maximizer once.
    The point of running adv first and then pvp (or vice versa) was for when using maximizer strings of
    pvp -tie
    or
    adv -tie
    Last edited by taltamir; 06-27-2018 at 02:09 PM.

  3. #63
    Senior Member Pazleysox's Avatar
    Join Date
    Feb 2009
    Posts
    366

    Default

    new version errors out with the message
    Code:
    WARNING: Unreachable code (Rollover Management.ash, line 371)
    Function     'maximize( string )' undefined. This script may require a more recent     version of KoLmafia and/or its supporting scripts. (Rollover     Management.ash, line 411)
    Originally Posted by taltamir View Post
    This is what happens when I work with no caffeine. It's fixed.

    Also, it seems to be still doing first adventure optimization and then pvp optimization. But that is redundant now that you are using
    1 PVP, 10 ADV, -tie
    or
    10 PVP, 1 ADV, -tie

    those two would automatically put adv / pvp boosting stuff in the empty slots. So you only need to run the maximizer once.
    The point of running adv first and then pvp (or vice versa) was for when using maximizer strings of
    pvp -tie
    or
    adv -tie
    Originally Posted by taltamir View Post
    This SHOULD be fixed now too. I found the issue.
    Last edited by Pazleysox; 06-27-2018 at 02:20 PM.
    Scripts I have written:
    Unlock Dread A Script to save you a bunch of clicks.
    Standard Rollover Bonus A Script that shows best items to pull/equip for bonus turns.
    Standard PVP Bonus A Script that shows the best items to pull/equip for bonus PVP Fights.
    Rollover Management A Script that does all the daily deeds you might have forgotten, or might have missed.
    Chatbot A Chatbot script. Simple start for those who want/need one for their clan.
    Zap Wand A Dungeon of Doom ZAP WAND getting script.

  4. #64
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    Thanks, both issues appear fixed now

  5. #65
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    I just noticed that during a jarlsberg run, if you have not eaten until full when running this script, it will tell you that you can still eat a fancy hot dog, even though jarlsberg can't eat things he didn't conjure himself.

  6. #66
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    noticed something in G-lovers.
    it says
    Code:
    You can still cast Pastamastery
    You won't receive bonus turns from your     campground, think about installing a Maid to clean things up
    even though pastamastery and maid are not available during G lover run
    Last edited by taltamir; 07-16-2018 at 08:29 AM.

  7. #67
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    adv optimization is:
    adv, +switch Disembodied Hand, +switch Trick-or-Treating Tot -tie
    and I really think it should be
    10 adv, 1 pvp fights, +switch Disembodied Hand, +switch Trick-or-Treating Tot -tie
    to make sure unused slots are at least doing something.

    v1.10 has added the functionality of using the spare slots when optimizing pvp. (by doing "10 pvp fights, 1 adv"). But not the vice versa situation where optimizing turns, where it still does "adv" instead of "10 adv, 1 pvp fights"

    For example, in my current run the only difference between the two is whether or not "makeshift garbage shirt" is equipped in the chest slot to give +3 pvp. both of them equip the other relevant items in the relevant slots.

    I have already made the change in my copy. just change line 469 to
    Code:
    maximize("10 adv, 1 pvp fights, +switch Disembodied Hand, +switch Trick-or-Treating Tot -tie", false);}
    and line 472 to
    Code:
    maximize("10 adv, 1 pvp fights, +switch Disembodied Hand, +switch Trick-or-Treating Tot -tie", false); maximize("10 pvp fights, 1 adv, -tie", false);}
    actually... could make them 20 adv, 1 pvp fights to make absolutely sure it will never prioritize a pvp fight over an adventure. (only instance where 10 to 1 ratio is not enough is if you have two 1 handed weapons giving 5+ pvp, vs a 2 handed weapon giving 1 adv exactly, at the moment no such item exists. there is only one +1 adv/rollover weapon and it is a 1 handed item)
    Last edited by taltamir; 08-10-2018 at 02:54 AM.

  8. #68
    Senior Member Pazleysox's Avatar
    Join Date
    Feb 2009
    Posts
    366

    Default

    this change has been made. thanks. I'll look at the others this week.
    Scripts I have written:
    Unlock Dread A Script to save you a bunch of clicks.
    Standard Rollover Bonus A Script that shows best items to pull/equip for bonus turns.
    Standard PVP Bonus A Script that shows the best items to pull/equip for bonus PVP Fights.
    Rollover Management A Script that does all the daily deeds you might have forgotten, or might have missed.
    Chatbot A Chatbot script. Simple start for those who want/need one for their clan.
    Zap Wand A Dungeon of Doom ZAP WAND getting script.

  9. #69
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    this change has been made. thanks. I'll look at the others this week.
    Originally Posted by Pazleysox View Post
    Glad to help... actually, this one doesn't directly affect the script directly anymore... but the current notes on the "void preferences" function are misleading. Changing that function only changes the default preferences for a brand new character. For an existing character they need to change it via CLI commands.

    currently
    Code:
    void preferences101()
        {
    if (get_property("ps_preferences_set") == "true") {return;}
    set_property ("ps_cheatdeckcard1", "ancestral recall");     // Three turns is great!
    set_property ("ps_cheatdeckcard2", "island");             // 6 turns is even better!
    set_property ("ps_cheatdeckcard3", "1952 Mickey Mantle");     // 10k meat is ALWAYS a nice bonus.  :)
    set_property ("ps_spacegateVaccine", "3");             // 1 rainbow +3 each element resist, 2 +50% each stat, or 3 +30 monster level
    set_property ("ps_manaburn", "true");                 // set this to false if you don't want to burn your free MP restorers - TRUE SETTING WILL NOT USE MEAT!
    set_property ("ps_geniewish1", "more wishes"); 
    set_property ("ps_geniewish2", "more wishes"); 
    set_property ("ps_geniewish3", "more wishes"); 
    set_property ("ps_checkfamiliar", "true");        // set this to false if you don't want to know about familiar free drops, and free runaways
    set_property ("ps_checksource", "true");         // set this to false if you don't want to know about your Source Terminal 
    set_property ("ps_dailydeeds", "true");            // set this to false if you don't want to do all daily deeds
    set_property ("ps_rollover", "turns");             // set this to turns for rollover turns, or pvp for pvp fights
    set_property ("ps_preferences_set", "true");
    print("prererences set", "green");
    }
    my suggestion
    Code:
    void preferences101()
        {
    if (get_property("ps_preferences_set") == "true") {return;}
    set_property ("ps_cheatdeckcard1", "ancestral recall");     // Three turns is great!
    set_property ("ps_cheatdeckcard2", "island");             // 6 turns is even better!
    set_property ("ps_cheatdeckcard3", "1952 Mickey Mantle");     // 10k meat is ALWAYS a nice bonus.  :)
    set_property ("ps_spacegateVaccine", "3");             // 1 rainbow +3 each element resist, 2 +50% each stat, or 3 +30 monster level
    set_property ("ps_manaburn", "true");                 // use gCLI command "set ps_manaburn=false" if you don't want to burn your free MP restorers - TRUE SETTING WILL NOT USE MEAT!
    set_property ("ps_geniewish1", "more wishes"); 
    set_property ("ps_geniewish2", "more wishes"); 
    set_property ("ps_geniewish3", "more wishes"); 
    set_property ("ps_checkfamiliar", "true");        // use gCLI command "set ps_checkfamiliar=false" if you don't want to know about familiar free drops, and free runaways
    set_property ("ps_checksource", "true");         // use gCLI command "set ps_checksource=false" if you don't want to know about your Source Terminal 
    set_property ("ps_dailydeeds", "true");        // use gCLI command "set ps_dailydeeds=false" if you don't want to do all daily deeds
    set_property ("ps_rollover", "turns");             // use gCLI command "set ps_rollover=turns" for rollover turns, or "set ps_rollover=pvp" for pvp fights
    set_property ("ps_preferences_set", "true");       // ???
    print("prererences set", "green");
    }
    changes have been highlighted in blue.

    also... does "ps_preferences_set" reset the preferences to default if you set it to false?

  10. #70
    Senior Member
    Join Date
    Oct 2017
    Posts
    306

    Default

    in actually ed the undying. get the error:
    Unable to parse housing!
    which is happening when checking the campground

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •