Page 61 of 61 FirstFirst ... 11 51 59 60 61
Results 601 to 610 of 610

Thread: CanAdv -- check whether you can adventure at a given location

  1. #601
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,155

    Default

    We should probably add the rowboat check back in. For characters who haven't ascended since the advent of the S.O.C.K., the entire castle will be reported as unavailable.
    Originally Posted by zarqon View Post
    Your call, although if the Garbage quest is finished, doesn't that mean that the Castle floors have to be available?
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post

  2. #602
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,582

    Default

    All of those checks fall through to the S.O.C.K. check. (There's no "break;")

    Changing the line to:
    PHP Code:
       case $location[The Castle in the Clouds in the Sky \(Basement\)]: return itemcheck($item[S.O.C.K.]) || itemcheck($item[intragalactic rowboat]); 
    ought to fix this for the sockless people of the world.
    Last edited by zarqon; 05-29-2017 at 03:32 PM.
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

  3. #603
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,743

    Default

    Committed. I was questioning through the decision of working based on mafia's understanding of the quest or the item, since you can elect to not get the item in current state if you somehow hovered between the revamp and never ascended, but the chance of someone who purposefully avoided unlocking the sky for years while remaining in aftercore actually wanting to run any kind of automation is... low.

  4. #604
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,582

    Default

    Haha! Right.

    (just you wait)
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

  5. #605
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,743

    Default

    Oh, I don't doubt that SOMEone out there qualifies, but most people that committed wouldn't want to risk some malicious coder causing them to unlock the sky in a vindictive, but petty, move to remove their distinctiveness.

    Whenever we hit someone with that combination of dedication, determination, frustration, and unwillingness to self-modify a script file for their own purposes, I don't doubt that they'll note my failings though. And then we'll see which direction the solution runs.

  6. #606
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,155

    Default

    My edge case has been handled. Thanks.

    FYI.

    Multiple matches against The .
    Unknown location: Super Villain's Lair (zone: Town)
    Please report this missing location here: https://kolmafia.us/showthread.php?t=2027
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post

  7. #607
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,743

    Default

    Not sure what your 'The' is, but...
    > ashq import <canadv.ash> foreach it in $locations[] can_adv(it);

    Unknown location: Super Villain's Lair (zone: Town)
    Please report this missing location here: https://kolmafia.us/showthread.php?t=2027

    Checking resistance to stench...
    You can already resist stench.
    Internal checkpoint created.
    Putting on pirate fledges...
    Equipment changed.
    Putting on Official Council Aide Pin...
    Equipment changed.
    Unknown location: Through the Spacegate (zone: The Spacegate)
    Please report this missing location here: https://kolmafia.us/showthread.php?t=2027
    So, two unknown zones. If someone wants to pass along their unlock conditions, great.

  8. #608
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,155

    Default

    Unknown location: Duke Vampire's Chateau (zone: FantasyRealm)

    Unknown location: The Master Thief's Chalet (zone: FantasyRealm)

    Unknown location: The Dragon's Moor (zone: FantasyRealm)

    I suppose if it matters to me or anyone else the first step is to articulate the unlock conditions... But then I would hope cango and canadv might be reconciled?

  9. #609
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,582

    Default

    I spent some time working on this today.

    • Added all the FantasyRealm locations (mafia's built-in tracking made this way easier than I'd expected it to be).
    • Made sure it has handling for all locations.
    • Revamped the pirate locations to check the pirate quest property (could get rid of piratecheck() that way, which speeds those checks up considerably).
    • Also, in an effort to remove even more server hits, I added much more quest-specific handling to guildcheck() so it will only check each guild NPC when there's quest progress to be made. I only did that for two of the three quest-givers at the moment, though; the Nemesis quest was too daunting for today.
    • Some useful changes to make things more robust: equipcheck() now checks be_good(), and outfitcheck() now checks equipcheck() for each piece of the outfit.
    • A few other small changes here and there, too, probably.

    Yay!
    Attached Files
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

  10. #610
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,582

    Default

    Believe this is right:

    PHP Code:
       case $location[The Neverending Party]: return qprop("_questPartyFair < finished") && (get_property("neverendingPartyAlways").to_boolean() || get_property("_neverendingPartyToday").to_boolean()); 
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

Similar Threads

  1. Replies: 0
    Last Post: 04-08-2015, 11:53 PM
  2. 14841: Check location isn't null before getting water level.
    By RSS Bot in forum Latest SVN Changes
    Replies: 0
    Last Post: 10-09-2014, 08:51 PM
  3. Replies: 0
    Last Post: 03-19-2012, 04:23 AM
  4. Ash function to check location exists?
    By Glazius in forum Community Support
    Replies: 1
    Last Post: 12-15-2010, 08:13 PM
  5. CanAdv can I adventure here?
    By Charles Haynes in forum Informational Scripts
    Replies: 7
    Last Post: 11-21-2009, 11:10 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •