Page 238 of 239 FirstFirst ... 138 188 228 236 237 238 239 LastLast
Results 2,371 to 2,380 of 2381

Thread: Universal Recovery Script

  1. #2371
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,159

    Default

    https://zachbardon.com/mafiatools/ was online for me now so it may have been your connection.

    For future reference there are files hosted there and shared by scripts so if the site is down for a while, other things will break. batfactors is one file that I recall is there.

    The host/owner just got married and is pretty much on honeymoon for the month of May (2018) so if there is a repeatable problem, patience is advised.

  2. #2372
    Senior Member
    Join Date
    Oct 2017
    Posts
    311

    Default

    https://zachbardon.com/mafiatools/ was online for me now so it may have been your connection.

    For future reference there are files hosted there and shared by scripts so if the site is down for a while, other things will break. batfactors is one file that I recall is there.

    The host/owner just got married and is pretty much on honeymoon for the month of May (2018) so if there is a repeatable problem, patience is advised.
    Originally Posted by fronobulax View Post
    Thank you for the info. I had thought it was a site specific to that script rather than a general mafia thing. I guess I can reenable universal recovery then since the site is back online.

  3. #2373
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,159

    Default

    Thank you for the info. I had thought it was a site specific to that script rather than a general mafia thing. I guess I can reenable universal recovery then since the site is back online.
    Originally Posted by taltamir View Post
    https://kolmafia.us/showthread.php?15...ht=Map+Manager
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post

  4. #2374

    Default

    I did a quick skim through and updated this script to work with G-Lover. Not tested outside of my account, but it works for me!

    Universal_recovery.ash

  5. #2375
    Senior Member
    Join Date
    Oct 2017
    Posts
    311

    Default

    I did a quick skim through and updated this script to work with G-Lover. Not tested outside of my account, but it works for me!

    Universal_recovery.ash
    Originally Posted by gausie View Post
    Thanks, I had just noticed that the old script didn't work with G lover... well, actually what it did is

    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    (usable quantity of cast (2) is limited to 0 by g-lessness)
    ...
    And it did so too fast to tell which script called it as it overflow the gCLI even if you manually abort a second after it started. (sometimes it wouldn't abort either).
    I went and manually ran scripts to find out which one does that. it must be trying to use canonelli cocoon.

    Anyways, thanks for the updated version, so far I have had no problems with it.
    Last edited by taltamir; 07-10-2018 at 12:25 AM.

  6. #2376
    Senior Member
    Join Date
    Oct 2017
    Posts
    311

    Default

    Ok, this is downright weird. Using the script on a new multi on its first ascension (so no healing skills). Instead of restoring HP by buying doc galaktic's restoratives, its spending 1900 meat in the mall to buy the least efficient restoratives possible.

    Code:
    Restoring HP! Currently at 49 of 64 HP, 73 of 73 MP,      current meat: 2117 ... Target HP = 61.
    Searching for "Camp Scout      pup tent"...
    Search complete.
    Purchasing Camp Scout pup tent (1      @ 1,900)...
    It is using a +1000HP item to heal 15HP...

    edit: wait, I know what the problem is, this is a more extreme version of an issue I have mentioned before. Back then I was comparing only 18 meat, comparing using two different healing skills.

    The issue is quite simple, the script simply does not care, at all, how much HP you can hold, it only care what gives the most HP/meat.
    +1000 HP for 1900 meat = 1.9 meat/HP, this happened to be the best ratio of meat/HP in the store. So it uses it despite the fact it is actually only giving me +15 HP, for an actual efficiency of 126.6 meat/HP.

    What was a minor issue before became a critical issue now. For now I am setting it to only buy from NPC stores.

    edit2: double facepalm. now its using my scrolls of drastic healings for 15 HP (... wait why does it think those come from NPC vendors? or did I have one in inventory? I can't have, I am too low level for that quest... what is going on?)...
    yea I am just going to disable this script entirely until I have healing skills. Or until I find the time to fix it. At the moment it is extremely harmful for new characters that do not have the healing skills permed..
    Last edited by taltamir; 08-09-2018 at 01:06 AM.

  7. #2377
    Senior Member
    Join Date
    Jan 2012
    Location
    Texas
    Posts
    412

    Default

    Have you configured it to tell it what to use? It uses what it is in your healing settings in mafia

  8. #2378
    Senior Member
    Join Date
    Oct 2017
    Posts
    311

    Default

    Have you configured it to tell it what to use? It uses what it is in your healing settings in mafia
    Originally Posted by txrangersxx View Post
    Are you sure? it has its own separate settings page though, and the items it is using don't even exist in the configuration for mafia baseline "restore hp" script.
    Anyways, yes I have configured the baseline mafia options.

    This is not a configuration issue it is a fundamental issue with the script as it harkens back to something I have noticed long long ago and was told to just get more +HP/MP skills permed. And that is no big deal since I was only losing a trivial amount of meat per heal, and in truth it was not a big deal.
    Namely, it was using tongue of the walrus to cure ~2 HP instead of lasagna bandages; yes, tongue of the walrus is more efficient if both heal their average quantity, but when you are close to your HP cap then it is a waste to use the higher MP cost option

    For people who have permed the healing skills and have a bunch of +maxHP / +maxMP skills permed this is less of an issue, the script will just use the skills. (still an issue because it is buying inefficient stuff instead of the cheapest option, wasting some small amount of meat.
    For a brand new player lacking in perms this is really bad, bankrupting them for no reason. A +1000 HP item is assumed to actually heal you for 1000 HP, regardless of the fact that your maxHP is measured in two digits.

    Anyways, things (that I remember) that needs to be fixed in this script are:
    1. When calculating an item's efficiency, the "restored HP/MP" value used in the calculation should be whichever is lower between:
    a. the amount that item or skill it can hypothetically restore
    b. [maxHP-currentHP]. (or MP if restoring MP)

    2. When looking at the mall, consider items which recover both HP and MP. Currently they are totally ignored. This results in a case of "item A: recover 100 HP and 100 MP for 100 meat" being ignored in favor of "item B: recover 50 MP for 100 meat". Even though the latter is half the efficiency.
    Sure, writing a system that actually accounts for the value of both the HP AND the MP is complicated; but also not necessary, simply ignore no what is not being restored. this will improve efficiency.

    3. include a sanity check that aborts and reports if meat per HP is ridiculously high. (say, over 10 meat per HP? maybe over 20?)

    I have never made a mafia script before... but I have dabbled in other stuff like javascript. I will give it a try later.
    Last edited by taltamir; 08-10-2018 at 02:09 AM.

  9. #2379
    Senior Member
    Join Date
    Jun 2016
    Posts
    234

    Default

    The real problem is that you seem to have cannelloni cocoon permed but for some reason it's never mentioned in your post, so you should probably check your settings to enable that, because it's by far the best HP recovery ability out there.

  10. #2380
    Senior Member
    Join Date
    Oct 2017
    Posts
    311

    Default

    The real problem is that you seem to have cannelloni cocoon permed but for some reason it's never mentioned in your post, so you should probably check your settings to enable that, because it's by far the best HP recovery ability out there.
    Originally Posted by the dictator View Post
    1. This is a brilliant script, this doesn't mean it can't have issues or bugs. I will see about fixing it and posting the fix here later on.

    2. You must have missed it, I was stating that I have made a new multi that has zero skills permed. And saying this issue should also affects all new players who have not permed cocoon and are recommended this script by someone. The part where I am talking about cocoon was referring to my main account. Having cocoon permed its not that big a deal there, merely somewhat inefficient. But on my new multi I don't have any perms at all and this issue really rises to the fore.
    Last edited by taltamir; 08-10-2018 at 02:47 AM.

Similar Threads

  1. Anecdote - Recovery Script not firing between auto-adventures?
    By fronobulax in forum Community Support
    Replies: 1
    Last Post: 02-20-2015, 07:36 PM
  2. Replies: 0
    Last Post: 09-21-2013, 05:50 PM
  3. what are all the ways mafia can consult a script? like recovery, breakfast
    By forgot my password in forum Scripting Discussion
    Replies: 5
    Last Post: 06-11-2009, 09:05 PM
  4. Recovery Script for Hardcore
    By Bale in forum Buff Upkeep Scripts
    Replies: 84
    Last Post: 03-04-2009, 08:17 AM
  5. Very New, Need a MP Recovery Script
    By Willie0248 in forum Scripting Discussion
    Replies: 2
    Last Post: 04-15-2006, 09:30 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •