Search results

  1. O

    Bug Combat filter functions in JavaScript

    Ah, not bad, I didn't think about simply keeping the references in the global scope. Should the cleanup of temporaryName perhaps happen in a finally-block? I will try the patch in an hour or two...
  2. O

    Bug Combat filter functions in JavaScript

    That sounds like an ideal Implementation from the frontend side. But you still need to "remember" those functions for the invocation somewhere (or refactor quite some stuff to be able to pass functions from and to the runtime), right?
  3. O

    Bug Combat filter functions in JavaScript

    I started working with the JavaScript Runtime, and I couldn't figure out how to use adventure() with a custom combat filter function defined in the same script. The function is never found, and thus always returns void. (Shouldn't it throw an error if the requested function is not found? Ash...
  4. O

    Feature - Implemented Terminal color output

    My screenshot is from Windows Terminal as well, albeit with WSL. But the program itself is definitely not limited to 256 color mode. @philmasterplus, would you mind sharing your js snippet as copiable text, that would be super helpful :)
  5. O

    Feature - Implemented Terminal color output

    Unrelated to the errors, but related to the color terminal, here is a small script to test whether KoLmafia and/or your terminal are outputting the colors you expected: const kolmafia = require('kolmafia'); let s = ''; function hex(n) { return ('0' + parseInt(n).toString(16)).slice(-2); }...
  6. O

    Feature - Implemented Terminal color output

    Sorry if my code caused any trouble. I tried to keep the formatting as I perceived it is used in the project, even though it's not very "standard Java" in some regards.
  7. O

    Feature - Rejected handle float = int/int. always calculate division as integers first then convert on storage

    I'm just saying, what you are requesting is to do a "completely" different operation, not just "normal" division not working right. There is also integer division in "math", so "how math works" is a somewhat narrow view. Anyway, I just thought this might help to understand why it might not be a...
  8. O

    Feature - Rejected handle float = int/int. always calculate division as integers first then convert on storage

    I don't think it would necessarily break operator precedence, but it would definitely break existing code. This is not what happens. The operation that is happening here is an Integer division, so it's: step 1: "Integer 1 divided by integer 2 is 0" It has nothing to do with the fact that it's...
  9. O

    Feature - Implemented Terminal color output

    Thanks for merging! Next stop: input line editing with history :)
  10. O

    Feature - Implemented Terminal color output

    Thanks! Could you perhaps get the jar file from https://search.maven.org/artifact/org.fusesource.jansi/jansi/2.3.2/jar ? There have been quite some fixes since 2.1.0, plus that's the version I tested against.
  11. O

    Feature - Implemented Terminal color output

    Attached is the latest version of the patches, unchanged since this post:
  12. O

    Feature - Implemented Terminal color output

    Is there something I can approve on this patch to get it merged? I have been running it in its current state for a while now without any problems. Are there any open concerns I can address?
  13. O

    Feature - Implemented Terminal color output

    I've decided that it makes more sense to have all other tags in the output, but printed in gray, otherwise stuff like tables looks really garbled. It still does not look like much, but better than having the unformatted HTML, and better than just the text:
  14. O

    Feature - Implemented Terminal color output

    I've added support for <b> <i> <u> and <s> tags
  15. O

    Feature - Implemented Terminal color output

    Ansi Terminal is now configurable: Let me know if you have any more remarks!
  16. O

    Feature - Implemented Terminal color output

    Yes, correct, this only influences what is printed to stdout. The GUI is not affected at all.
  17. O

    Feature - Implemented Terminal color output

    That should be easy, I hope 😄 Per-user means per-character, right?
  18. O

    Feature - Implemented Terminal color output

    I have changed the font parsing to use HtmlCleaner (which is already included in the project). I've encapsulated some of the functionality in their own classes based on separate concerns. This makes it easer to write unit tests (which are now also included), and to extend the functionality in...
  19. O

    Feature - Implemented Terminal color output

    What do you think should happen if the string contains other HTML tags than <font>? Should I skip the formatting completely in that case, or treat them as verbatim text and just replace the font tags?
  20. O

    Feature - Implemented Terminal color output

    Yes, you are absolutely right. I would usually be the first to contest using regexp for HTML "parsing", but it seemed to fit the KoLmafia style :p I will look into what the code base already uses for use-cases like this, and come up with a better solution.
Top