Search results

  1. H

    Bug toJson fails for nullish values

    I forgot that I had a branch that tinkered with this, but I've now created https://github.com/kolmafia/kolmafia/pull/2381.
  2. H

    Support for Java 21 (new LTS)?

    I upgraded Gradle to 8.8, and Spotless no longer finds any violations with openjdk21. However, I'm seeing several test failures due to Mockito being unable to mock certain standard library classes. It seems that for some strange reason, mockito-inline in the central maven repo is stuck on 5.2.0...
  3. H

    Bug toJson fails for nullish values

    IMO, debug logs should not be generated by a script unless there really is a bug in Mafia. That said, my inclination would be to make any function call from JS to ASH that passes an unrepresentable value to throw a JS exception, rather than passing null to some ASH function (whether...
  4. H

    Bug Maximizer Unequips Main Hand Then Complains Nothing in Main Hand

    Okay. I've sort of managed to reproduce: - Have two of a weapon in inventory. - Run a maximization query in the Modifier Maximizer tab that would select both weapons. - Put both items in the closet. - Click execute to run that query on both of the weapons. - Observe "Why bother putting a weapon...
  5. H

    Bug Maximizer Unequips Main Hand Then Complains Nothing in Main Hand

    Supposedly the maximizer has logic to support this case: https://github.com/kolmafia/kolmafia/blob/main/src/net/sourceforge/kolmafia/maximizer/Maximizer.java#L1654-L1766 But, as the comment suggests, it would be good to confirm that it still works.
  6. H

    Bug Maximizer Unequips Main Hand Then Complains Nothing in Main Hand

    It is possible that we're seeing: - Maximizer wants to equip a yule hatchet in the main hand. In doing so, it invokes retrieveItem() to pull the hatchet. - Maximizer then wants to equip a yule hatchet in the offhand. It theoretically could pull a second, but it's easier (and uses fewer...
  7. H

    Bug - Fixed Mafia Auto Updater Broken

    As I mentioned last month, the auto-updater referenced in this thread switched to using the Github API, so it should work today.
  8. H

    Is this possible for ccs - use fury skill only at maxfury

    That said, from staring at Mafia's code, it seems that it'll execute top-level code as you've written, and if it can't find the main function, then it'll silently exit. So you're probably running into the point that frono raised. (I've also run a few turns and confirmed that your script as...
  9. H

    Is this possible for ccs - use fury skill only at maxfury

    You probably want to wrap this in a special main function, as in https://wiki.kolmafia.us/index.php/Custom_Combat_Script#Consult_Scripts: void main(int initround, monster foe, string page) { if (my_fury() == my_maxfury()) { use_skill($skill[Furious Wallop]); } } Further, as fronobulax...
  10. H

    Bug You are too drunk to continue

    (https://github.com/kolmafia/kolmafia/pull/2335 should address this when it gets merged)
  11. H

    Bug You are too drunk to continue

    Hm. Mafia probably doesn't think that the skill does anything because you're in G-Lover, and "Liver of Steel" does not contain any G's. According to the wiki, that's actually incorrect, as passives seem to work as usual.
  12. H

    Bug - Fixed Mafia Auto Updater Broken

    Also, technically this isn't a Mafia bug so much as a change in infrastructure combined with a third-party tool relying on an unstable implicit API, namely the HTML formatting of the current version of Jenkins. (If I felt strongly enough, I'd move this thread to the Community Support section, or...
  13. H

    Bug - Fixed Mafia Auto Updater Broken

    FYI -- as of yesterday (after this discussion), it looks like the owner of that repository updated to fetch from github directly. So, update and I think you should be good. https://github.com/sapph42/KoLMafia-Launcher/commit/3b8d8f341e8cdd5939ee60503feface783f67b99
  14. H

    Bug Max Drunkenness drops when equipping weapon/off-hand

    `modtrace` is a bit of a hack, in that it will "fix" things short term but does not help us get much closer to figuring out what's going on. But it does seem like it confirms that it's (likely) the passive skill cache at fault if that fixes the problem, since that's one of the unique things that...
  15. H

    Bug You are too drunk to continue

    r27940 may address the ronin-break and king liberation scenarios, although I have only verified this in synthetic tests, not by actually ascending and breaking ronin or freeing the king. There seem to be other scenarios where this happens (including whatever ckb's been experiencing), so I don't...
  16. H

    Bug Max Drunkenness drops when equipping weapon/off-hand

    This is very surprising, and runs counter to my current understanding of the problem. Exactly what steps are you taking to log off & back on? The short version is that we calculate all the modifiers associated with passive skills and store those values so we don't have to keep recomputing them...
  17. H

    Bug You are too drunk to continue

    Ronin-break at least does not seem to trigger any modifier adjustment, which is a bug if true. I assumed that king liberation is a race condition.
  18. H

    Bug You are too drunk to continue

    These are useful data points. I'll try to get some time later this week to look at specifically the king-liberated and ronin-break handling. (Specifically: it sounds like ronin-break means that one of your permed skills starts having effect again? Drinking to Drink, probably?) In the meanwhile...
  19. H

    Excavator - gausie's spading script

    Github Actions compile that into JS on the `release` branch after each commit that's pushed to `main`. https://github.com/loathers/excavator/blob/main/.github/workflows/deploy_script.yml If you want to compile this yourself, you'll have to install one of the various TS -> JS transpilers...
  20. H

    Feature Request: Discuss Retry-After header in Generic Request

    > 503/429 messages, since that mechanism is designed to cover cases of scheduled maintenance with a known end-period Incidentally, that's not how I view either of those status codes. 429 ("Too many requests") serves a purpose directly related to Retry-After in terms of throttling, and it seems...
Top