Search results

  1. P

    Feature Book of Facts: Monster Items/Effects/Etc

    I'm 80% sure there isn't a thread for this. Which is fine! The item is 90% implemented. But there is a missing 10%. When you have the Book of Facts (or, more accurately, the skill "Just the Facts"), fighting monsters gives various things: some monsters drop items, others give effects, and so...
  2. P

    Bug - Fixed Javascript toJson leaves object keys in underscore_format rather than camelCase

    and Interesting that the keys are in a different order, but looks more or less correct
  3. P

    Bug - Fixed Javascript toJson leaves object keys in underscore_format rather than camelCase

    Garbo (and one or two other scripts I maintain that have used toJson) doesn't actually care about this change, because we're never translating mafia constants to json, but rather relying on it to make objects that contain mafia constants legible: In general, I agree that this is somewhat...
  4. P

    Feature Functions as first-class objects in ASH

    I don't actually have an intended use case here, admittedly, it was just an open question I had upon reading your post. It was mostly motivated by the fact that ash (to my knowledge) lacks union types and generic types, and so I think you'd need an overload to specify a single function that can...
  5. P

    Feature Functions as first-class objects in ASH

    There are a few ash functions that currently accept strings that are the names of functions. There is special handling to let js pass functions as those arguments instead; e.g., in adv1, js users can input a combat filter function as an actual function. e.g., I can do function handleCombat(page...
  6. P

    Bug 1952 Mickey mantle pick in Deck of Every Card crash

    Just hit this as well. Can confirm that it looks like the same core issue as the Mickey Mantle card
  7. P

    Bug 1952 Mickey mantle pick in Deck of Every Card crash

    Going into my session log, I see this before the crash: That final line wasn't visible in the CLI during the crash, but does appear to have been written to the log. I had to close mafia via the task manager, but doing so doesn't appear to have wiped or negatively impacted my preferences...
  8. P

    Bug 1952 Mickey mantle pick in Deck of Every Card crash

    I encountered this today and wrote it off as just a cosmic ray/random event, but given that Butts encountered it twice in the same place, it's a little odd. The code that triggered it just calls the cheat CLI command, which I don't see any recent changes to. This Could be a game bug, but the...
  9. P

    Feature - Implemented Relogging to improve ping

    Ran into an interesting bug: my character was trapped in the bookmobile noncombat, and I absentmindedly hit the "refresh all" button after I had presumably logged out due to inactivity: Because I was unable to hit main.php, I got some pretty unexpected results
  10. P

    Bug - Not A Bug Suddenly "modifier" is a reserved word

    https://github.com/kolmafia/kolmafia/commit/7e980695665762e5a30cd003a0807343a8683cd0
  11. P

    Bug - Fixed getPermedSkills() not correctly showing all skills in avatar path

    I initially created get_permed_skills with the intention of using it to help write a script that automatically perms skills for me when I ascend. While you can always use an xpath on the permery to determine what skills are available to be permed, it's helpful to have access to this information...
  12. P

    Feature - Implemented Prefs file backup/restore Draft PR

    I just got a mid-session pref-wipe. I haven't closed mafia yet, so if there's any diagnostic information I can provide let me know. I had been running a script and my computer went to sleep; when it woke up, the script was stalled but mafia was still open. When I directed mafia to open the...
  13. P

    Bug Shocking Lick preference doesn't change

    One slightly odd thing I notice is that despite only having one success message, we check two different strings to see if the responseText contains them. This was not in Gausie's very first PR for power plant, and git blame isn't giving me anything useful right now. case...
  14. P

    Bug - Not A Bug Items with numbers in their names break the maximizer

    You know what, it's because I don't have my pantogram pants with me, it looked like it was silently failing. You're absolutely right!
  15. P

    Bug - Not A Bug Items with numbers in their names break the maximizer

    I can't quite seem to make that work with the bonus keyword: both "69 bonus pantogram pants" and 69 "bonus pantogram pants" seemed to fail. It'll also run into trouble with items that have quotes in the name, but that's a small enough set that I think using the pilcrow system is fine. Either...
  16. P

    Feature Adventure Modifiers

    This feels worth a triple post: "noncomforcers":[] and "noncomforcers":["spikolodon","stench jelly","cincho exit","sneakisol"] The account I checked this on is in hardcore, so I can't check clara's bell, but also we might only care about whether or not the array is empty. I actually did...
  17. P

    Feature - Implemented Prefs file backup/restore Draft PR

    In my experience, when my Windows computer crashes while mafia is in operation, my user prefs file gets a very large number of \u0000s at the top of it; if I remember to delete these before opening mafia, my preferences are often right as rain, but if I don't, a lot of preferences get read...
  18. P

    New Content - Implemented Daily Deed for Grim Brother and ChibiBuddy

    I'm not sure if I agree; there's a CLI command, but is there a daily deed?
  19. P

    New Content Summer 2023 special challenge path - Legacy of Loathing

    There are two separate terraria, which also would contribute; goose is standard legal and I believe suffers from the same problem. I'm not in run so I can't grab html right now, unfortunately
Top