Search results

  1. ikzann

    Bug JavaScript bugs

    This patch should handle relay scripts correctly, both override scripts and those from the menu. Notably, in order to avoid breaking backwards compatibility with e.g. Guide, I've added a new GET argument to the relay menu scripts that triggers execution of any relay_x.js script vs simply...
  2. ikzann

    Bug JavaScript bugs

    Here is another patch to implement require() for both ASH + JS scripts. Can be tested with require("zlib.ash").getvar("verbosity") and require("test-require.js").main(0, Monster.get("zobmie"), "") with the below version of test-require.js installed.
  3. ikzann

    Bug JavaScript bugs

    This is a big patch to set up consult scripts, "lifecycle" scripts (choiceAdventureScript, betweenBattleScript, etc.), and combat filter functions. I think this mostly completes the refactoring to pull all the non-ASH-specific stuff apart from the ASH code, but it's still a little bit messy...
  4. ikzann

    Cargo Shorts GUI

    When updated, scripts that use file_to_buffer to load data files from disk will continue to load old versions until Mafia is closed, because the cache isn't cleared until Mafia is restarted. The shorts GUI uses a data file to store the HTML snippet it inserts into the page. If that's outdated...
  5. ikzann

    Cargo Shorts GUI

    Yeah, that's a frequent problem that results from Mafia's file cache, which should probably just get emptied any time there's an SVN update. I'll put submitting a patch for that on my todo list.
  6. ikzann

    Bug JavaScript bugs

    This fixes the bad error message when using a nonexistent function on the runtime library.
  7. ikzann

    Cargo Shorts GUI

    Can you double check that you are running the latest version?
  8. ikzann

    Cargo Shorts GUI

    I wasn't planning on adding more pockets directly to the GUI to keep the UI uncluttered - at least for the in-run view. I think ~all the items you mention should be available in the aftercore view, though. If you have an idea for how UI should work to add additional pocket buttons, I'd be happy...
  9. ikzann

    Feature Build Process Changes

    Here is an actually correct updated .classpath file. The line endings should be OK....
  10. ikzann

    Bug JavaScript bugs

    MCroft has helpfully committed as 20509
  11. ikzann

    Cargo Shorts GUI

    This is due to the bug in https://kolmafia.us/threads/javascript-bugs.25638/#post-160189
  12. ikzann

    Bug JavaScript bugs

    Fairly critical bug that breaks the Ezandora choice override script arrangement. Fixed in this patch. Parent ash interpreters weren't being passed down to children run via cli_execute, so the children could not access the relay request. This patch rewires that together. This was an error in my...
  13. ikzann

    Bug JavaScript bugs

    This is a tracking thread for early JavaScript bugs, since I expect there to be quite a few. Error messages when a value is missing on one of the globals are garbage. Translate record types for e.g. maximize return value. jsref command like ashref. Wiki documentation. (first stab here) Rhino...
  14. ikzann

    Feature Support for scripting in JavaScript

    Thanks so much, frono. I will start a separate thread to track bugs.
  15. ikzann

    Feature Support for scripting in JavaScript

    Is this ready to merge in your assessment? Are we still waiting on input from veracity?
  16. ikzann

    Feature Support for scripting in JavaScript

    Hm, it applied cleanly for me, but on double check there were some issues with the build.xml changes. Here's an updated patch. I executed the following commands to apply it. Please let me know if this does not work for you. svn checkout https://svn.code.sf.net/p/kolmafia/code/ kolmafia-code cd...
  17. ikzann

    Feature Support for scripting in JavaScript

    Oh, and I am quite sure I used svn add before generating the latest couple of patch files. If something is still not applying cleanly, please let me know.
  18. ikzann

    Feature Support for scripting in JavaScript

    Thanks, frono, and thanks for all the review you've done so far. Here's a patch that has rhino in a src/jar/ directory (placing the jar still needs to be done manually). Can split this up into a sequence of patches if you'd like, but i suspect it would be easier for someone with commit access to...
  19. ikzann

    Feature Build Process Changes

    It is not only needed at runtime. The code to run JS is deeply intertwined with Rhino and needs to know about Rhino changes at both compile time and runtime. Re: MCroft, I think the risk of namespace collisions is pretty limited. Everything still needs to be imported via its fully-qualified...
  20. ikzann

    Feature Build Process Changes

    Fronobulax, I think what you're seeing is that much of the code in /lib uses the jars. The jars are in the CLASSPATH for /lib, but not in the CLASSPATH for /src. You can see that in the current build.xml. I think that is why you see compile errors when you delete all the jars. When I try to...
Top