Search results

  1. gausie

    Bug - Fixed scrapbookCharges preference doesn't appear to be tracking Scrapbook Banish uses.

    This is a good PR for someone to contribute
  2. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    Done! Thanks. I'll merge this
  3. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    What do you think of this? https://github.com/kolmafia/kolmafia/pull/466/commits/386bf4a701942d31538a253f32c8d7689e394499
  4. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    I agree! I noticed that nothing else in that logging function actually set any prefs so I didn't want to. I'll do something with status to make it a little more performant.
  5. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    I ended up just checking for the drop line at the end of combat and removing the check from ResultProcessor entirely
  6. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    @Veracity care to cast your mind back a short 12 years and give your opinion? :P
  7. gausie

    New Content bottled Vampire Vintner the October 2021 IotM

    We have some of this already! https://github.com/kolmafia/kolmafia/blob/91ef5dfb477c47d306e726a924505e6d0add3d0f/src/net/sourceforge/kolmafia/persistence/ItemDatabase.java#L2163-L2189
  8. gausie

    Bug - Fixed Lucky Gold Ring thinks the Halloweiner Volcoino is a LGR Volcoino Drop

    I can see the bigger issue: https://github.com/kolmafia/kolmafia/blob/main/src/net/sourceforge/kolmafia/request/GenericRequest.java#L2418 This code means any request to adventure.php is treated as a combat by the results processor - this is the cause of the issue. I don't understand why its...
  9. gausie

    New Content Jan 2022 IOTM and 2022 IOTY

    We should also have a new item for the IotMTrackingPanel for the ball, since you can have the ball bound to your account, but not have it in your inventory. I've asked cdm to expose a flag for everything in that panel via api.php, which will be nice if he does.
  10. gausie

    Bug - Fixed Fire extinguisher effect in Smut Orc Logging Camp incorrect

    This is a great first PR for someone interested!
  11. gausie

    New Content Crimbo 2021

    This has me scurrying off to the dev server
  12. gausie

    Bug Maximizer bug

    Don't know but that's a good idea
  13. gausie

    Bug r26033 broke mall

    It's late in the UK so I will have to fix this tomorrow, unless someone else can get to it
  14. gausie

    Bug - Fixed Nash Crosby's Still buy 1 bottle of Definit ROW270

    Fixed in: https://github.com/kolmafia/kolmafia/pull/377
  15. gausie

    Bug - Fixed Nash Crosby's Still buy 1 bottle of Definit ROW270

    It means I'm missing a case on like 474 of NPCPurchaseRequest
  16. gausie

    Bug - Fixed Timespinning a Knob Goblin Embezzler resets the semirare counter

    https://github.com/kolmafia/kolmafia/pull/376 feel free to confirm that this fixes the problem. It should!
  17. gausie

    Bug - Fixed Timespinning a Knob Goblin Embezzler resets the semirare counter

    There are always parts of the mafia codebase where someone has gone "well surely this can only happen under X circumstances", only to be proved wrong years later.
  18. gausie

    Bug - Fixed crystalBallMonster incorrectly reset

    H unfurl="true"]https://ci.kolmafia.us/job/Kolmafia/26633/execution/node/3/ws/build/reports/tests/test/index.html[/URL] Huh, this is leaking between tests I think
  19. gausie

    Bug - Fixed crystalBallMonster incorrectly reset

    These aren't failing vocally or on GitHub. Can you post the test output?
Top