Search results

  1. H

    Static final

    You normally should be able to file a feature request in Issues, but we've apparently disabled that feature in favor of issue tracking on this forum. edit: there's also a "discussions" feature that's turned off for our repo. I enabled it for my fork.
  2. H

    Static final

    That item of -1 is very likely EquipmentRequest.UNEQUIP. With something like a Map, you'd want getOrDefault(EquipmentRequest.UNEQUIP).
  3. H

    Bug timesCast improperly tracked for Experience Safari (and presumably other player-targetted skills)

    So, timescast is powered by SkillDatabase, which tracks these via registerCasts, which in turn is only called in FightRequest (in-combat) and UseSkillRequest (out-of-combat). This is both much more pervasive yet not quite so pervasive as you might think -- a lot more cases are handled...
  4. H

    Bug Outfits and foldable items lead to broken state

    if you want to nerdsnipe me, post a patch that reproduces the issue in MaximizerTest.java
  5. H

    Bug - Fixed -buddy-bjorn and -crownofthrones maximizer keywords failing when bjorn or crown isn't equipped

    This should be fixed in r20939. Let me know if it isn't.
  6. H

    Static final

    Regarding static final: these qualifiers, when attached to a field, mean that the object is 1) not bound to an instance of the class, but rather to the class itself, and 2) cannot be reassigned. Static blocks are (logically) something else entirely, and refer to static initialization, which is...
  7. H

    Bug lastDesertUnlock improperly set upon completing Community Service, other paths?

    Well, my question is if those paths keep access after freeing the king, or if they need to make a meatcar afterwards. I expect that the underlying KoL code is unchanged from when the beach (well, probably shore, actually) was first introduced, in that it is actually a once-per-ascension unlock...
  8. H

    Bug lastDesertUnlock improperly set upon completing Community Service, other paths?

    That block is unconditionally setting lastDesertUnlock if kingLiberated() is true. Is that logic correct? Can players automatically access the beach at the conclusion of an Ed run? Pete? Exploathing? There's likely no reason to continue tracking this explicitly in a preference -- meatcar is no...
  9. H

    Debug logs beginning on 20210914

    Yeah, these numbers are Unix timestamps (seconds since midnight, Jan 1, 1970 UTC). I was concerned your daily _preferences weren't being properly cleared for some reason, but that looks correct. Anyways, glad to hear this works for you now. On one hand, we hope this won't happen as often once...
  10. H

    20933: Bundle resources found in lib/, unbundle jars. This fixes an issue with external licenses...

    This is correct. That's in a resources stanza, which is supposed to contain non-Java sources. https://docs.gradle.org/current/dsl/org.gradle.api.tasks.SourceSet.html#org.gradle.api.tasks.SourceSet:resources Right now, as part of the compileJava task (done by setVersion), we're copying all the...
  11. H

    Feature ASH language server features

    A few things, but here are the main ones: 1. We're internally discussing whether we'd like to spin one last point release before making the transition to github, and possibly dropping point releases entirely. We'd like to make the source as stable as reasonably possible before that. (So, bug...
  12. H

    20936: coverage++

    (Code) coverage is a measure of how much of the codebase is exercised by tests. ++ refers to an increment operator in various languages. This is frono's way of saying "This commit incrementally improves coverage by adding some more tests".
  13. H

    BatBrain -- a central nervous system for consult scripts

    Hm. WHAM is changing its damage estimates throughout the fight, interesting. The monster seems to have 75% damage resistance across the board (Ashes and Soot should be dealing 50% + 50% of your buffed myst = 720, but is only doing 180; spectral snapper should be doing 20% of buffed mus + 10-40...
  14. H

    Feature Upgrade Java version from 1.8 for building / running Mafia

    Also, note that Gradle doesn't support Java 17 yet, but they're... less behind (Gradle 7.0, which we're using, supports Java 16). Supposedly 7.2 does (sort of), but we had to downgrade to 7.0 because 7.2 was weirdly flaky for us.
  15. H

    Feature Upgrade Java version from 1.8 for building / running Mafia

    Apparently the current version of OpenClover refuses to instrument targets greater than Java 9. So if we wanted to upgrade today, we wouldn't be able to go very far without breaking our coverage reporting. There are other coverage libraries like JaCoCo which purport to support more modern...
  16. H

    BatBrain -- a central nervous system for consult scripts

    Got any numbers (attacks with damage, modifiers, stats)? Often these things can be mathed out with relatively few data points, especially for stronger characters.
  17. H

    Bug - Fixed -buddy-bjorn and -crownofthrones maximizer keywords failing when bjorn or crown isn't equipped

    We could also easily fix the logic to never `bjornify (none)`, although that's not in the pull request currently.
  18. H

    Bug - Fixed -buddy-bjorn and -crownofthrones maximizer keywords failing when bjorn or crown isn't equipped

    It looks like the core issue is that we're only setting useBjornFamiliar / useCrownFamiliar if the corresponding equipment is currently being worn. This is almost identically the bug as reported. Thanks! https://github.com/kolmafia/kolmafia/pull/5 even though I could commit this directly, as...
  19. H

    Bug - Fixed -buddy-bjorn and -crownofthrones maximizer keywords failing when bjorn or crown isn't equipped

    Okay. So, it looks like the only way to equip buddy bjorn is via the bjornify command. A silly maximizer expression: +100 bonus buddy bjorn, -tie yields: bjornify (none) (+100) along with some other super-tiebreakers as recommended actions (item droppers, meat droppers, rollover effects)...
  20. H

    Bug - Fixed -buddy-bjorn and -crownofthrones maximizer keywords failing when bjorn or crown isn't equipped

    Now, this isn't the full story, since I can still reproduce the "want to unequip back" side of things. But it may explain the incorrect bjornifying behavior.
Top