Bug - Not A Bug Suddenly "modifier" is a reserved word

[Aventuristo]

(I don't really know if this is a bug.) At least, as of v27456, so new it hasn't yet been described in the Github Changes forum, modifier is a reserved word in Ash. That broke ChIT, and one of my unpublished scripts. I can change my code, but I'm curious: What's going on with modifier?

 

[phreddrickk]

feat: modifier type (#1815) · kolmafia/kolmafia@7e98069

* feat: add modifier type * feat: allow calling ASH modifier methods with modifier * feat: expose split_modifiers * fix: get all modifiers * fix: sort $modifiers[] by name * refactor...

github.com

 

[Ryo_Sangnoir]

I've added a $modifier type, that you can use as $modifier[Meat Drop] or $modifier[Four Songs] (for example), to use in functions like numeric_modifier(item, modifier) or effect_modifier and so on.

I've also made a function split_modifiers(string) that takes a $modifier[Modifiers] string and splits it into a map of modifiers to strings.

 

[Aventuristo]

Thanks. (I didn't think it was really a bug, but I had to put something when posting.) Now I have to modify my vim syntax colorer. And my script that builds a SQL database of KoL entities.

 

[mandybrigwell]

Aha, that explains uberPVPOptimiser suddenly not working!