Bug - Fixed NPE adventuring with Pisces in the Skyces in mood

[darkcodelagsniper]

In r15518 Adventuring via the relay browser with mood containing

When I run low on Pisces in the Skyces, use 1 tobiko marble soda

The effect isn't renewed, and a debug log is produced with an NPE:

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
        KoLmafia v16.8 r15518, Windows 8.1, Java 1.8.0_31
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Please note: do not post this log in the KoLmafia thread of KoL's
 Gameplay-Discussion forum. If you would like the KoLmafia dev team
 to look at it, please write a bug report at kolmafia.us. Include
 specific information about what you were doing when you made this
 and include this log as an attachment.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Timestamp: Mon Mar 02 17:00:18 GMT 2015
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=


Unexpected error, debug log printed.
class java.lang.NullPointerException: null
java.lang.NullPointerException
	at net.sourceforge.kolmafia.session.ResponseTextParser.hasResult(ResponseTextParser.java:162)
	at net.sourceforge.kolmafia.request.GenericRequest.hasResult(GenericRequest.java:903)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:247)
	at net.sourceforge.kolmafia.session.InventoryManager.doRetrieveItem(InventoryManager.java:995)
	at net.sourceforge.kolmafia.session.InventoryManager.retrieveItem(InventoryManager.java:440)
	at net.sourceforge.kolmafia.session.InventoryManager.retrieveItem(InventoryManager.java:376)
	at net.sourceforge.kolmafia.session.InventoryManager.retrieveItem(InventoryManager.java:366)
	at net.sourceforge.kolmafia.request.UseItemRequest.run(UseItemRequest.java:1427)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:286)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:249)
	at net.sourceforge.kolmafia.moods.MoodTrigger.execute(MoodTrigger.java:322)
	at net.sourceforge.kolmafia.moods.MoodManager.execute(MoodManager.java:590)
	at net.sourceforge.kolmafia.moods.MoodManager.execute(MoodManager.java:482)
	at net.sourceforge.kolmafia.moods.RecoveryManager.runBetweenBattleChecks(RecoveryManager.java:148)
	at net.sourceforge.kolmafia.request.RelayRequest.sendWarnings(RelayRequest.java:3024)
	at net.sourceforge.kolmafia.request.RelayRequest.run(RelayRequest.java:2927)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:286)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:249)
	at net.sourceforge.kolmafia.webui.RelayAgent.readServerResponse(RelayAgent.java:567)
	at net.sourceforge.kolmafia.webui.RelayAgent.performRelay(RelayAgent.java:161)
	at net.sourceforge.kolmafia.webui.RelayAgent.run(RelayAgent.java:134)

Using tobiko marble soda via the CLI, or with "up pisces in the skyces" works fine.

Other effects in mood aren't seeming to cause a problem.

 

[Darzil]

r15521 should at least prevent the NPE.

Edit - I couldn't replicate the issue.

 

[Veracity]

I, also, was unable to replicate the issue.

 

[darkcodelagsniper]

Still having the issue in r15520, updated to r15521 and the problem is resolved (No NPE and the tobiko marble soda is retreived and used by the mood correctly)