Bug - Fixed JavaScript: bufferToFile() fails due to type issues (+ patch added)

[philmasterplus]

The bufferToFile(string, string) function is the JS-equivalent of the ASH function buffer_to_file(string, string). However, calling this function in JS currently fails with:

> js require("kolmafia").bufferToFile("asdf", "foo.txt");

Script exception: Function 'buffer_to_file( string, string )' undefined. This script may require a more recent version of KoLmafia and/or its supporting scripts. (command line#1)

I suspect this is because the "compatibility layer" between ASH and JS does not translate string type to buffer for this call. Unfortunately, there is no native "Buffer" type in our JS runtime, so we can't use this function at all.

 

[fronobulax]

What's the action here? Bug - Won't Fix and document the workaround?

 

[MCroft]

Is this fileToBuffer or bufferToFile? you mention both below.

The fileToBuffer(string, string) function is the JS-equivalent of the ASH function file_to_buffer(string, string). However, calling this function in JS currently fails with:

> js require("kolmafia").bufferToFile("asdf", "foo.txt");

> ashref buffer

boolean buffer_to_file( buffer, string )
buffer file_to_buffer( string )

> jsref buffer

boolean bufferToFile(string, string)
string fileToBuffer(string)

> js require("kolmafia").fileToBuffer("foo.txt");

Returned:

 

[philmasterplus]

My bad. It's bufferToFile(). I'll fix the first post.

fileToBuffer() worked fine in JS the last time I checked.

 

[philmasterplus]

Here's a patch that special-cases bufferToFile() so that, if the first argument is a String, it is converted to a buffer (Java StringBuffer) before being passed to the actual function. It does not affect the ASH runtime in any way.

 

[gausie]

Thanks for this phil! r20629