Bug "Explore Next Unexplored Square" doing unnecessary squares

[VinnyB]

With my 2 cartography freebie squares being (4,2) and (3,1), I was allowed to manually continue exploring from (2,1) to (1,1) etc. After a few turns I clicked the "Explore Next Unexplored Square" and it went back and filled out (4,1)

 

[fredg1]

The current implementation doesn't look at an "optimal path".

The path searched is hard-coded.

    //  1<--2<--3<--4<--5
    //  v
    //  6   7-->8   9->10
    //  v   ^   v   ^   v
    // 11  12  13  14  15
    //  v       v   ^   v
    // 16  17  18->19  20
    //  v   ^ \
    // 21->22  23->24->25

    private static final Integer [] searchOrder = {
        // IntegerPool.get( 5 ),
        IntegerPool.get(  4 ), IntegerPool.get(  3 ), IntegerPool.get(  2 ),
        IntegerPool.get(  1 ), IntegerPool.get(  6 ), IntegerPool.get( 11 ),
        IntegerPool.get( 16 ), IntegerPool.get( 21 ), IntegerPool.get( 22 ),
        IntegerPool.get( 17 ), IntegerPool.get( 23 ), IntegerPool.get( 24 ),
        IntegerPool.get( 25 ), IntegerPool.get( 12 ), IntegerPool.get(  7 ),
        IntegerPool.get(  8 ), IntegerPool.get( 13 ), IntegerPool.get( 18 ),
        IntegerPool.get( 19 ), IntegerPool.get( 14 ), IntegerPool.get(  9 ),
        IntegerPool.get( 10 ), IntegerPool.get( 15 ), IntegerPool.get( 20 ),
    };

As you can see, mafia is currently ill-equipped to handle as little as you starting towards the bottom.

 

[VinnyB]

Ah okay, good to know
Thanks!