Bug - Fixed Encounter Listing Double Counting

T

Thundergate

New member
r26871 and updated to
r26886 and still occurring.

I have been using Mafia to track number of Furvivity encounters in the PLD in Hobopolis for years to track the number to 8 and then to dive in the Heap. When I get close to 8, I set the zone to "Show in Browser" so that I can manually click the last one without going over. And I also have "I Refuse!" set to "Show in Browser" so it will stop when I get this encounter.

In the 2 versions above, it has started to 'double count' the "show in browser" adventure. Meaning: when I get to 7 and change the pull down to "show in browser" once I get the 8th, it stops and when I manually choose the right non-combat selection, it forwards the count to 9 (instead of 8, as it should and has always done in previous versions I have used). And when I get "I Refuse!" and click on it manually, I get a count of 2, whereas it's always been 1 in the past.

Please let me know if I need to explain better or clarify anything. Thanks for your help!
 
Last edited by a moderator:
Veracity

Veracity

Developer
Staff member
How are you "tracking"? In the Encounter Listing" pane on the Adventure Frame of the Main Interface?
How do you "manually choose the right non-combat selection"? via the "choice" command? In the browser?

I experimented with the relay browser.
I adventured until I got to a choice adventure - of the "You cannot walk away from this" variety.
Encounter Listing shows (1).
I repeatedly click on the "Last Adventure" container in the charpane.
The browser submitted a visit to the container zone, KoL redirected to choice.php, and the choice was displayed again.
Encounter Listing shows (2) and then (3) and then (4).

So, yes, apparently we are counting each time you visit the choice page as an Encounter.

Clicking on "show in browser" is identical: you click that, it requests main.php, KoL redirects to the choice.

I just fixed the situation where doing that would call visitChoice() each time and increment settings each time.

I don't recall any changes to Encounter counting, but I'll take a look.

Edit: session log...

Code: 
[29569] Barf Mountain
Encounter: This Ride Is Like...  A Rollercoaster Baby Baby
Encounter: This Ride Is Like...  A Rollercoaster Baby Baby
Encounter: This Ride Is Like...  A Rollercoaster Baby Baby
Took choice 1073/6: skip adventure and guarantees this adventure will reoccur
choice.php?pwd&whichchoice=1073&option=6

Yeah, that doesn't look right.
 
ckb

ckb

Minion
Staff member
I am tracking down an issues that appeared in a script of mine I have been using for years and I think it may be related to this change.
it looks like some 'Encounters' that used to be recorded are no longer recorded.

This is what it looks like before this change:

[2424] The Tunnel of L.O.V.E.
Encounter: The Tunnel of L.O.V.E.
Took choice 1222/1: Enter the Tunnel
choice.php?whichchoice=1222&option=1&pwd

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Entrance
Took choice 1223/1: (free) fight LOV Enforcer
choice.php?whichchoice=1223&option=1&pwd
Encounter: LOV Enforcer
Round 0: ckb1 wins initiative!

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Equipment Room
Took choice 1224/3: acquire LOV Earrings
choice.php?whichchoice=1224&option=3&pwd

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Engine Room
You acquire an item: LOV Earrings
Took choice 1225/1: (free) fight LOV Engineer
choice.php?whichchoice=1225&option=1&pwd
Encounter: LOV Engineer
Round 0: ckb1 wins initiative!

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Emergency Room
Took choice 1226/2: 50 adv of Open Heart Surgery (+10 fam weight)
choice.php?whichchoice=1226&option=2&pwd

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Elbow Room
You acquire an effect: Open Heart Surgery (50)
Took choice 1227/1: (free) fight LOV Equivocator
choice.php?whichchoice=1227&option=1&pwd
Encounter: LOV Equivocator
Round 0: ckb1 wins initiative!

[2424] The Tunnel of L.O.V.E.
Encounter: L.O.V. Emporium
Took choice 1228/3: acquire LOV Extraterrestrial Chocolate
choice.php?whichchoice=1228&option=3&pwd
You acquire an item: LOV Extraterrestrial Chocolate



And after the change:

[648] The Tunnel of L.O.V.E.
Encounter: The Tunnel of L.O.V.E.
Took choice 1222/1: Enter the Tunnel
choice.php?whichchoice=1222&option=1&pwd

[648] The Tunnel of L.O.V.E.
Encounter: L.O.V. Entrance
Took choice 1223/1: (free) fight LOV Enforcer
choice.php?whichchoice=1223&option=1&pwd
Encounter: LOV Enforcer
Round 0: ckb1 wins initiative!

Took choice 1224/3: acquire LOV Earrings
choice.php?whichchoice=1224&option=3&pwd

[648] The Tunnel of L.O.V.E.
Encounter: L.O.V. Engine Room
You acquire an item: LOV Earrings
Took choice 1225/1: (free) fight LOV Engineer
choice.php?whichchoice=1225&option=1&pwd
Encounter: LOV Engineer
Round 0: ckb1 wins initiative!

Took choice 1226/2: 50 adv of Open Heart Surgery (+10 fam weight)
choice.php?whichchoice=1226&option=2&pwd

[648] The Tunnel of L.O.V.E.
Encounter: L.O.V. Elbow Room
You acquire an effect: Open Heart Surgery (50)
Took choice 1227/1: (free) fight LOV Equivocator
choice.php?whichchoice=1227&option=1&pwd
Encounter: LOV Equivocator
Round 0: ckb1 loses initiative!

Took choice 1228/3: acquire LOV Extraterrestrial Chocolate
choice.php?whichchoice=1228&option=3&pwd
You acquire an item: LOV Extraterrestrial Chocolate
 
Veracity

Veracity

Developer
Staff member
If I knew how to do it, I would move that post to this thread:

Bug - Fixed - Doghouse Adventures not setting lastEncounter

As of r26913, it looks like the Hallowiener Dog adventures are no longer changing the lastEncounter preference. [837] The SMOOCH Army HQ Took choice 1106/3: acquire familiar food choice.php?pwd&whichchoice=1106&option=3 You acquire an item: Ghost Dog Chow Preference _concoctionDatabaseRefreshes...
kolmafia.us

The same response applies: I have a fix in an open PR.
 
You must log in or register to reply here.
Top