IronTetsubo
Member
I was happily adventuring on, and started doing the cyrpt - and noticed that the evilometer info wasn't showing up on the side. After some poking around in the code, it looks like the evil level of the various areas only gets properly set if kolmafia sees you get the evilometer. I could have sworn I got the quest with this kolmafia instance, but I play from multiple locations so I very well could not have gotten the evilometer, and thus not had it show up properly. But hey, that's bad - my take is it shouldn't matter where the user played before, kolmafia should figure out the right details, and if the cyrpt quest is active at all, we should figure out and properly set the various evil levels. So, I whipped up a patch to do that. I *think* this is in the right place - as a part of the initial login process, but after the QuestLogRequest calls happen so we know that the status of the quest is properly set - the patch is very simple, it basically checks if the cyrpt quest is active at all, and if it is, goes and uses the evilometer which then does the right thing around setting the evil levels, and thus has it properly display in the relay browser. Patch is against r10906, and builds/runs/does what it's supposed to. If this is better suited somewhere else, let me know, I'm happy to put together an improved version.
In my 30 seconds of thinking about it, I don't believe there are any other quests where this sort of checking is appropriate, but if so, let me know and I'll try to get those in as well.
In my 30 seconds of thinking about it, I don't believe there are any other quests where this sort of checking is appropriate, but if so, let me know and I'll try to get those in as well.
