Bug - Fixed Unreasonably complex expression for expert panhandling

Tom Sawyer

Member
Anyone else seeing this when running scripts or auto-adventuring?

It does not seem to stop mafia from working, just keeps popping up over and over in the CLI
 
Seems to happen most frequently (possibly only) when dealing with scaling monsters, and last I heard no one had a clue how or why it was happening, other than a guess that somehow something was returning a non-integer result when that should be impossible.
 

arbarbonif

New member
I'm seeing it everywhere, 2 the first round of fighting a business hippy (won initiative) and 5 after killing him. I'm in Way of the Surprising Fist, adventuring manually through the relay browser. I'm also getting two lines everytime the auto mood casting fires off a cast of anything.
[634] White Citadel
Encounter: business hippy
Round 0: twinky terwilliker wins initiative!
Unreasonably complex expression for expert panhandling
Unreasonably complex expression for expert panhandling
Round 1: twinky terwilliker casts DRUNKEN BABY STYLE!
Round 2: business hippy takes 157 damage.
Round 2: You relax, listening to the comforting drone of Q's circuitry.
You gain 15 hit points
You gain 8 Muscularity Points
Round 2: twinky terwilliker wins the fight!
After Battle: Q surveys the scene from atop the throne and sighs.
You gain 14 Meat
You acquire an item: reodorant
You acquire an item: massive bag of catnip
After Battle: Pebkac gives you a weird, lopsided grin. What's weird about it is that you can even tell, considering the ski-mask he's wearing.You gain ¤±You gain «You g¢
You gain 17 Fortitude
You gain 11 Wizardliness
You gain a Mysticality point!
You gain 4 Cheek
Unreasonably complex expression for expert panhandling
Unreasonably complex expression for expert panhandling
Unreasonably complex expression for expert panhandling
Unreasonably complex expression for expert panhandling
Unreasonably complex expression for expert panhandling
 

GadTheHero

New member
I have been in a BHY run when I first noticed it. Has happened at least since daily build 9908 and is producing these messages for both skills and item, both when adventuring and skill casting:

"[1389] The Haunted Sorority House
Encounter: Laci Chestersbury, the Sexy Chemical Engineer Vampire
Strategy: skill shieldbutt
Round 0: gadthehero wins initiative!
Round 0: gadthehero casts SPRING RAINDROP ATTACK!
You gain 21 hit points
You gain 23 Muscularity Points
You lose 38 hit points
Round 1: gadthehero casts SHIELDBUTT!
You lose 37 hit points
Round 2: gadthehero casts SHIELDBUTT!
You lose 38 hit points
Round 3: gadthehero casts SHIELDBUTT!
You lose 36 hit points
Round 4: gadthehero casts SHIELDBUTT!
You lose 37 hit points
Round 5: gadthehero casts SHIELDBUTT!
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Round 6: gadthehero executes a macro!
Round 6: gadthehero casts SHIELDBUTT!
Round 7: gadthehero wins the fight!
You gain 97 Beefiness
You gain 49 Mysteriousness
You gain a Mysticality point!
You gain 55 Smarm
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace"

"Casting Cannelloni Cocoon 1 times...
You gain 974 hit points
Cannelloni Cocoon was successfully cast.
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Casting Smooth Movement 5 times...
You acquire an effect: Smooth Movements (duration: 50 Adventures)
Smooth Movement was successfully cast.
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Validating adventure sequence...
Requests complete."

I wanted to post some examples were both expert panhandling and intrinsic spiciness triggered this message simultanous from the other day, but it doesn't show up in the session logs.
 

arbarbonif

New member
I ascended into a normal ascension and I'm still seeing it, this time with expert panhandling and the intrinsic for the navel ring (which I'm not going to try and spell). I'm also having intermittent trouble hitting adventure.php, it waits and waits but never gets to it (no idea if it is related), I can still hit other pages no problem (even after trying to hit an adventure.php page).

Interesting. I updated to the most recent daily build, and did some adventures before starting the relay browser and then I stopped seeing it for a while. It did show up again eventually tho (after about 35-40 adventures). I had run about 24 of those adventures through the UI (12 before I started the relay browser).

Go-go-potentially.irrelevant.details
 
Last edited:

holatuwol

Developer
I don't understand how maximizer works yet, so I'm going to bump up the stack depth to 1024 to see if it helps alleviate the problem (it might just make everything worse, though).
 

slyz

Developer
Modifier expressions are rarely very complicated. I haven't tried playing around with Expression.java yet, but I noticed is that an Expression's stack is never emptied. That shouldn't matter, though, right?
 

jasonharper

Developer
The stack space required to evaluate a given expression is constant, and is no more than about 10 for any existing modifier - the only reason the stack limit was as high as 128 was to allow more complicated expressions in scripts that call modifier_eval(). Making the limit even higher cannot possibly fix the problem, although it might slow down the appearance of error messages (assuming that the problem, whatever it might be, is gradual rather than sudden).
 

GadTheHero

New member
Yes, it's still happening. I had no problems for the first 192 turns today.

After [1639] I equipped the fossilized necklace and 60 turns later it started again. I had just acquired the effect "You Can Taste the Darkness" from a Cooler out of space.

"[1699] The Haunted Sorority House
Encounter: Kelli Rothgate-Sheltonbury, the Sexy Entomologist Vampire
Round 0: gadthehero wins initiative!
Round 0: gadthehero attacks!
Round 1: gadthehero attacks!
Round 2: gadthehero wins the fight!
You gain 97 Strongness
You gain 53 Enchantedness
You gain 39 Smarm
You gain a Moxie point!
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace

[1701] The Haunted Sorority House
Encounter: The Unliving Room
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
You made short work of some skeletons.
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace

[1702] The Haunted Sorority House
Encounter: Ainsli Hargrove, the Sexy Ventriloquist Skeleton
Round 0: gadthehero wins initiative!
Round 0: gadthehero attacks!
You lose 16 hit points
Round 1: gadthehero attacks!
You lose 16 hit points
Round 2: gadthehero attacks!
Round 3: gadthehero wins the fight!
You gain 97 Beefiness
You gain 50 Mysteriousness
You gain 42 Sarcasm
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Casting Leash of Linguini 10 times...
You acquire an effect: Leash of Linguini (duration: 100 Adventures)
Leash of Linguini was successfully cast.
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace
Casting Smooth Movement 10 times...
You acquire an effect: Smooth Movements (duration: 100 Adventures)
Smooth Movement was successfully cast.
Unreasonably complex expression for fossilized necklace
Unreasonably complex expression for fossilized necklace"

Hope this date is of any help.
 

holatuwol

Developer
Modifier expressions are rarely very complicated. I haven't tried playing around with Expression.java yet, but I noticed is that an Expression's stack is never emptied. That shouldn't matter, though, right?
I'd have to take a closer look at modifier maximizer since I've never looked at the code short of seeing why this exception would be thrown.

Theoretically speaking, if the Expression is only ever used once, then it's not a problem. It will be problematic if expressions get reused, and it would explain why it would start happening as you do more stuff while logged in to KoL, but I haven't confirmed if this is the case.
 
A clannie posted this today, which suggests there are errors when calculating the stats of scaling monsters (which seem to be where this error pops up the most frequently), but don't know if it's at all helpful beyond that, since I don't have anything other than this.
You're fighting an alien hamsterpus HP: 2147483647, Atk: 2198, Def: 555
Looks like an overflow occurred on the HP, in particular.

EDIT: The attack and def are correct (character's moxie was about 2200, muscle was around 550), but something happened in the HP calculation. And it happens unpredictably.
HP: 433, Atk: 2283, Def: 578
HP: 2147483647, Atk: 2285, Def: 576
 
Last edited:

jasonharper

Developer
r9924 added a bit more detail to the "unreasonably complex" message. I need to see that detail, specifically a number following "ArrayIndexOutOfBoundsException:".
 

PsyMar

Member
The number you're looking for is 200. I could attach some or all of my 377-kB error log if you would like, or I can just copy in this:


Unexpected error, debug log printed.
class java.lang.ArrayIndexOutOfBoundsException: 200


Edit: I'd been getting it, mainly, for Kung Fu Fighting, but also for some other things (I think shining halo, and also fam:Exotic Parrot once.)
 
Last edited:

jasonharper

Developer
If you're actually getting a debug log, you're experiencing something different - at least, nobody else has been reporting that, and r9924 shouldn't have introduced any new possibilities for such an error. So, I think you'd better post that debug log...
 

PsyMar

Member
It's actually r9925, but here you go... I had to downgrade because of this.
 

Attachments

  • DEBUG_20111024.txt
    380 KB · Views: 43

jasonharper

Developer
Every error in that debug log is due to something having gone wrong in the internals of Daily Deeds, which I don't immediately see a reason for. I do not believe it is related to the subject of this thread at all, and in any case does not contain the information I was asking for, which should appear on the same line as the "Unreasonably..." message.
 
Top