Bug - Fixed Missing choiceadventure defaults

Noted in grotfang's latest confirm that defaults.txt had been updated... checked it and the highest defaulted choiceadventure is 458. That means the following adventures, according to the KoLwiki, don't have defaults.

460. Space Trip (the Bridge)
461. Space Trip (Navigation Console)
462. Space Trip (Diagnostics)
463. Space Trip (Alpha Quadrant)
464. Space Trip (Beta Quadrant)
465. Space Trip (Planet)
467. Space Trip (Combat)
468. Space Trip (Starbase Hub)
469. Space Trip (General Store)
470. Space Trip (Military Surplus Store)
471. DemonStar
472. Space Trip (Astrozorian Trade Vessel, Alpha Quadrant)
473. Space Trip (First encounter with Murderbot Miner)
474. Space Trip (Encounter with the party-loving spieces)
475. Space Trip (Astrozorian Merchant Vessel, Beta Quadrant)
477. Space Trip (Gamma Quadrant)
478. Space Trip (The Source)
480. Space Trip (Encounter of Scadian ship)
483. Space Trip (Scadian Homeworld)
484. Space Trip (End)
485. The Fighters of Fighting
486. Dungeon Fist!
488. Meteoid (Bridge)
489. Meteoid (SpaceMall)
490. Meteoid (Underground Complex)
491. Meteoid (Get Score)
497. SHAFT!
502. Arboreal Respite
503. The Road Less Traveled
504. Tree's Last Stand
505. Consciousness of a Stream
506. Through Thicket and Thinnet
507. O Lith, Mon

Click to expand...

It's possible we have handling for more, but those are the ones that the Wiki knows we're missing... That explains why my character that defaults to the (displayed) Show in Browser gets unsupported choice adventure messages...

r8767

Lightly tested at best.

We're actually missing a lot of defaults. Is this something that should be remedied (defaults set to 0) or is it intentional? In hobopolis today it was pointed out that 226 and 227 are missing (something I hadn't noticed since I've had them set locally for a LONG time now) and that this lead to an unsupported message when setting 225 (the tent) to automatically enter as a music player (and I imagine a mosher/coin collector).

I have edited my working copy of defaults.txt to handle those, but would like a brief input as to whether the other choice adventures that are missing should be entered. A full list can be found here

If they aren't supported, you get the results of a show in browser, but with an error message as opposed to being gracefully handled...

I know. Hence my question.

Meh. It couldn't hurt.

With defaults missing, you get a stop error, while it says show in browser (if you look at the choice tab). This leads people to think that they've set it to that already...

Most of the ones you listed above (like the Arcade choices) do not show up in the choice tab.

If we list a choice in ChoiceManager.CHOICE_ADVS, is shows up in the choice tab - and we need to have a default for it, even if it is to "show in browser".

If we do NOT list a choice in CHOICE_ADVS, the user cannot configure it through the GUI. Those might be ones that you simply cannot automate through (like the Arcade games) or ones which we configure in other ways (like the Giant Castle Chore Wheel) or ones which there is only one rational option (like the Palindome quest items) which we auto configure to the raional thing.

We don't HAVE to have choice adventure defaults for choice adventures which are not in adventure.php locations, since you cannot see them through automation.

If you CAN automate and find a choice adventure, and there is no "rational" default, we need to add a "manual control" default. For example, I notice that the Krakrox agua de vida choices are not configurable and have no defaults. Those probably all need "0".

In any case, please do not thoughtlessly add defaults to all choices. Use thought. Decide if the choice NEEDS a default, and if so, what it should be - which might be manual control!

That's fine. I've been in London for the weekend so haven't done anything more yet, but I'll work through them. I'll err on the side of caution and post a list of ones I think can be changed in this thread for review by anyone who wishes to do so before making the commit. That shall probably be on Tuesday since I am also busy tomorrow evening.