Page 7 of 7 FirstFirst ... 5 6 7
Results 61 to 67 of 67

Thread: VIP Hopping! Quick clanhop to BAfH for all VIP room goodies!

  1. #61
    Junior Member
    Join Date
    Dec 2011
    Posts
    5

    Default

    So - fair warning, and a big apology to bumcheekcity for the 20ish kmails before I managed to abort - if you are *not* whitelisted with your own clan (I wasn't, never clanhopped before with this toon), the script will go into an infinite loop sending him requests to whitelist, as you can't rejoin your own clan, and bassoon...

  2. #62
    Senior Member
    Join Date
    Mar 2012
    Posts
    188

    Default

    So - fair warning, and a big apology to bumcheekcity for the 20ish kmails before I managed to abort - if you are *not* whitelisted with your own clan (I wasn't, never clanhopped before with this toon), the script will go into an infinite loop sending him requests to whitelist, as you can't rejoin your own clan, and bassoon...
    Originally Posted by biggles View Post
    I dug into the script, and it looks like there are two bugs:

    - goto_clan should only kmail bumcheekcity if the call is to access the bafh clan.
    - goto_clan shouldn't recurse if it just failed getting into a clan.

    see below for an (untested) attempt to fix the issue:
    Code:
    	if(page.contains_text("You have submitted a request to join") && target_id == 90485) {
    didn't need to bother with the second point since the recursion call only occurs now on your origin clan. There's theoretically still an edge case where origin_clan == target_clan == bafh clan, i.e., you're trying to go to bafh from bafh, but you should already have access by definition to bafh in that case.

  3. #63
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,287

    Default

    It's been over a year since the last response and only now is that bug reported? whoa. I guess I'll have to remember how this script works and take care of that.
    If people like my scripts, please send me stuffed Hodgmen.
    Universal Recovery, OCD Inventory Control, CounterChecker, newLife, ChIT.


  4. #64
    Senior Member
    Join Date
    Mar 2012
    Posts
    188

    Default

    Bet you thought you were done with this one. I also found a bug with the "return" command - the origin clan wasn't being parsed properly because of the new PVP Allegience section displayed. It was matching that first, and thus thought I was already "home" because my PVP Allegience matched the clan I was in previous to switching to bafh. Both are fixed in the attached script - figured it's small enough I'd just post it, but happy to diff if you prefer that. On a completely unrelated note, ever think about putting all this into a version control system somewhere? I'd recommend github if you don't have any preferences, happy to walk you through how to do it - git is fairly daunting at first, but it's actually pretty easy if you've got someone to explain the ins and outs - and github has a really nice code management interface. Anyways, see attached for fixes.
    Attached Files

  5. #65
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,287

    Default

    Updated with everything IronTetsubo suggets, fix for VIP swimming and also use the new get_clan_id() function.
    If people like my scripts, please send me stuffed Hodgmen.
    Universal Recovery, OCD Inventory Control, CounterChecker, newLife, ChIT.


  6. #66

    Default

    Unfortunately, get_clan_id() isn't working properly yet (if you've done any pvp this season). It should be fixed within the next day.

  7. #67
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,287

    Default

    Oh dear. Then let's just call this a pre-emptive update since it will be working within 24 hours.
    If people like my scripts, please send me stuffed Hodgmen.
    Universal Recovery, OCD Inventory Control, CounterChecker, newLife, ChIT.


Similar Threads

  1. Clan Hopping
    By Bors in forum Community Support
    Replies: 20
    Last Post: 06-04-2014, 11:04 PM
  2. Quick ? need a little help.
    By Cereal Killer 024 in forum Community Support
    Replies: 13
    Last Post: 11-06-2013, 07:12 PM
  3. Replies: 0
    Last Post: 06-26-2010, 10:30 PM
  4. Quick Q:
    By icon315 in forum Community Support
    Replies: 2
    Last Post: 02-05-2010, 02:39 AM
  5. Mailing crimbo goodies for clan
    By Darkness in forum Scripting Discussion
    Replies: 2
    Last Post: 12-25-2006, 12:47 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •