Bug - Fixed Null pointer when viewing my A.M.C. gremlin in the Ice House

Ryo_Sangnoir

Developer
Staff member
When viewing the Ice House in the museum, I receive the message:
Code:
You peer into the ice house and see the perfectly-preserved A.M.C. gremlin, right where you left it.
This leads to a null pointer exception:
Code:
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
        KoLmafia v17.12 r18890, Windows 10, Java 1.8.0_181
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Please note: do not post this log in the KoLmafia thread of KoL's
 Gameplay-Discussion forum. If you would like the KoLmafia dev team
 to look at it, please write a bug report at kolmafia.us. Include
 specific information about what you were doing when you made this
 and include this log as an attachment.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Timestamp: Sat Sep 15 15:47:46 BST 2018
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=


Unexpected error, debug log printed.
class java.lang.NullPointerException: null
java.lang.NullPointerException
	at net.sourceforge.kolmafia.session.BanishManager.banishMonster(BanishManager.java:349)
	at net.sourceforge.kolmafia.session.ChoiceManager.visitChoice(ChoiceManager.java:13072)
	at net.sourceforge.kolmafia.session.ChoiceManager.postChoice1(ChoiceManager.java:7445)
	at net.sourceforge.kolmafia.request.GenericRequest.processResponse(GenericRequest.java:2581)
	at net.sourceforge.kolmafia.request.GenericRequest.retrieveServerReply(GenericRequest.java:2495)
	at net.sourceforge.kolmafia.request.GenericRequest.retrieveServerReply(GenericRequest.java:2068)
	at net.sourceforge.kolmafia.request.GenericRequest.externalExecute(GenericRequest.java:1626)
	at net.sourceforge.kolmafia.request.GenericRequest.execute(GenericRequest.java:1609)
	at net.sourceforge.kolmafia.request.GenericRequest.run(GenericRequest.java:1328)
	at net.sourceforge.kolmafia.request.RelayRequest.run(RelayRequest.java:3254)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:286)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:249)
	at net.sourceforge.kolmafia.textui.RuntimeLibrary.visit_url(RuntimeLibrary.java:2473)
	at sun.reflect.GeneratedMethodAccessor218.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.sourceforge.kolmafia.textui.parsetree.LibraryFunction.execute(LibraryFunction.java:104)
	at net.sourceforge.kolmafia.textui.parsetree.FunctionCall.execute(FunctionCall.java:154)
	at net.sourceforge.kolmafia.textui.parsetree.Assignment.execute(Assignment.java:103)
	at net.sourceforge.kolmafia.textui.parsetree.BasicScope.execute(BasicScope.java:417)
	at net.sourceforge.kolmafia.textui.parsetree.UserDefinedFunction.execute(UserDefinedFunction.java:142)
	at net.sourceforge.kolmafia.textui.Interpreter.executeScope(Interpreter.java:419)
	at net.sourceforge.kolmafia.textui.Interpreter.execute(Interpreter.java:341)
	at net.sourceforge.kolmafia.textui.Interpreter.execute(Interpreter.java:334)
	at net.sourceforge.kolmafia.KoLmafiaASH.getClientHTML(KoLmafiaASH.java:215)
	at net.sourceforge.kolmafia.KoLmafiaASH.getClientHTML(KoLmafiaASH.java:184)
	at net.sourceforge.kolmafia.request.RelayRequest.run(RelayRequest.java:3154)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:286)
	at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:249)
	at net.sourceforge.kolmafia.webui.RelayAgent.readServerResponse(RelayAgent.java:576)
	at net.sourceforge.kolmafia.webui.RelayAgent.performRelay(RelayAgent.java:164)
	at net.sourceforge.kolmafia.webui.RelayAgent.run(RelayAgent.java:137)
 

Darzil

Developer
r18898 - Not sure what happened, but it couldn't find the monster in the database, so couldn't check if it was no banish. Shouldn't throw an error if that happens now, though.
 

Ryo_Sangnoir

Developer
Staff member
Works and populates banishedMonsters:

a.m.c. gremlin banished by ice house.

banishedMonstersa.m.c. gremlin:ice house:3177
 

lostcalpolydude

Developer
Staff member
This looks like it's caused by a monster name case mismatch, but there also shouldn't be a reason to lowercase the monster's name in the first place.
 
Top