Page 2 of 2 FirstFirst 1 2
Results 11 to 16 of 16

Thread: 18835: Add images for God Lobster and Wall of Meat. Monster names are case sensitive.

  1. #11
    Developer
    Join Date
    Apr 2010
    Posts
    4,757

    Default

    No, but used same code as the decoration code that is broken. The monsterfind used to match with lower case, now needs to be case sensitive, so everywhere that uses it needs to change. The lower case lookup fails.

  2. #12
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,389

    Default

    Of course. But CCS doesn't look up monsters. It looks up CCS sections that match monsters.

  3. #13
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,389

    Default

    The issue with the decorator is that it was looking at MonsterStatusTracker.monsterData, which was being looked up with a lower-cased monster name, rather than the real monster name.

    I looked for all places where an "encounterKey" was being looked up and made them use the "keep original case" version - except for the CCS handler, which continues to use the lowercased version. That was two places, I believe.

    Doing fuzzy matching on monster names and enabling "friendly warnings" in ASH is something different.

  4. #14
    Developer
    Join Date
    Apr 2010
    Posts
    4,757

    Default

    I'm sure it can be improved, but r18839 tries to match on non case sensitive if case sensitive fails, and shows a warning.

  5. #15

    Default

    Do any changes since 18837 fix post-combat preference tracking? My scripts use the proper case for everything, but settings like "_snojoFreeFights" and "ghostLocation" weren't getting updated after combat yesterday, sending them into infinite loops.

  6. #16
    Developer
    Join Date
    Apr 2010
    Posts
    4,757

    Default

    18838 should fix that I think. It did for me.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •