Bug - Fixed Pocket wish fights don't show adventures used in session logs

icon315

Member
Like the title says, pocket wishes display in the logs like so
Code:
use 1 pocket wish
Took choice 1267/1: (secret choice)
choice.php?pwd&option=1&whichchoice=1267&wish=I+was+fighting+a+writing+desk
Encounter: writing desk
...

While other copiers like the photocopied monsters are logged like this
Code:
fax receive
You acquire an item: photocopied monster

use 1 photocopied monster

[7] photocopied monster
Encounter: writing desk
...

When trying to parse these logs using the ascension log visualizer, though I can go through the logs and manually add the adventure count, so it isn't too big of a deal it'd be nice have it fixed.
 

Veracity

Developer
Staff member
Well.... not every pocket wish uses an adventure. Only monster fights. Similar issue with the Deck of Every Card or the gift card.

Looking at my session log:

Code:
use 1 genie bottle

[209] genie bottle

main.php?checkbfast=84
Took choice 1267/1: unknown
choice.php?pwd&option=1&whichchoice=1267&wish=I+was+fighting+a+ghost
Encounter: ghost

as well as:

Code:
use 1 genie bottle

[231] genie bottle

main.php?checkbfast=84
Took choice 1267/1: unknown
choice.php?pwd&option=1&whichchoice=1267&wish=to+be+Ode+to+Booze
You acquire an effect: Ode to Booze (20)
which is not the same problem as the pocket wish, since that doesn't log a turn at all.

Seems like both could be improved to log, say, "[1234] genie summoned monster" until after we know it's a fight. Which should be wasy enugh, since you have a "Fight" link that you will follow to enter the fight...
 

Veracity

Developer
Staff member
OK. One of my multis bought two pocket wishes. With a code change, he got this:

Code:
use 1 pocket wish
Took choice 1267/1: (secret choice)
choice.php?pwd&option=1&whichchoice=1267&wish=I+was+fighting+a+Witchess+Knight

[623828] genie summoned monster
Encounter: Witchess Knight
...

use 1 pocket wish
Took choice 1267/1: (secret choice)
choice.php?pwd&option=1&whichchoice=1267&wish=for+a+blessed+rustproof+%2B2+gray+dragon+scale+mail
You acquire an item: blessed rustproof +2 gray dragon scale mail
Since it's the same choice adventure, I expect using a genie bottle will log the same way.

Revision 18715
 

Darzil

Developer
I think there is still an issue here. The turns are considered spent in the previous zone because the adventure isn't set to null prior to hitting fight.php in genericRequest.php.

This makes counting delay etc inaccurate.
 
Top