Results 1 to 7 of 7

Thread: 18426: Missing status effects. Only check mall prices on tradeable items, and Speakea

  1. #1
    Feed Reader RSS Bot's Avatar
    Join Date
    Jul 2009
    Posts
    11,263

    RSS 18426: Missing status effects. Only check mall prices on tradeable items, and Speakea

    Missing status effects. Only check mall prices on tradeable items, and Speakeasy drinks are not tradeable!

    by darzil on 2018-01-21 13:22:27

    M /src/data/items.txt (view) (diff)
    M /src/data/modifiers.txt (view) (diff)
    M /src/data/statuseffects.txt (view) (diff)
    M /src/net/sourceforge/kolmafia/maximizer/Maximizer.java (view) (diff)
    Download the latest KolMafia build here.
    Every new revision posted within the hour.
    New EXE builds every Monday.

  2. #2

    Default

    Speakeasy drinks are not tradeable
    According to KoL they are, it's just that no one can ever get one to trade in the first place. So this change is actually going to result in checkitems claiming something needs to be fixed.

  3. #3
    Developer
    Join Date
    Apr 2010
    Posts
    4,561

    Default

    Hmm, they don't say they are on the item description, and I guess I must not know how to run checkitems:
    Code:
    > checkitems
    
    Loading previous data...
    Checking internal data...
    Checking level requirements...
    Checking Food...
    Checking Booze...
    Checking Spleen Toxins...
    Checking equipment...
    Checking Hats...
    Checking Pants...
    Checking Shirts...
    Checking Weapons...
    Checking Off-hand Items...
    Checking Accessories...
    Checking Containers...
    Checking modifiers...
    Checking Hats...
    Checking Pants...
    Checking Shirts...
    Checking Weapons...
    Checking Off-hand Items...
    Checking Accessories...
    Checking Containers...
    Checking Familiar Items...
    Checking Food...
    Checking Booze...
    Checking Spleen Toxins...
    Checking Everything Else...
    Internal item data checked.

  4. #4

    Default

    Items don't say that they can be traded, only that they cannot be traded. "test newitem 556467503" (Ish Kabibble) shows t,d.

    I'm surprised that checkitems doesn't report a discrepancy.

    I guess this change is fine then...

  5. #5
    Developer
    Join Date
    Apr 2010
    Posts
    4,561

    Default

    I did have an earlier build where I checked if items were Speakeasy ones as well as if they were tradeable, can always go back to that . . .

  6. #6
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,341

    Default

    You have to look at the output file that checkitems generates.

    I deleted itemhtml.txt (the saved item descriptions) and itemdata.txt (the generated analysis file) and ran checkitems. I got the same output in the gCLI that you showed. However, looking at itemdata.txt:

    Code:
    # *** glass of "milk" (7589) has access of  but should be t,d.
    7589	glass of "milk"	261919502	milk.gif	drink		250
    # *** cup of "tea" (7590) has access of  but should be t,d.
    7590	cup of "tea"	608728555	coffeecup.gif	drink		250
    # *** thermos of "whiskey" (7591) has access of  but should be t,d.
    7591	thermos of "whiskey"	712543371	thermos.gif	drink		250
    # *** Lucky Lindy (7592) has access of  but should be t,d.
    7592	Lucky Lindy	370494914	fruity.gif	drink		500
    # *** Bee's Knees (7593) has access of  but should be t,d.
    7593	Bee's Knees	323267882	martini.gif	drink		500	glasses of the Bee's Knees
    # *** Sockdollager (7594) has access of  but should be t,d.
    7594	Sockdollager	820266043	rocks.gif	drink		500
    # *** Ish Kabibble (7595) has access of  but should be t,d.
    7595	Ish Kabibble	556467503	chamfluteu.gif	drink		500
    # *** Hot Socks (7596) has access of  but should be t,d.
    7596	Hot Socks	727300012	rocks_f.gif	drink		5000
    # *** Phonus Balonus (7597) has access of  but should be t,d.
    7597	Phonus Balonus	846180998	hurricane.gif	drink		10000	Phonus Balonii
    # *** Flivver (7598) has access of  but should be t,d.
    7598	Flivver	761660391	celloshot.gif	drink		20000
    # *** Sloppy Jalopy (7599) has access of  but should be t,d.
    7599	Sloppy Jalopy	483402014	fruitym.gif	drink		100000
    In general, I'd prefer if our item data matches what the item descriptions actually tells us. Sure, there are things like "reusable" or "multiple" which we cannot deduce from the description, but unless it says "cannot be traded", we should have "t" and unless it says "cannot be discarded", we should have "d".

    I'd prefer that you go back to your earlier implementation which doesn't cause discrepancies to show up in checkitems, please.

    Thanks.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  7. #7
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,341

    Default

    Looking at itemdata.txt, I see some now annotations:

    Code:
    # Great Wolf's lice: Weakens enemies a lot
    # Great Wolf's lice: (by 30% if they are beasts)
    # Great Wolf's lice: (doesn't go away when used)
    The "doesn't go away when used" tells us it is "combat reusable". However:

    Code:
    # dictionary: Most Enemies Don't Care About It
    # facsimile dictionary: Most Enemies Don't Care About It
    # facsimile dictionary: (doesn't go away when used)
    They didn't add that annotation to all such items.

    Even so, we should presumably mark new items as reusable or combat reusable, as appropriate, if we see it.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •