Page 1 of 2 1 2 LastLast
Results 1 to 10 of 16

Thread: Reflect lowest Mall Price in item manager

  1. #1
    Senior Member VladYvhuce's Avatar
    Join Date
    Feb 2016
    Location
    Kansas
    Posts
    215

    Default Reflect lowest Mall Price in item manager

    I've discussed this before with Bale's OCD inventory control script. The problem with the way Mafia displays the prices is that they are sometimes WAY off from the actual lowest mall prices. This often gives me a false sense of "I could make money if I sell this thing I bought a long time ago", only to find out it's not worth selling the item in the mall after refreshing the prices in the store manager, because Mafia was quoting me an arcaic price from someone who never lowered their price. It gets rather irritating when I'm doing inventory cleaning. It happened just today when I looked at the price of my Jekyllin hide belt. Mafia said I could sell for 999,999,998. The actual mall prices before that are 280,000,000 in two different shops, and 300,000,000 in another. I think this is fair proof that the current price checking system is flawed.
    In KOL: VladYvhuce (#1798867)

  2. #2
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,095

    Default

    One word: mallbots

    A script is allowed to know what the 5th lowest price for an item is. Not the current lowest price.
    The user, of course, can manually do a mall search and discover all of the prices.
    I wasn't aware that we displayed mall prices in the Item Manager - as opposed to the Purchases frame, but if we are, I am sure it is showing the same 5th-lowest price, so as not to have to do a mall search for every item.

    In any case, the lowest price is often NOT what you want to offer your items for; just because one shop is offering an item for 100 Meat, limited to 1/day, if the 2nd - xth price is 1,000 Meat, do you, too, want to mall sell your item for 100 Meat?
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  3. #3
    Senior Member ckb's Avatar
    Join Date
    Mar 2006
    Posts
    741

    Default

    To add to this, see the descriptions for
    int historical_price( item )
    int mall_price( item )

    I would guess that the value in the Item Manager is the historical_price(), to avoid server hits for every item in your inventory.

  4. #4
    Developer
    Join Date
    Apr 2010
    Posts
    4,051

    Default

    Whether we should ignore limited items when determining 5th lowest price, maybe we could even put in some complex processing so that we can show a less than 5th price if the fifth price is much higher than an unlimited lowest price.

    Or of course stick to current system !

  5. #5
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,095

    Default

    Well, when I said "5th price", I meant "the price you would pay for the 5th item you buy". If the lowest price has 5 available, that is the price that will be shown; we will not go look for 4 higher prices.

    Items with limits count as providing the limit's worth of the item. So a 1/day milk of magnesium at 100 Meat will count for 1, and the more realistic price is what the next 4 are offered at at a single unlimited store.

    This breaks down primarily (only?) when there are only a handful of an item in the mall, as in the Jekyllin belt referenced by the OP.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  6. #6

    Default

    Maybe the first price over max(50m, 2*Mr. A historical price) could be used, if that is reached before the 5th price? Only things that are fairly rare would be affected, and I don't think there are too many items to misprice at 60m instead of 600m.

  7. #7

    Default

    I've now written the (small amount of) code for that change, so it's mostly just a question of whether it would be a good change.

  8. #8
    Senior Member
    Join Date
    Jun 2016
    Posts
    101

    Default

    I think 3x or 4x Mr. A price might be a bit more reasonable. Sure, there aren't a lot of items that will end up at 60M from 600M, but there are a decent number of items in the <120M range, and those are usually reported fairly accurately since they aren't at the same really low supply.

  9. #9
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    D.C. suburbs of Virginia, USA
    Posts
    3,752

    Default

    I don't think any changes are necessary/appropriate. As a development philosophy we have decided to use the "fifth price" in many circumstances in order to raise the skill level required to use KoLmafia as a mallbot. If that is no longer the development philosophy then we should change "fifth price" to "lowest price".

    Jick once claimed in frustration that "the Mall is not the game". If the dev team agrees with him, there is really no use case for addressing an edge case where the behavior is considered flawed by some.

    IMO. YMMV.
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post
    There are 69 players more powerful than you.
    Originally Posted by Statistics Leaderboards

  10. #10

    Default

    I'm doubtful that mallbots would actually be used for buying anything listed in the mall over 100m. I think everyone would agree that making it harder to automatically buy a Mr. A listed at 3m instead of 30m is a good thing.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •