17981: Allow comments starting with // inside (non-string) plural typed constants

[RSS Bot]

Allow comments starting with // inside (non-string) plural typed constants

by veracity0 on 2017-04-11 13:22:41

M /src/net/sourceforge/kolmafia/textui/Parser.java (view) (diff)

[Bale]

Huh. Wow!

This is a surprising and pleasing improvement. Many times I have had to put comments at the top to refer to things inside of the list, when I really wanted to put comments inside the list to explain certain items.

Much appreciated.

[Veracity]

Yeah. I wanted this:

static boolean [int] vgc_generic_turtle_choices = $ints[
    327,	// Puttin' it on Wax
    328,	// Never Break the Chain
    329,	// Don't Be Alarmed, Now
    941,	// This Turtle Rocks!
    942,	// Even Tamer Than Usual
    943,	// Really Sticking Her Neck Out
    944,	// More Like... Hurtle
    945,	// Musk! Musk! Musk!
    946,	// Armchair Quarterback
    957,	// It Came from Beneath the Sewer? Great!
    958,	// Close, but Yes Cigar
];

But it didn't work, so I fixed it.

[Bale]

I knew exactly how you would use it as soon as I saw the revision. I'm not going to be using it as liberally as yourself, but I've wanted it many times.

[ckb]

Oh, double plus good. I have been wishing this worked like this for a while, and I am extra happy it does,

(And in hindsight, I wonder why I did not ask for a feature request, but sometimes my mind does not work that way).

[Bale]

I wonder why I did not ask for a feature request

I can only suggest the same reason I didn't ask. It seemed like too small a matter over which to bother Veracity. Can't comment as I'd like? It almost sounds silly to need a workaround for commenting.