Bug - Fixed zonefont - Random Capitalization for "an eldritch tentacle"

yakatz

yakatz

New member
In the seaside town for the name of the tentacle zone, the images loaded for /images/otherimages/zonefont/letter.gif appear to have random capitalization for different users, but logging in to KOL directly shows normal lettering.

For example, I see "an eldrITCh TenTaCle"
kol_caps.PNG

A number of my clan-mates have seen this issue too.
I am using build 17645. Another clan member with the same issue has 17728 and sees "an elDRitCh tentaCle".
 
lostcalpolydude

lostcalpolydude

Developer
Staff member
1) KoL uses images for the letters.
2) KoLmafia caches those images.
3) On Windows, file names are case-insensitive.
4) E.gif and e.gif (and other similar cases) appear to be the same file to KoLmafia when running on Windows, so whichever case you see first for a letter is the case that you will see every time in the future.
 
Last edited:
yakatz

yakatz

New member
That makes sense, but why have none of us seen this before in any other zone?

I searched the forum for zonefont and didn't find anyone with a similar issue.
 
Veracity

Veracity

Developer
Staff member
Perhaps we could not cache /images/otherimages/zonefont/* for systems with case insensitive filesystems.
Which would be only Windows, although I'd prefer to not hardcode the OS.
Google is not showing me a standard java method to detect that.

Perhaps simply don't cache that directory, period.

Code: 
[color=green]> debug on[/color]

[color=green]ashq visit_url( "http://images.kingdomofloathing.com/otherimages/zonefont/a.gif" )[/color]

[color=green]> debug off[/color]
got me a DEBUG log.

Code: 
Requesting: http://images.kingdomofloathing.com/otherimages/zonefont/a.gif
1 request properties
Field: User-Agent = [Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0]

Retrieving server reply...

Retrieved: http://images.kingdomofloathing.com/otherimages/zonefont/a.gif
12 header fields
Field: Accept-Ranges = [bytes]
Field: null = [HTTP/1.1 200 OK]
Field: x-amz-meta-s3cmd-attrs = [uid:1003/gname:asym_images/uname:jick/gid:1000/mode:33204/mtime:1358445627/atime:1458776303/md5:43a2e1926d28940a2291e9d2a4e29533/ctime:1381342807]
Field: Server = [AmazonS3]
Field: Cache-Control = [public,max-age=31536000]
Field: ETag = ["43a2e1926d28940a2291e9d2a4e29533"]
Field: Last-Modified = [Mon, 28 Mar 2016 20:44:31 GMT]
Field: x-amz-request-id = [356CD0062773F560]
Field: Content-Length = [832]
Field: x-amz-id-2 = [8SxpKJOoL0EvizthUOwTQoBrz3axgKNtWQ3xlYLhLJ4MZZ5lIQCbibW15q0orD41OYPZGSU6XmE=]
Field: Date = [Wed, 25 Jan 2017 15:14:38 GMT]
Field: Content-Type = [image/gif]

Retrieving server reply
ResponseText has 829 characters.
I was hoping the request itself might say "don't cache this", which we were ignoring, but, no.
 
Veracity

Veracity

Developer
Staff member
We do have the technology to not caches specific directories.

RelayAgent.java:

Code: 
	private final static String NOCACHE_IMAGES = "(/memes)?";
		
	private final static Pattern IMAGE_PATTERN = Pattern.compile( "(" + KoLmafia.AMAZON_IMAGE_SERVER +
								      "|" + KoLmafia.KOL_IMAGE_SERVER +
								      "|" + "//images.kingdomofloathing.com" +
								      "|" + "http://pics.communityofloathing.com/albums" +
								      ")" + RelayAgent.NOCACHE_IMAGES );
Seems like this should do it:

Code: 
	private final static String NOCACHE_IMAGES = "(/memes|/otherimages/zonefont)?";
 
billybobfred

billybobfred

Member
Huh.

I assumed this was a feature of the tentacles being ~weird eldritch shit~, not a bug in Mafia. Shows what I know :v
 
Veracity

Veracity

Developer
Staff member
Is it a "bug"? Well, to my mind, as a long time Unix user, case-insensitive filesystems are a "bug".
 
Veracity

Veracity

Developer
Staff member
I't been over a week since I asked for feedback on whether my fix worked for you.
No response. Therefore, I'm marking this fixed.
 
yakatz

yakatz

New member
I didn't get any notification of the previous posts in this thread. I will test that build tonight.
 
You must log in or register to reply here.
Top