Page 3 of 5 FirstFirst 1 2 3 4 5 LastLast
Results 21 to 30 of 49

Thread: Revamping the KoLmafia Toolbar

  1. #21
    Senior Member AlbinoRhino's Avatar
    Join Date
    May 2008
    Posts
    618

    Default

    Huh. I never used that trick that often but I don't remember it ever failing me. I did just think that I often have the dev console open for javascripting ... the links can probably be found in there too. It never occurred to me though because I usually have the network messages filtered out.

  2. #22
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    10,812

    Default

    If anyone else does look at this, pay attention to the button icons. Before I gave up on making KoLmafia behave better in a high DPI display environment, one of the unsolved issues was that the icons seemed to be of a fixed size and nothing I could figure out made them scale.
    Originally Posted by fronobulax View Post
    The button icons all come from KoL item descriptions. They are small.

    DisplayFrameButton.java:

    Code:
    	public DisplayFrameButton( final String tooltip, final String icon, final String frameClass )
    	{
    		super( JComponentUtilities.getImage( icon ), new DisplayFrameListener( frameClass ) );
    		JComponentUtilities.setComponentSize( this, 32, 32 );
    		this.setToolTipText( tooltip );
    	}
    And yes, the class that holds them does make the icons a fixed 32 by 32.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  3. #23
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    D.C. suburbs of Virginia, USA
    Posts
    3,665

    Default

    I have used the Mini-browser when I needed URLs. It has been a while since I needed them and there is an alternative. The one case I am not sure about is when the mini-browser is opened with the expectation that it would display the "current" page. I seem to recall doing that to debug some relay browser problems. My recollection is that I could open it after the fact to get the info (URL) I was most interested in, in contrast to having to enable some logging before doing the action of interest.

    Some 'unpublished' automation from zarqon does not know how to handle using the Insults and so it dumps the user into the relay browser to respond manually.

    The former might be a reason not to deprecate the mini-browser but the latter would just require a script to be updated.

    The other case for keeping it would be if a user had set up their system in such a way that the web browser was not available to KoLmafia. That seems unlikely in 2017 and we could try and detect it and generate an informative message so it is not a strong case. We managed to move on from Java 1.5. Perhaps it is time to move on from the possibility that a user doesn't have a web browser available to KoLmafia?
    You just vehemently agreed with me
    Originally Posted by Veracity View Post
    I agree with frono.
    Originally Posted by Veracity View Post
    There are 69 players more powerful than you.
    Originally Posted by Statistics Leaderboards

  4. #24
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,631

    Default

    I've used the mini browser successfully to get choice automation urls in the past few months - whenever I last needed to add something to BCA. If removing it from the Toolbar and General menu makes mafia better, great. I'll deal. If we're just removing it because it's not a pleasant experience to play KoL in, then I'd suggest leaving it in the General menu, even if the toolbar icon disappears.

  5. #25
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    10,812

    Default

    It's not currently in the toolbar, near as I can tell.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  6. #26
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,152

    Default

    No toolbar icon for mini-browser.



    Seems time to repost that image. Since I labeled everything so nicely it seems worthwhile.

  7. #27

    Default

    "Mini-Browser" -> "RequestFrame"

    Is this still useful? KoL itself is so dependent on Javascript that this is a very deficient version of the Browser experience
    I had some stuff typed up, then read more of the thread. Interestingly, there is a GUI option for a debug log (Help -> Start/Stop Debug Log), but nothing for trace, so I went a long time without realizing that was an option.

    "Relay Server" -> "LocalRelayServer"

    This is not really a "Frame". It is a directive to start the Relay Browser on startup. Does it work?
    It works very well. It doesn't actually start the relay browser, but it does start the relay server so that my browser can open the relay. Without this I need to use the button on the toolbar first. For me it removes some awkwardness from the process.
    That is the only thing that is in initialFrames by default (and that's how I use it), so that a new user can start to use KoLmafia without being completely overwhelmed by its GUI. The default value does actually open a browser page, but (as Bale has done) you can change that by setting it to open as a "tab" instead of as a "window".

  8. #28
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,152

    Default

    Oh! Right. It has been so long that I didn't remember that. Yeah. It's coming back to me now that there was another way to use it. Thanks lost.

  9. #29
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,631

    Default

    No toolbar icon for mini-browser.
    Originally Posted by Bale View Post
    It's true. But as the title of this thread is about revamping the toolbar, and we've wandered on to non-toolbar components of mafia to be removed, it seemed only polite to pretend that we were still fully in context.

    That to say, I like and use the mini-browser. It still serves a purpose for me. If it's removed, I'll deal with my sense of loss by looking at source more awkwardly instead. Why can't modern browsers make it as easy to read source as IE3 did?

  10. #30

    Default

    Why can't modern browsers make it as easy to read source as IE3 did?
    Originally Posted by Theraze View Post
    I would assume it's the source code becoming harder to read, not browsers getting worse at reading it. But I didn't start using computers until IE6.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •