Bug - Fixed Mana burning cannot stand Disco Inferno's heat

Ezandora

Member
r17201
With the effect Disco Inferno active, mana burning aborts: (from hookah or golden dice)

Code:
> burn 15

You don't have a skill uniquely matching "1 Disco Inferno"

> ash $skill[Disco Inferno].have_skill()

Returned: true

> ash $skill[disco inferno].combat

Returned: true

The disco inferno skill is still assumed to give the disco inferno effect, though that's no longer true:

Code:
> ash ($skill[disco inferno].to_effect() == $effect[disco inferno])

Returned: true

Mana burning could also check if the skill is a combat skill before trying to cast it.
 

lostcalpolydude

Developer
Staff member
This appears to be a more general bug for any case where a skill and an effect have the same name.
Code:
> ash ($skill[hot breath].to_effect() == $effect[hot breath])

Returned: true
 

Darzil

Developer
Staring at the code not understanding it at the moment.

I think what is happening is that we used to have a bunch of manual overrides, and otherwise return the name of the skill/effect. However, it looks like we now, more sensibly, build an array from statuseffects, but then for some reason also return the name of the skill/effect. I think we should for effectToSkill and skillToEffect return null or "". Will look into the effects of that.
 
Top