Bug - Not A Bug Item Manager just won't show up

testalx

New member
Hello!
I have been experiencing the problem mentioned in the thread's title for two days now, on the most recent jar builds (The latest I've found it is r16908).
So, when mafia loads its ui, I have set the Item Manager to load in a separate tab, but it doesn't. Trying to enable it afterwards via graphical button or command from the menu, it loads a frame named "Item Manager", but I can't focus it (clicking it doesn't switch from the current tab).
Meanwhile, in the cli I get the message "net.sourceforge.kolmafia.swingui.ItemManageFrame could not be loaded" everytime I try this.
I've changed the option to open the Manager in a separate window, but the outcome is still the same.

I searched for a similar problem, and I've got some 2009, 2011 or 2013 threads that weren't useful . So...please would someone look into it?

I'm attaching the debug log for today, maybe it'll be of use. There are several tries at different timestamps. If necessary, I'll include the ones from the days before.

Thanks in advance,
Alex
 

Attachments

  • DEBUG_20160426.txt
    90.6 KB · Views: 73

Theraze

Active member
Somewhat odd.
Caused by: java.lang.ClassFormatError: Unknown constant tag 73 in class file org/tmatesoft/svn/core/internal/wc17/db/SVNWCDb
73 doesn't show up in the lib/org/tmatesoft/svn/core/internal/wc17/db/SVNWCDb.java file. Might be related to bad SVN script being installed though, based on the library?
 

testalx

New member
Update:
Tried opening other windows, Script Manager has the same odd behaviour.

Debug log included.

The only svn script I have installed is ezandora's guide, but I only use it from the relay browser.

Is there anything I should try?

Thanks again!
 

Attachments

  • DEBUG_20160427.txt
    15.7 KB · Views: 203

xKiv

Active member
Since the same jar works for other people (I assume - I build my own), ClassFormatError can suggest that you have incompatible java. What's your java's version?
... the debyg log says "Java 1.7.0_25" which ... should work, I think.

Or, since valid constant tags seem to be only from 1 to 18, something's damaged - likely candidate is that the file didn't download correctly to your computer.

Unfortunately, http://ci.kolmafia.us/job/Kolmafia/ doesn't list exact file size, so you generally can't check that.
...
I just downloaded KoLmafia-16908.jar; it has 12758290 bytes and seems to work correctly. What's your file size?

(if the invalid tag is 73 in one log and 97 in another ... that reminds me of the time I had to replace my RAM ...)
 
Last edited:

adeyke

Member
I'm having the same problem. Yesterday, the problem happened with 16908, so I tried 16907 and that worked. It must have been a fluke, though, since today, 16907 had the same problem. I ended up renaming my svn folder to stop it interacting with that, just as a workaround to at least run my day's adventures.

I'm using Java 1.8.0_92, in case that's relevant.
 

testalx

New member
Just checked the filesize and it's exactly the same.

I didn't mention it, but I can do anything and everything else I normally do, except interact with the item manager.

I've just tried updating java to most recent version and it didn't solve the issue. Nor did reverting to 16907.

Hope it isn't a RAM issue. Everything else works without any problems. This laptop has DDR2 from some years ago. I'll try moving the whole mafia folder to another machine to see if the problem persists. But that'll be in several days.

As usual, any / all suggestions are greatly appreciated.

EDIT: just tried r16902, and it's back to normal . But with the new builds...:confused:
 
Last edited:

testalx

New member
Aaaaaand....done!
The new folder solved everything.
Running the .jar file created, as usual, its folders, then I manually copied each of the previous subfolder's contents into the new ones, checking each time if it screws something up.
I guess it may have been a case of running it for too much time from the same location on disk; each playing session read/rewrote that same disk area and it eventually gave up. Maybe.

Anyway, thanks a million!
Case closed.
 

Theraze

Active member
Well, the interesting check would have been seeing if uninstalling Guide (and fully closing mafia before restarting it) fixed the problem. Since adeyke reported the same problem and apparently renaming the SVN folder fixed it.
 

adeyke

Member
I was going to try to work on isolating the problem. However, these past two days, I didn't encounter the issue, despite having the svn folder intact. That's good for me but it doesn't help me know what the exact issue was. I guess I'll be able to look into it more if the problem reoccurs, and until then, it doesn't matter.
 

xKiv

Active member
despite having the svn folder intact.

That was never the problem. The problem was that java was unable to correctly process a certain class file included in mafia's .jar file. And nobody knows why.
(looks like it's the main class for working with v1.7 repositories? so trying any svn operation (automatic update?) would need the class)
(I have no idea why this would trigger only when loading item manager)
 

adeyke

Member
Today, I noticed that a script wasn't being update, then realized I still had my svn folder renamed (I guess at some point since my last post in this thread, the problem had reoccurred and I'd gone back to the workaround). I hadn't noticed earlier since I'd spent the past months just doing repetitive aftercore farming. So I put the folder back in place and restarted Mafia and now I'm getting the same issue again. The item manager and script manager won't load, svn update doesn't work, and my debug log is getting the "java.lang.ClassFormatError: org/tmatesoft/svn/core/internal/wc2/ng/SvnNgAdd" again.

What can I do to help diagnose this problem?
 

heeheehee

Developer
Staff member
Can you post a debug log? These errors look like they're a result of either a bad build or bad download, so I'm not sure that much can be done about it.
 

adeyke

Member
Okay, here's the debug log. First (with the svn folder in place), I opened Mafia with an item manager tab, then I opened the script manager, then I opened the relay browser, causing an error on line 3580 of Bale's ChIT relay script, when it tries to call svn_at_head("mafiachit"). Each of those three actions caused an error to be logged.

View attachment DEBUG_20160702.txt

I do have the problem where downloading a new build always fails the first attempt, but I'm then able to retry and complete the download each time. I suppose it could be possible that end result is then corrupted somehow, though it seems really strange that only the SVN functionality would be damaged each time. I suppose that's worth checking, all the same. My KoLmafia-17039.jar is 12786609 bytes in length and has an MD5 checksum of 367f82f506ae9dbbd3186cd891d0ff17 . Is this correct?
 

xKiv

Active member
Yes, this sounds like all the other cases of the same problem where it seemed like the problem was a bad (terminated too early?) download of mafia's build.

though it seems really strange that only the SVN functionality would be damaged each time.
Presumably, it's roughly the same problem because roughly the same part of the jar (the end) is missing/corrupted.

My KoLmafia-17039.jar is 12786609 bytes in length and has an MD5 checksum of 367f82f506ae9dbbd3186cd891d0ff17 . Is this correct?

I just downloaded one that's 12786609 bytes and md5sum says 146dc5f441bf8f1237dfa1cc8db3a4a1.
Also, spot check of the end of the file:
Code:
$ od -x KoLmafia-17039.jar | tail
60615460 a081 b99b 6300 6d6f 742f 6972 656c 6461
60615500 732f 6873 2f32 7475 6c69 542f 6b6f 6e65
60615520 7a69 7265 632e 616c 7373 4b50 0201 0314
60615540 000a 0800 0008 6f11 48e1 259d 4c93 0504
60615560 0000 18f9 0000 0013 0000 0000 0000 0000
60615600 0000 81a4 9e39 00b9 454d 4154 492d 464e
60615620 492f 444e 5845 4c2e 5349 5054 054b 0006
60615640 0000 0800 0817 2d17 0978 6e00 b9a3 0000
60615660 0000
60615661


ETA: can we have MD5 of the jar added to jenkins somewhere, or at least to ant build output (which is already accessible in jenkins, for example http://ci.kolmafia.us/job/Kolmafia/lastSuccessfulBuild/console )
 
Last edited:

adeyke

Member
Here's what I got from that command:
Code:
60615460 a081 b99b 6300 6d6f 742f 6972 656c 6461
60615500 732f 6873 2f32 7475 6c69 542f 6b6f 6e65
60615520 7a69 7265 632e 616c 7373 4b50 0201 0314
60615540 000a 0800 0008 6f11 48e1 259d 4c93 0504
60615560 0000 18f9 0000 0013 0000 0000 0000 0000
60615600 0000 81a4 9e39 00b9 454d 4154 492d 464e
60615620 492f 444e 5845 4c2e 5349 5054 054b 0006
60615640 0000 0800 0817 2d17 0978 6e00 b9a3 0000
60615660 0000
60615661

So that part is the same. But the differing checksums does confirm that corruption is the problem. In fact, when I downloaded that same build again just now, I got a different checksum than I did before (I should have tried that earlier). The download doesn't fail at the exact same spot each time, but it's apparently always somewhere within the SVN stuff.

I suppose that just leaves the question of what can be done about it. I'd been downloading the build from http://builds.kolmafia.us/job/Kolmafia/lastSuccessfulBuild/artifact/dist/ . Is there anything that can be done, on either end, to solve or work around the download issue?
 

xKiv

Active member
Are you downloading using a ("vanilla") browser, some download-helping addon (DownTheMall, flashget, flashgot), or a commandline tool (wget -c, curl -L -O -C)?
 

adeyke

Member
I'm using Firefox, without any downloading-relevant add-ons. I'd previously one of the daily build downloaders, but that had the same problem with the terminated download.

I tried wget -c just now and got this:
Code:
--2016-07-02 19:10:47--  http://builds.kolmafia.us/job/Kolmafia/lastSuccessfulBuild/artifact/dist/KoLmafia-17039.jar
Resolving builds.kolmafia.us... 170.75.152.154
Connecting to builds.kolmafia.us|170.75.152.154|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 12786609 (12M) [application/java-archive]
Saving to: `KoLmafia-17039.jar'

70% [==========================>            ] 9,026,806   68.2K/s   in 79s

2016-07-02 19:12:08 (111 KB/s) - Connection closed at byte 9026806. Retrying.

--2016-07-02 19:12:08--  (try: 2)  http://builds.kolmafia.us/job/Kolmafia/lastSuccessfulBuild/artifact/dist/KoLmafia-17039.jar
Connecting to builds.kolmafia.us|170.75.152.154|:80... connected.
HTTP request sent, awaiting response... 206 Partial Content
Length: 12786609 (12M), 3759803 (3.6M) remaining [application/java-archive]
Saving to: `KoLmafia-17039.jar'

100%[+++++++++++++++++++++++++++===========>] 12,786,609  99.0K/s   in 30s

2016-07-02 19:12:38 (122 KB/s) - `KoLmafia-17039.jar' saved [12786609/12786609]

The MD5 that time is 1ffa3d09bdbca28851c181f39cc9a40b, so also corrupted.

I'm running Windows 10 and just have the stock Windows Defender as antivirus.
 
Top