Bug - Fixed Easyfax not updating

D

Darzil

Developer

• Apr 14, 2016

• #1

Will drop Crowther a line, but not sure if we should treat this as a Mafia code or datafile bug.

We get Easyfax updates from http://sourceforge.net/p/easyfax/code/HEAD/tree/Easyfax.xml?format=raw but are getting code 302 from it, which FileUtilities.downloadFile() doesn't handle.

I guess maybe we just get the URL it's redirecting to, and put that in the faxbot.txt file instead, but maybe we need to get downloadFile() to follow redirects ?

My last update was 18th Jan 2016.

 

Crowther

Active member

• Apr 14, 2016

• #2

I messaged Darzil in game, then saw this here. I believe this is because Sourceforge is now redirecting http to https.

 

Theraze

Active member

• Apr 15, 2016

• #3

So is this as simple as changing the http download to https?

 

H

heeheehee

Developer

Staff member

• Apr 15, 2016

• #4

Theraze said:

So is this as simple as changing the http download to https?

Click to expand...

That would be the short-term fix. I can't see a good reason for FileUtilities.downloadFile not to follow redirects, though.

 

D

Darzil

Developer

• Apr 15, 2016

• #5

It is that simple, thanks Crowther. r16893

 

D

Darzil

Developer

• Apr 15, 2016

• #6

heeheehee said:

That would be the short-term fix. I can't see a good reason for FileUtilities.downloadFile not to follow redirects, though.

Click to expand...

I could see a security argument that we shouldn't follow redirects other than within KoL itself. Whilst redirects will usually be like this, server hacks that redirect have been known.

 

Crowther

Active member

• Apr 15, 2016

• #7

Darzil said:

It is that simple, thanks Crowther. r16893

Click to expand...

That's for pointing out the problem. I wouldn't have noticed it myself and I know people are checking the list looking for that snake or something.