Version 13.2
The following is an abbreviated version of the Subversion commit message logs. Please keep in mind that these messages are intended for other developers and they take the files which were modified into context in order to limit the amount of verbage. In general, they are not intended for general audiences and should not be treated as "official" documentation -- they are informal and abbreviated, at best.
If you do not understand what something says, try looking at the full version of the revision by following the accompanying link for the revision. The only difference is that the files which were modified will be listed, and sometimes, you can guess what happened from file names (though not always). If you still have no idea what happened, that's okay -- it probably doesn't relate to what you're doing with KoLmafia. ^_~
Furthermore, not everything marked as "fixed" is guaranteed to be fixed, not all changes are guaranteed to have a change. This is due the fact that both time and turns are finite and only a limited number of things can be tested. Some changes go in untested, assuming they would work, when they actually don't due to erroneous assumptions; alpha testers occasionally will be able to give feedback, but it's not always possible.
For example, if you read the revision logs for what changed between 10.2 and 10.3, the plus sign choice adventure was meant to get a use link. Something as seemingly insignificant as KoL using two spaces instead of one space in the sentence "It's actually a book. Read it." would mean the change didn't actually work -- anyone can verify that, in fact, the change didn't work for this very reason. If you ever encounter something like that, a non-accusatory mention of it (non-accusatory meaning anything that neither implies "ZOMG FALSE ADVERTISING" nor "You guys said this was fixed, but...") somewhere will usually result in the problem getting addressed.
Finally, if you've got a bug to report, make sure you read up on how to post a detailed bug report. While the rules outlined apply specifically to bugs related to scripting, many of them are applicable to KoLmafia bug reports in general. Most importantly, I hate the words "annoying" and "frustrating". Never use them when describing a bug/feature. Ever. Thanks. The abridged revision logs follow.
Revision: 7133
Fix erroneous tallying of "Pulls" on item creation queue.
Drastically simply hedge rotation quest solver. Fix detection of puzzles being
stolen. Only abort processing when last puzzle is stolen. (Untested.)
Revision: 7134
When KoLmafia is acting as a proxy for another browser - i.e., you are running
in the Relay Browser - we accept requests from the browser and pass them on to
KoL, and get the replies and pass them back to the browser.
Used to be no matter whether the browser issued a GET or a POST, we turned it
into a POST and sent it along.
Unfortunately, there are some pages on KoL - like the clan roster - which have
forms that specifically request a GET - and don't do the "right" thing if we
request the form via a POST.
We now recognize when the browser is asking for a GET or a POST and attempt to
Do The Right Thing in either case.
My testing finds no errors, so far - and the clan roster pages now work as
expected - but this is a big change. Don't hold back on reporting bugs!
Revision: 7135
Regardless of post method, split out form fields into a data string, as before.
This should fix side commands and stationary combat buttons...
Revision: 7136
Fix NPE when attempt to create, for example, a Frost™ brand sword
Revision: 7137
Yet another attempt at GET vs. POST. Sigh.
Revision: 7138
One more try: save data fields for easy access, whether using GET or POST
Save submitted path intact when form requested via GET.
Revision: 7139
Fix fight round tracking from relay browser
Revision: 7140
After fetching the hedge key, we need to look at the puzzle again.
Revision: 7141
Add item drop data for the Wreck of the Edgar Fitzsimmons
Revision: 7142
When we automatically handle choices, we need to use the POST method
Revision: 7143
Yet Another Attempt at simplifying GET vs. POST. Hopefully this no longer
breaks proxy connections.
Revision: 7144
(Probably) fix ASH relay override scripts for pages with form fields.
Fix inappropriate reuse of pages when close and re-open relay browser.
Revision: 7145
Changes to armgun. Fix auto-purchase of hermit permit in use links.
Revision: 7146
When mallselling multiple items at once, use the proper price & limit values
for each item - those aren't necessarily the next element in their arrays,
due to the possibility of an unsellable item being skipped.
Revision: 7147
When visiting the Haunted Wine Cellar altar, only add item conditions for
dusty wines that you don't already have in inventory.
Revision: 7148
When fighting a rampaging adding machine while in Birdform, do not attempt to
make scrolls.
Revision: 7149
When the "telescope" command shows you the Lair items you'll need, if you
have an item in both your inventory and closet, indicate both.
Revision: 7150
Do outfit checkpointing around the CLI "acquire" command.
Revision: 7151
When sending kmail due to an ASH notify statement, include the filename of
the script rather than the full pathname (which may contain personally
identifying information).
Revision: 7152
Don't bulk purchase consumables if the player has less than 5000 Meat on
hand, since NPC purchases will fail completely rather than get a reduced
quantity.
Fix Wiki lookups again - any item with modifiers, but no Wiki Name modifier,
was trying to use an empty string as its name.
Revision: 7153
Include items that restore both HP and MP (such as tiny houses) in the Usable
panel of the item manager.
Revision: 7154
Tambourine is now a weapon. Fix a couple of item modifiers. Give TGMOB an attack
rating so that when you flyer him, you get warm fuzzy feedback. Peg advertising
percentage at 100%.
Revision: 7155
Modifier for Disco Fever
Revision: 7156
Add defaults for five of six new turtle choice adventures.
Revision: 7157
Allow "leaflet stats" as a synonym for "leaflet".
Fix hedge maze solver: need to fetch maze status again after getting hedge key
if any tiles were rotated.
Revision: 7158
Add drop rates for gel and radishes
Add conditions to appropriate places for Doc's herbs.
Revision: 7159
Save/get concoctions in the ConcopctionPool by canonical name, rather than
actual name.
Revision: 7160
Log battlefield progress after logging monster health loss
Revision: 7161
Fix typo
Revision: 7162
Sushi with eel sauce is now officially prefixed "electric".
When you finish the war on the island, mark the hippy store available
Revision: 7163
super-spikey -> super-spiky. Add spooky glove to default conditions for barrow.
Revision: 7164
Check for forumURL starting with, not equal to, newchatmessages.php or
submitnewchat.php, to determine if a request is a chat request.
When the nuns claim Meat, log it in the session log:
The nuns take 2,167 Meat; 87,282 recovered, 12,718 left to recover.
Assume that anything less than a brigand's base meat drop - 800 - is from a
familiar action, regardless of meat drop percentage. It is possible for there to
be less than 800 Meat left to recover for the nuns. If so, meat drops of at
least that amount but less than 800 still count as going to the nuns.
Revision: 7165
Allow love songs to be auto-purchased from the mall.
Revision: 7166
Change name of super-spiky hair gel as Sorceress Lair gate item, too
Revision: 7167
Add a preference, accessible from Login Frame, to enable/disable stealth login
Revision: 7168
Add blended frozen swill with a fly in it (yum!)
Revision: 7169
Add turtle choice adventure for battlefield
Revision: 7170
Ronin ends as soon as you free the king.
Revision: 7171
You can pickpocket the silver shrimp fork
Revision: 7172
When passed a non-http URL, prefix with file://, rather than file:///.
Only http URLs get spaces turned into plus signs.
Revision: 7173
Adds the recently spaded formulas for the mutant Raffle House familiars.
This required adding new "Volleyball Effectiveness" (etc.) modifiers, since
the Grimace moonlight-dependent formulas aren't easily expressible in terms
of familiar weight.
Revision: 7174
Correctly give the overdrink warning when drinking more than one of an item.
The check predates the "drink multiple" feature, and was only giving the
warning if the first drink would take you over the inebriety limit.
Revision: 7175
Implemented "Nonstackable Watch" boolean modifier, and added it to the five
relevant items. If more than one such item is equipped, only the first will
affect the "Adventures" modifier (all other modifiers remain in effect).
Revision: 7176
Experimental change to Gear Changer combo boxes: Perform actions when the popup
menu of a combo box is canceled or will become invisible, not every time you
change the selection within it via key presses.
- When you select the Familiar combo box, you can scroll around as much as you
want. We will only change the familiar when you dismiss the popup menu, and
only if the familiar is different
- When you select an Outfit, you can scroll around with keys and we will only
change outfits when the popup menu is dismissed.
- When you select a weapon, you can scroll around as much as you want and we
will only clear an incompatible offhand item when you dismiss the popup menu
Revision: 7177
Item drop data for the Marinara Trench
Revision: 7178
Eliminate false positives: better check for missing molybdenum screwdriver
Revision: 7179
Fix boss warnings
Revision: 7180
Simplify implementation of PopupMenuListener in GearChangeFrame and
ThreadedListener.
Add a "no change" entry to the list of custom outfits on the Gear Changer
Revision: 7181
Now that the custom outfit list has a "no change" entry in it, skip it whenever
you need to iterate over the custom outfits.
If the saved louvre layout is shorter than required, don't get an NPE.
If you logged out in the middle of a choice adventure, when you log in again,
you will be directed to make the choice. In KoLmafia's login sequence, this
happens when retrieving the charsheet. Make two changes to make this work:
- Make the CHOICE_HANDLER a PasswordHashRequest and allow choice.php to be
called initially, even if we don't know the password hash. When we get the
reply, we will know the password hash, since it will have been parsed out of
the response text.
- If we are redirected to a choice while in our login sequence, we need to retry
whatever was redirected - the charsheet.
Revision: 7182
If the buffed stats calculated by mafia (based on stat modifiers) differs
from the buffed stats shown on the charpane, indicate this fact and the
magnitude of the error at the top of the modifiers popup. This should make
it easier to track down incorrect or unknown stat modifiers.
Based on the results of this feature, I have removed some special handling
for negative stat modifiers, as it was demonstrably generating incorrect
values.
Revision: 7183
Fix side commands. Sigh.
Revision: 7184
Fix outfit command
Revision: 7185
Do not allow "=" to be used as a synonym for "==" in expressions, since
experienced ASH programmers expect "=" to be used only for assignment.
Revision: 7186
The "feed hobo" and "feed ghost" buttons on the Item Manager no longer limit
the amount you can feed at once by your fullness or inebriety.
Revision: 7187
And more of the same
Revision: 7188
When you acquire the "Knob Goblin Perfume" effect in the relay browser, give a
navigation link to the king's chamber.
Revision: 7189
Your inebriety limit differs from your fullness and your spleen hit limit.
Revision: 7190
Sheesh. Inebriety capacity is one less than drunkenness - and you can drink at
most one beverage when you are at that point.
Revision: 7191
Add item drops for Anemone Mine. Fix item drop for writing desk.
When automating strange leaflet, make sure we're in the cave before looking
for the egg.
Revision: 7192
Update for the recent locations feature for the relay browser.
When in compact mode, put recent locations inside of a hidden span which appears when you mouse over the "Adv" link. Also use full location names rather than initials for the location name, since the hidden span allows for more vertical space to be used.
When in full mode, make sure that the name of location doesn't line wrap to make link-clicking more consistent. Also use line breaks rather than a comma-delimited list.
Revision: 7193
Advance pyramid position even if current position is 0.
Revision: 7194
Log progress of Nun quest in gCLI as well as in session log
Revision: 7195
Fix off-by-one error when deciding when to add a line break tag when listing recent locations in compact mode
Revision: 7196
Always look at the puzzle again after retrieving the key.
Revision: 7197
Refactor combo boxes on the Gear Changer:
- Equipment lists have a PopupMenuListener and revalidate only when the popup
menu is about to go away. This allows you to use keys to scroll around within
the equipment without firing events and revalidating before making a selection
- The Outfit and Familiar lists have been reverted to having ActionListeners.
This means that they fire either when you scroll within the lists via key
presses, or when the menu actually disappears. The former is not desirable,
but I don't have a solution for it yet. The latter is essential; the popup
menu no longer lingers while the outfit or familiar is being changed.
Revision: 7198
Remove the blank prescription pad as an SUSE concoction, since it has a chance
of retuning two different items.
Revision: 7199
When parsing item names, do not give special precedence to candy hearts,
snowcones, or cupcakes if more than one such item matches. For example, "buy
cup" will now properly give the "too many matches" error, rather than buying
a random cupcake.
I'm not sure if this special case should still exist at all, given the
possibility of expensive mistakes that it creates, but I'm not sure what
problem it was intended to solve - maybe the alternative was worse.
Revision: 7200
Normalize adventure and stat gains for upgraded swills
Revision: 7201
Detect hit point estimates from detective skull, clockwork detective skull, and
toy space helmet. Log them to gCLI and session log, if you are displaying
monster health changes.
Revision: 7202
Inline use links no longer strip off text preceding the first table. Hopefully,
this means that we will no longer suppress the topmenu refresh requested when
you use dinghy plans with dingy planks in inventory and thus open up the island
Revision: 7203
Update area and monster data for the Mer-kin Outpost
Revision: 7204
Add item drop percentages for The Dive Bar
Revision: 7205
Tongue of the Walrus can cure six different afflictions, not just Beaten Up.
C. H. U. M. -> C.H.U.M.
Revision: 7206
Add new quest items.
Fix boss warning and session logging for the Goblin King.
Add alias for the bogus URL on the bat hole map for the Boss Bat: there is a
trailing semicolon.
Log GET and POST requests from the browser in the debug log.
Efficiency change in Relay Browser: when you execute a charpane request (using
an up arrow to increase turns of an effect, executing a mood, restoring HP or
MP, etc.) do not do a charpane request between every request in the sequence and
then again at the end. Do it only at the end.
Custom javascript in basic.js now makes requests via GET, rather than POST. This
should prevent KoLmafia from adding unnecessary password hashes and otherwise
mucking with the fields.
Revision: 7207
When an item name changes (like super-spikey hair gel -> super-spiky hair gel),
if you have it in your mall store, we recognize it by the item id but create
an AdventureRequest by looking up the name - which creates a bogus result.
Create the AdventureResult directly from the item id and avoid NPE debug logs.
Revision: 7208
Add oyster egg balloon. Paco takes away your thick padded envelope.
Revision: 7209
Initial support for Dwarven Factory Quest.
- Whenever you visit a place that has runes on it, save rune in a setting
- Whenever you use an item from the office with runes, save runes in setting
We don't do anything with these, yet. We don't even have a CLI command to
display what we saved.
Revision: 7210
Lucky 888 no longer functions as a buffbot
Revision: 7211
As you successfully identify an item in the warehouse, remove that rune from
the list of runes for not-yet-identified items.
When you gamble in the dormitory, log the dice and result in the session log
and gCLI.
Revision: 7212
The Mine Foremens' Office does not appear on the McLargeHuge map.
Revision: 7213
Print gambling results as two digits: total div 7, total mod 7
Revision: 7214
When you find ore or coal in the warehouse, provide a use link which is the
number in inventory which takes you to the machine room.
Log visiting and manipulating all the components of the machine room.
Handle inventory correctly when you add or remove ores from the hoppers.
Revision: 7215
Give a link to paco when you get the thick padded envelope
Revision: 7216
We do not need a lastDwarfGauges setting, since that's just the rune that means
"gauges".
Revision: 7217
C.H.U.M. items and C. H. U. M. monsters
Revision: 7218
Add new modifier: "Familiar Weight Cap". This is parsed out of the "Familiar
Effect" modifier (where currently only hats specify it) and applued to the
familiar's weight before applying the "effectiveness" modifier for volleyball,
fairy, leprechaun, and sombrero effects.
Revision: 7219
Initial support for the Clan VIP Lounge
- Add items and effects, as the Wiki currently has them
- Log visits to the pieces of equipment in session log
- Add option to visit Lounge - currently only Deluxe Mr. Klaw - to breafast
Revision: 7220
When you put ore into a hopper and it works, associate that ore with that hopper
Add CLI command: "factory report CIJFDGB" will use all the data it's collected
when you got - and looked at - items from the office, correlated with the ids
of items, as gleaned from the hoppers and/or the warehouse, and print a little
table of ore counts and gauge settings to get each prize.
Revision: 7221
Add more Deluxe Mr. Klaw items.
Revision: 7222
Add semi-rare choice adventure #330 in Haunted Billiards Room
Fix use of Deluxe Mr. Klaw during breakfast.
Revision: 7223
Say what? Fix a typo...
Revision: 7224
Mana burning is now willing to boost turns of Ur-Kel's Aria of Annoyance.
Add "factory check" CLI command which tells you if you've acquired all the items
you need and identified the ores and equipment.
The "factory report" command will not bother giving you a report unless you
have all the items and have identified the ores and equipment.
Add many little tweaks to speed up item identification in the factory:
- We deduce the equipment and ore runes when we read papers and laminated cards
from the office.
- There are 3 equipments and 4 ores. As soon as you have identified 2 or 3,
respectively, we auto-identify the last one
- When you find equipment in the factory, any runes which are not equipment get
eliminated immediately. Ditto for ores and ore runes.
Revision: 7225
Add more Deluxe Mr. Klaw items
Revision: 7226
No Deluxe Mr. Klaw during breakfast if you are in Bad Moon
Revision: 7227
Print a newline following factory report table.
Check ClanLounge setting for Deluxe Mr. Klaw, not Clan Rumpus Room setting.
Revision: 7228
Add two more options to the CLI "factory" command:
"factory setdigits <7-character-string>" saves the 7 characters as this
ascension's digit string in the lastDwarfDigitRunes setting
"factory report" (with no digit string) uses the saved digit string.
Add support for Dwarf War Outfit pieces
- When wielding the mattock, record mattock's estimate of monster HP
- When wearing the helmet, record helmet's estimate of monster attack rating.
This only works if you have save a digit string via "factory setdigits".
- When wearing the kilt, record kilt's estimate of monster defense rating.
Revision: 7229
ASH "retrieve_item" function now returns exactly what InventoryManager returns,
not the KoLmafia "continue state".
Revision: 7230
Print message when you've deduced the last ore rune or the last equipment rune
Revision: 7231
When clicking on an in-line use link which forces the topmenu to refresh (only
the dinghy plans, as far as I know), refresh the topmenu, as directed by KoL -
but put it in the topmenu frame, not the charpane.
Revision: 7232
Add spoilers to the 3 gate puzzle: We give the name of the effect you need and
- if the effect is already active, we tell you
- else if an item in your inventory gives it, we list the item with a use link
- else we tell you the item you need and mock you for not having any
Minor code cleanups here and there.
Revision: 7233
KoL changed the account page: enabling/disabling the Combat Action Bar now
requires the password hash. This broke our detection of such which therefore
broke the fight page.
Revision: 7234
No NPE if you use the autoattack CLI command with no parameters
Revision: 7235
Add new seal clubber items, recipes, effects, etc.
Note: no support, yet, for daily seal summoning limit, consumption of candles,
and so on.
Revision: 7236
Support for the Vacuum Chamber:
- when you successfully transmute something, adjust inventory
- Add "factory vacuum <n> <item>" to put the specified number of the specified
item into the chamber. <n> is optional.
Revision: 7237
Mark love songs as usable in combat, courtesy of dangerpin
Revision: 7238
Fix auto-selection of items in the sorceress tower:
- if another item is already selected, remove it
- don't get folled by item numbers which are substrings of other item numbers
Revision: 7239
Bump version to 13.2
Reply With Quote
