Bug - Fixed Putting on outfit that contains pants equipped on pantsrack fails

xKiv

Active member
Code:
> outfit pvp

Removing items from closet...
You acquire an item: f3d0r4
Removing items from closet...
You acquire X-37 gun (2)
Removing items from closet...
You acquire an item: Ultracolor™ shirt
Stealing 1337 7r0uZ0RZ from Gregless the Fancypants Scarecrow...
Unequipping Gregless the Fancypants Scarecrow...
Familiar request unsuccessful.
Stealing 1337 7r0uZ0RZ from Gregless the Fancypants Scarecrow...
Unequipping Gregless the Fancypants Scarecrow...
Familiar request unsuccessful.
Putting on outfit: pvp
You only put on part of that outfit.

Mafia correctly knows that the outfit contains 1337 7r0uZ0RZ and tries to acquire them.
After this, the pantzorz are still on my scarecrow, and my character still has original pants equipped.

Three issues:
1) Why did stealing pants off the familiar not work?
2) Why did mafia try to steal equipped item rather than grab the one I have in closet?
(should mafia's item acquisition prefer unequipping or uncloseting?)
3) Why does it fail to steal the pants *twice*?

Workaround: uncloset (or buy) a pair of 1337 7r0uZ0rz
(acquire doesn't work, it tries to steal them off the pantsrack ... and fails ... both of which are something I don't want)
 

xKiv

Active member
Disembodied hand didn't work as recently as few weeks back (when I was last sauceror; "maximize mp" put a saucepanic on the hand, and a later "acquire saucepanic" aborted while trying to steal it; the hand was still active familiar at the time if it matters).
(I don't think mafia tried to steal the item twice, though)

(I am normally averse to any form of communication, AND racing against rollover, so I just put "/unequip familiar" at the start of the relevant script instead of reporting - and on top of that I already had an open bug report on it x_x)


ETA: I don't have a hatrack.
 

Darzil

Developer
Also I guess it's the same bug, but you also get a failure to remove a foldable from a familiar when using a maximization that would wear it.
 

Veracity

Developer
Staff member
I made an outfit containing

basic meat hemet
basic meat pants
cool whip

Code:
[color=green]> outfit Birthday Suit[/color]

Taking off everything...
Everything removed.

[color=green]> familiar scarecrow[/color]

Putting Hasemary the Trick-or-Treating Tot back into terrarium...
Taking Pantsless Grrl the Fancypants Scarecrow out of terrarium...
Requests complete.

[color=green]> equip familiar basic meat pants[/color]

Putting on basic meat pants...
Equipment changed.

[color=green]> familiar hat rack[/color]

Putting Pantsless Grrl the Fancypants Scarecrow back into terrarium...
Taking Hat Grrl the Mad Hatrack out of terrarium...
Requests complete.

[color=green]> equip familiar basic meat helmet[/color]

Putting on basic meat helmet...
Equipment changed.

[color=green]> familiar disembodied hand[/color]

Putting Hat Grrl the Mad Hatrack back into terrarium...
Taking Hand Jive Grrl the Disembodied Hand out of terrarium...
Requests complete.

[color=green]> equip familiar cool whip[/color]

Putting on cool whip...
Equipment changed.

[color=green]> familiar none[/color]

Putting Hand Jive Grrl the Disembodied Hand back into terrarium...
Requests complete.

[color=green]> outfit Meat[/color]

Stealing basic meat helmet from Hat Grrl the Mad Hatrack...
Unequipping Hat Grrl the Mad Hatrack...
Familiar unequipped.
Stealing cool whip from Hand Jive Grrl the Disembodied Hand...
Unequipping Hand Jive Grrl the Disembodied Hand...
Familiar unequipped.
Stealing basic meat pants from Pantsless Grrl the Fancypants Scarecrow...
Unequipping Pantsless Grrl the Fancypants Scarecrow...
Familiar unequipped.
Putting on outfit: Meat
Equipment changed.
How hard can it be to fix this?
Answer: impossible, if I cannot reproduce it.
 

Veracity

Developer
Staff member
Revision 17429 fixes a couple of little bugs I noticed while trying to reproduce this:

- When we steal an item from a familiar, it used to say "Familiar equipped". Now it says "Familiar unequipped".
- Even though ShowDataCommand had code to list your current equipment, there was no way to invoke it. "equip" with no parameters supposedly requested that, but it passed "equipment" and ShowDataCommand expected "equip". Fixed.
 

Veracity

Developer
Staff member
OK, got it. It only fails if the familiar it is stealing from is your active familiar. Investigating.
 

xKiv

Active member
familiar none

Ah, there's a difference. That's not a thing I did (and didn't mention that I didn't do). My failures were always stealing off the *active* familiar.
Let me check again.
...
Code:
> refresh all

Refreshing session data...
Synchronizing moon data...
Loading character status...
Retrieving character data...
Updating inventory...
Examining Meat in closet...
Updating closet...
Retrieving quest data...
Retrieving familiar data...
Familiar data retrieved.
Retrieving campground data...
Examining Meat and pulls in storage...
Updating storage...
You are currently a member of Hyrule
Visiting Crimbo Tree in clan VIP lounge
Visiting Hot Dog Stand in clan VIP lounge
Visiting Speakeasy in clan VIP lounge
Visiting Floundry in clan VIP lounge
Session data refreshed.

> familiar hand

> equip haiku katana

> equip familiar haiku katana

> equip

Hat: insulting hat
Weapon: crazy bastard sword
Off-hand: card sleeve
Shirt: Sneaky Pete's leather jacket (collar popped)
Pants: Travoltan trousers
Container: octolus-skin cloak

Acc. 1: offensive moustache
Acc. 2: numberwang
Acc. 3: ticksilver ring

Pet: Disembodied Hand (21 lbs)
Item: haiku katana

> acquire haiku katana

Stealing haiku katana from Rusicka the Disembodied Hand...
Unequipping Rusicka the Disembodied Hand...
Familiar request unsuccessful.

...
Also, I think your fix to ShowDataCommand made it so that refresh equip (and refresh equipment) refreshes the entire inventory now? It used to print current equipped equipment, now it prints the entire inventory (including consumables and misc).

ETA: debug log View attachment DEBUG_20161124.txt
 
Last edited:

Veracity

Developer
Staff member
This fails:

familiar.php?famid=152&action=unequip&ajax=1

This works:

inv_equip.php?which=2&ajax=1&action=unequip&type=familiarequip
 
Top