txrangersxx
Member
I have OCD setup so it mall sells all my wads. When I run it it puts all but the Cold Wads and Twinkly Wads in the mall.
OCD Inventory control
- Thread starter Bale
- Start date
txrangersxx
Member
Not listed in Items to stock. Here are the two lines from OCDdata_txranger.txt
twinkly wad MALL 0
cold wad MALL 0
twinkly wad MALL 0
cold wad MALL 0
darkcodelagsniper
Member
I often had trouble trying to find a specific item with the relay script. I'd end up clicking through various tabs trying to remember which category I put it in, and scrolling though vast lists of items.
So today I bodged in a simple search subcategory under the "Edit Categories" tab.
Here's the edited version if you want to take a look:
View attachment relay_OCD_dB_Manager.ash
Be warned that I've done no testing apart from checking that it basically works and I can save changes to searched items
So today I bodged in a simple search subcategory under the "Edit Categories" tab.
Here's the edited version if you want to take a look:
View attachment relay_OCD_dB_Manager.ash
Be warned that I've done no testing apart from checking that it basically works and I can save changes to searched items
Bale
Minion
Interesting. I never would have thought to implement it like that. Your method is much simpler than the one I would have used.
It's particularly interesting that it allows you to search for items that aren't in your data file at all. That's was probably just a side effect using such a simple method, but I think it might actually be a feature. Or maybe it is a bug. I cannot decide. It's probably a feature to have a method that allows you to add items to the data file even though you do not have one.
I would like opinions from you and others who read this thread. Is that a feature or a bug?
This looks pretty good actually. The only problem I see with your work is that it allows us to add items to the data file which cannot actually be handled by OCD, such as quest items like my evilometer. Simple enough to fix though.
I'm going to look this one over for a day or two and then implement it in some form.
It's particularly interesting that it allows you to search for items that aren't in your data file at all. That's was probably just a side effect using such a simple method, but I think it might actually be a feature. Or maybe it is a bug. I cannot decide. It's probably a feature to have a method that allows you to add items to the data file even though you do not have one.
I would like opinions from you and others who read this thread. Is that a feature or a bug?
This looks pretty good actually. The only problem I see with your work is that it allows us to add items to the data file which cannot actually be handled by OCD, such as quest items like my evilometer. Simple enough to fix though.
I'm going to look this one over for a day or two and then implement it in some form.
Last edited:
Magus_Prime
Well-known member
@Bale - I like what darkcodelagsniper added and would love to see it in OCD. Every time I would open the OCD data file in an editor I found myself wishing for exactly this. I think the unexpected functionality counts as a feature.
I resort to a spreadsheet to do similar things. A wild card search on item name that would show me the OCD status of an item, including uncategorized would be wonderful. Did I just call something a feature?
Bale
Minion
I made some small tweaks to the code posted by darkcodelagsniper, but 98% of it was just his brilliance. darkcodelagsniper, you might find it interesting to see what I changed, but I really owe you for figuring out such a simple way to do something that I was thinking of as complicated. It was honestly fun to search for " barrel" and then telling it what to do about both of the new barrels that I hadn't actually found while adventuring. Adding items I don't own is definitely a feature.
The new feature has been committed, so pleased do an "svn update" and enjoy.
The new feature has been committed, so pleased do an "svn update" and enjoy.
darkcodelagsniper
Member
Glad I could be of help!
Another tweak I think could be nice would be to restore alphabetical sorting for items - both in the relay browser and when OCD is invoked and acts on items. E.g. where now a boolean[item] map is iterated, you would instead iterate over an item[int] map, sorted by value.
Another tweak I think could be nice would be to restore alphabetical sorting for items - both in the relay browser and when OCD is invoked and acts on items. E.g. where now a boolean[item] map is iterated, you would instead iterate over an item[int] map, sorted by value.
Bale
Minion
I believe that KoLmafia's default for alphabetical sorting was altered when adapting to deal with multiple items with the same name. You're right that I should do something about it, but its just so pervasive that it would be a PITA to fix.
The solution you propose for the database manager would work the way suggst, but it would be an order of magnitude harder to take care of it for the control script. I'll update the relay script now and start thinking about a good way to handle it for the control.
It has been committed, so update if you want to see it.
The solution you propose for the database manager would work the way suggst, but it would be an order of magnitude harder to take care of it for the control script. I'll update the relay script now and start thinking about a good way to handle it for the control.
It has been committed, so update if you want to see it.
Bale
Minion
I've been looking over my old code for OCD Inventory Control to consider how it should be alphabetized now that updates to mafia have killed the original simple method. As I do so, I keep wondering what kind of deranged idiot wrote that. I mean, really! It's completely shit!
At this point I'm considering scrapping the old code and starting from scratch. It's just that bad.
Edit: Never mind. I started rewriting it. In the process I figured out why I was dong some of those stupid crazy things. The script makes more sense than I thought. Stupid, yeah, but stupid like a fox! Not rewriting it after all.
At least I did figure out what I'll have to do to make it alphabetize like it used to. Not fun. Maybe I'll do it tomorrow.
At this point I'm considering scrapping the old code and starting from scratch. It's just that bad.
Edit: Never mind. I started rewriting it. In the process I figured out why I was dong some of those stupid crazy things. The script makes more sense than I thought. Stupid, yeah, but stupid like a fox! Not rewriting it after all.
At least I did figure out what I'll have to do to make it alphabetize like it used to. Not fun. Maybe I'll do it tomorrow.
Last edited:
Bale
Minion
I've made a couple of small tweaks and bug fixes to the new search implementation. It's finished now and I love it! Now when I click on "Edit Database" it goes straight to the "Search" tab and focuses on the text field so I can begin typing immediately.
I do have a question though, for someone whose knowledge of html forms is better than my own. When I hit enter in the text bar of the search it activates the first button (submit) on the page. Why does it do that?
The first button on the page was save. Because of that it was always saving if I typed a search term like, "cuppa" and hit enter instead of clicking the button. There were possible circumstances where that actually cased a problem. I finally fixed that bug with a work-around by adding an invisible button at the top of the page which does nothing. That work-around is flawless, but I would like to know if there was a better or different solution I should have used.
I do have a question though, for someone whose knowledge of html forms is better than my own. When I hit enter in the text bar of the search it activates the first button (submit) on the page. Why does it do that?
The first button on the page was save. Because of that it was always saving if I typed a search term like, "cuppa" and hit enter instead of clicking the button. There were possible circumstances where that actually cased a problem. I finally fixed that bug with a work-around by adding an invisible button at the top of the page which does nothing. That work-around is flawless, but I would like to know if there was a better or different solution I should have used.
Bale
Minion
I see. Thank you.
I had tried enclosing the section in a separate <form> </form> and setting the form field, but that kept it from working at all. (Perhaps because of an interaction through the relay browser?) At least, I'm glad to know that activating the first submit button in the enclosing form is expected behavior. In retrospective, perhaps a functional solution would have been to put a <form id="search"></form> field outside of the active form and using the form field in the text box to connect it to that previous form? Maybe next week I'll revisit the code to see if that works.
DoctorWeebl
New member
Thank you, darkcodelagsniper and Bale, for this outstanding new search feature. This is saving me a lot of headache and time.
im having an issue with it, when i set the "keep" number for an item (in this case a seal clubbing club) and tell it to autosell the rest through the relay it doesn't save the number to keep but does tell it to autosell them, when i checked mafia's grafical CLI it said the following every time after i hit save
I updated the script today, and I am using the daily build version 17.1 r16339
I have checked folder permissions they are fine, it use to work fine too.
I updated the script today, and I am using the daily build version 17.1 r16339
Bale
Minion
That is pretty bizarre. I didn't change anything which should have caused something like that. That even seems to be lines that relate to stocking. Are you set to stock those items? Are you using the item stocking section of this script at all? Could you attach your OCData_name.txt file and your stock file also?
It also might help me out if you did something to print some debugging messages. Please uncomment line 911 if you know how to do that. (Delete the # at the beginning of the line.)
I won't have time to look at that again until Monday. Sorry about the delay, but I'll take another look then.
It also might help me out if you did something to print some debugging messages. Please uncomment line 911 if you know how to do that. (Delete the # at the beginning of the line.)
I won't have time to look at that again until Monday. Sorry about the delay, but I'll take another look then.
Last edited:
I have stock set to " Keep them... if they happen to be in inventory" i tried to find line 911 but there wasn't anything commented out there... which is REALLY weird due to the fact i had just deleted all the OCD and redownloaded the other day when i first had issues, here are my data and stock files and a screenshot of the stock page cus its weird..
Attachments
Smiling Spectre
Member
I am another one with the weird OCD error, seems, the same as for ganomex. Unlike him, I see no messages in my OCD, but result is pretty close: now every time when I am trying to save results in OCD dB Manager, it erases all numbers in base. Actually, I erased "use" and "mall" tabs this way (and discovered it on next run when it sent to mall all my inventory), then checked "display" and "stash" tabs to be sure that it still have numbers - and it was - and after that when I tried to move something from "mall" to "keep" (successfully), and saved it, OCD erased remained tabs as well. :/