Bug - Fixed Mafia miscounting remaining hippies in the war

M

Magus_Prime

Well-known member
Code: 
You gain 40 Magicalness
You gain 16 Chutzpah
8 hippies defeated; 955 down, 45 left.

Request 3 of 10 (IsleWar: The Battlefield (Frat Uniform)) in progress...
There are no hippy soldiers left.

r15639. This is in a hardcore "Ed" run and it kept an accurate count four days ago.

I completed the Light House and Junkyard side-quests as a Frat Warrior and then adventured until The Orchard opened. Completed the Orchard side-quest. At that point the counts were correct.

It was at some point during the, mostly automated, 100+ adventures in The Battlefield that something caused a miscount. I'm going to check the session logs as soon as I can.

Something happened when I took a turn and went to The Underworld. Here's what is in the session log:

Code: 
[871] The Battlefield (Frat Uniform)
Encounter: War Hippy Elder Shaman
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Sebbaktankhis swats at your opponent's shoelaces (or shoelace-analogues), making her stumble.
Round 2: War Hippy Elder Shaman drops 13 attack power.
Round 2: War Hippy Elder Shaman drops 13 defense.
Round 2: War Hippy Elder Shaman takes 11 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: War Hippy Elder Shaman takes 13 damage.
You gain 5 Mana Points
Round 3: Sebbaktankhis claws at your opponent's trouser cuffs in a distracting way.
Round 3: War Hippy Elder Shaman drops 13 attack power.
Round 3: War Hippy Elder Shaman drops 13 defense.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: War Hippy Elder Shaman takes 643 damage.
Round 4: Sebbaktankhis claws at your opponent's trouser cuffs in a distracting way.
Round 4: War Hippy Elder Shaman drops 13 attack power.
Round 4: War Hippy Elder Shaman drops 13 defense.
Round 4: Arbos wins the fight!
After Battle: Sebbaktankhis rewards you with a gift of dead creature. Hooray.
You acquire an item: rat carcass
After Battle: Sebbaktankhis helps you search the area by rubbing against your legs and nearly making you trip.
You acquire an item: Gaia beads
You acquire an item: Lockenstock™ sandals
You acquire an item: carbonated soy milk
You acquire an item: Ka coin (2)
You gain 19 Beefiness
You gain 42 Mysteriousness
You gain 20 Roguishness
8 hippies defeated; 920 down, 80 left.

place.php?whichplace=edbase&action=edbase_door
Took choice 1053/1: unknown
choice.php?whichchoice=1053&option=1&pwd&sid=4
Took choice 1053/5: unknown
choice.php?whichchoice=1053&option=5&pwd

place.php?whichplace=edbase&action=edbase_portal
Encounter: Like a Bat Into Hell
Took choice 1023/1: unknown
choice.php?pwd&whichchoice=1023&option=1
Encounter: Like a Bat Into Hell
You gain 154 hit points
Took choice 1023/1: unknown
choice.php?pwd&whichchoice=1023&option=1

Visiting Everything Under the World

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

trading 1 Ka coin for 1 talisman of Renenutet
You acquire an item: talisman of Renenutet

place.php?whichplace=edunder&action=edunder_leave
Encounter: Like a Bat out of Hell
Took choice 1024/1: unknown
choice.php?pwd&whichchoice=1024&option=1
place.php?whichplace=edbase&action=ed_returned

The next combat on the battlefield displays the following:

Code: 
[873] The Battlefield (Frat Uniform)
Encounter: War Hippy Elite Rigger
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Newedjeru viciously headbutts your foe, causing 11 damage.
Round 2: War Hippy Elite Rigger takes 11 damage.
Round 2: War Hippy Elite Rigger takes 9 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: War Hippy Elite Rigger takes 19 damage.
You gain 7 Mana Points
Round 3: Newedjeru belts your opponent in the gut for 13 damage.
Round 3: War Hippy Elite Rigger takes 13 damage.
Round 3: War Hippy Elite Rigger takes 10 damage.
Round 3: Newedjeru stands in front of you and growls at your opponent, who hesitates nervously.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: War Hippy Elite Rigger takes 664 damage.
Round 4: Newedjeru slams him in the head with his massive bronze-gauntleted fist, for 7 damage.
Round 4: War Hippy Elite Rigger takes 7 damage.
Round 4: War Hippy Elite Rigger takes 12 damage.
Round 4: Newedjeru stands in front of you and growls at your opponent, who hesitates nervously.
Round 4: Arbos wins the fight!
You acquire an item: pink clay bead
You acquire an item: lead pipe
You acquire an item: Ka coin (2)
You gain 16 Beefiness
You gain 40 Magicalness
You gain 19 Roguishness
8 hippies defeated; 947 down, 53 left.

[874] The Battlefield (Frat Uniform)
Encounter: Mobile Armored Sweat Lodge
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Newedjeru slams it in the head with his massive bronze-gauntleted fist, for 9 damage.
Round 2: Mobile Armored Sweat Lodge takes 9 damage.
Round 2: Mobile Armored Sweat Lodge takes 10 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: Mobile Armored Sweat Lodge takes 17 damage.
You gain 6 Mana Points
Round 3: Newedjeru viciously headbutts your foe, causing 7 damage.
Round 3: Mobile Armored Sweat Lodge takes 7 damage.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: Mobile Armored Sweat Lodge takes 616 damage.
Round 4: Newedjeru belts your opponent in the gut for 4 damage.
Round 4: Mobile Armored Sweat Lodge takes 4 damage.
Round 4: Arbos wins the fight!
After Battle: A love dragonfly buzzes softly in your ear.
You gain 5 Roguishness
You acquire an item: didgeridooka
You acquire an item: Ka coin (2)
You gain 17 Muscleboundness
You gain 40 Magicalness
You gain 16 Chutzpah
8 hippies defeated; 955 down, 45 left.

In a single combat I went from 80 hippies left to 53 and neither number was correct. When KoLmafia thought I had 45 hippies remaining I really had zero.
 
Last edited:
M

Magus_Prime

Well-known member
I found the problem. After some combats the count of dead combatants did not advance. Here's an example:

Code: 
[778] The Battlefield (Frat Uniform)
Encounter: War Hippy Fire Spinner
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Sebbaktankhis swats at your opponent's shoelaces (or shoelace-analogues), making him stumble.
Round 2: War Hippy Fire Spinner drops 13 attack power.
Round 2: War Hippy Fire Spinner drops 13 defense.
Round 2: War Hippy Fire Spinner takes 12 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: War Hippy Fire Spinner takes 19 damage.
You gain 6 Mana Points
Round 3: Sebbaktankhis swats at your opponent's shoelaces (or shoelace-analogues), making him stumble.
Round 3: War Hippy Fire Spinner drops 13 attack power.
Round 3: War Hippy Fire Spinner drops 13 defense.
Round 3: War Hippy Fire Spinner takes 8 damage.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: War Hippy Fire Spinner takes 626 damage.
Round 4: Sebbaktankhis swats at your opponent's shoelaces (or shoelace-analogues), making him stumble.
Round 4: War Hippy Fire Spinner drops 13 attack power.
Round 4: War Hippy Fire Spinner drops 13 defense.
Round 4: War Hippy Fire Spinner takes 9 damage.
Round 4: Arbos wins the fight!
After Battle: A love cricket plays a jaunty tune for you. You tap your feet.
After Battle: Sebbaktankhis helps you search the area by rubbing against your legs and nearly making you trip.
You acquire an item: reinforced beaded headband
You acquire an item: Ka coin (2)
You gain 15 Fortitude
You gain 46 Mysteriousness
You gain 13 Roguishness
8 hippies defeated; 224 down, 776 left.

[779] The Battlefield (Frat Uniform)
Encounter: War Hippy F.R.O.G
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Sebbaktankhis claws at your opponent's trouser cuffs in a distracting way.
Round 2: War Hippy F.R.O.G drops 13 attack power.
Round 2: War Hippy F.R.O.G drops 13 defense.
Round 2: War Hippy F.R.O.G takes 12 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: War Hippy F.R.O.G takes 19 damage.
You gain 7 Mana Points
Round 3: Sebbaktankhis claws at your opponent's trouser cuffs in a distracting way.
Round 3: War Hippy F.R.O.G drops 13 attack power.
Round 3: War Hippy F.R.O.G drops 13 defense.
Round 3: War Hippy F.R.O.G takes 10 damage.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: War Hippy F.R.O.G takes 634 damage.
Round 4: Sebbaktankhis swats at your opponent's shoelaces (or shoelace-analogues), making him stumble.
Round 4: War Hippy F.R.O.G drops 13 attack power.
Round 4: War Hippy F.R.O.G drops 13 defense.
Round 4: War Hippy F.R.O.G takes 8 damage.
Round 4: Arbos wins the fight!
After Battle: Sebbaktankhis meows and leaves a lump of dead animal at your feet.
You acquire an item: rat carcass
After Battle: Sebbaktankhis is exploring a nearby cardboard box. Where did she find a cardboard box?
You acquire an item: lead pipe
You acquire an item: water pipe bomb
You acquire an item: Ka coin (2)
You gain 15 Beefiness
You gain 40 Wizardliness
You gain a Mysticality point!
You gain 17 Cheek

cast 1 Hide of Sobek
You acquire an effect: Hide of Sobek (10)

[780] The Battlefield (Frat Uniform)
Encounter: War Hippy Dread Squad
Round 0: Arbos wins initiative!
You lose 1 hit point
Round 1: Arbos executes a macro!
Round 1: Arbos casts SUMMON LOVE GNATS!
Round 2: Sebbaktankhis swats at your opponents' shoelaces (or shoelace-analogues), making them stumble.
Round 2: War Hippy Dread Squad drops 13 attack power.
Round 2: War Hippy Dread Squad drops 13 defense.
Round 2: War Hippy Dread Squad takes 10 damage.
Round 2: Arbos casts SUMMON LOVE SCARABS!
Round 3: War Hippy Dread Squad takes 26 damage.
You gain 9 Mana Points
Round 3: Sebbaktankhis swats at your opponents' shoelaces (or shoelace-analogues), making them stumble.
Round 3: War Hippy Dread Squad drops 13 attack power.
Round 3: War Hippy Dread Squad drops 13 defense.
Round 3: War Hippy Dread Squad takes 10 damage.
Round 3: Arbos casts STORM OF THE SCARAB!
Round 4: War Hippy Dread Squad takes 806 damage.
Round 4: Sebbaktankhis swats at your opponents' shoelaces (or shoelace-analogues), making them stumble.
Round 4: War Hippy Dread Squad drops 13 attack power.
Round 4: War Hippy Dread Squad drops 13 defense.
Round 4: Arbos wins the fight!
After Battle: Sebbaktankhis is exploring a nearby cardboard box. Where did she find a cardboard box?
You acquire an item: didgeridooka
You acquire an item: Ka coin (2)
You gain 20 Fortitude
You gain 40 Enchantedness
You gain 11 Smarm
8 hippies defeated; 232 down, 768 left.

Why it happened I have no idea.
 
xKiv

xKiv

Active member
Hmm. I now remember seeing a hippy F.R.O.G. in relay browser two days ago, and it was not mafia-decorated (no drops, stats, or elemental alignment color in name) ... as if mafia didn't even recognize it. Can that be connected?
 
M

Magus_Prime

Well-known member
@xKiv: You nailed it! Every instance of a War Hippy F.R.O.G encounter in my session log did not advance the count.
 
D

Darzil

Developer
It appears to be because the trailing "." is not matched for some reason, so the monster War Hippy F.R.O.G isn't matching the known War Hippy F.R.O.G.
 
D

Darzil

Developer
Looks related to r15637, which removes punctuation from the end of a monsters name. Will also affect C. H. U. M.

Not sure why Veracity had to add that code as part of the Haiku dungeon fixes, so will leave it to Veracity to investigate, as I won't want to break her fixes.
 
fronobulax

fronobulax

Developer
Staff member
cheesecookie said:
r15649 is not tracking hippiesDefeated at all (except by image changes or overriden by directly trying to access things such as the orchard/nunnery).
Click to expand...

BCCAscend tried to adventure on the battlefield when there were no more hippies with r15649. I don't know why, but the behavior is consistent with hippiesDefeated not being tracked properly. I was in a standard softcore run, not Ed.
 
Veracity

Veracity

Developer
Staff member
Revision 15650

Code: 
[628] The Battlefield (Frat Uniform)
Encounter: War Hippy Windtalker
Round 0: Veracity loses initiative!
You lose 1 hit point
You lose 44 hit points
Round 1: Veracity casts STORM OF THE SCARAB!
Round 2: War Hippy Windtalker takes 886 damage.
Round 2: Anhhekhemet claws at your opponent's trouser cuffs in a distracting way.
Round 2: War Hippy Windtalker drops 13 attack power.
Round 2: War Hippy Windtalker drops 13 defense.
Round 2: Veracity wins the fight!
After Battle: A love stag beetle brushes up against your ankle affectionately.
You gain 5 Fortitude
After Battle: Anhhekhemet helps you search the area by rubbing against your legs and nearly making you trip.
You acquire an item: green clay bead
You acquire an item: Ka coin (2)
You gain 11 Strengthliness
You gain 48 Magicalness
You gain a Mysticality point!
You gain a Level!
You gain 18 Sarcasm
8 hippies defeated; 8 down, 992 left.

> get hippiesDefeated

8
Click to expand...
 
D

Darzil

Developer
Thank you!

Spent ages trying to track this down earlier, before finally working out (just before I left the house) that Eclipse SVN hadn't actually updated properly and I was testing line by line the wrong code!

It's been bugging me ever since, but I was in the middle of nowhere!
 
You must log in or register to reply here.
Top