Bug - Fixed "Modifies" outputs wrong number of columns for "null" change

xKiv

Active member
You can see this when the filter matches more than 1 modifier (e.g. "modifies item"), and the lists of changes for each modifier are not the same length.

In DebugModifiers.allModifiers():
Code:
			while ( i.hasNext() )
			{
				Object key = i.next();
				Iterator li = (Iterator) DebugModifiers.adjustments.get( key );
				if ( li == null )
				{
					DebugModifiers.buffer.append( "<td colspan=2></td>" );
				}
				else
				{
					Change c = (Change) li.next();
					DebugModifiers.buffer.append( c.toString() );
					
					if ( !li.hasNext() )
					{
						DebugModifiers.adjustments.remove( key );
					}
"Outputs" 2 table columns when li==null, but Change.toString outputs 3 table columns. As a result, the table is jagged and columns don't completely align under their headers.
Changing the colspan to 3 fixes the issue.
 

Darzil

Developer
There's another bug too, which is that the 3 columns is wrong for modtrace, so there are a couple of fixes needed.
 
Top