Results 1 to 7 of 7

Thread: Elemental phail use in Fernwarthy's Basement

  1. #1
    Senior Member
    Join Date
    Sep 2006
    Posts
    350

    Default Elemental phail use in Fernwarthy's Basement

    The KoLmafia wiki section on Basement Diving states that mafia will "Use elementform automatically in the relevant tests." when automating adventures in Fernwarthy's Basement. I suspect this was done back in the days when elemental phials were cheap and easy to make or come by. But after the KoL change to phails some years ago, element phials have become VERY expensive. Is there a way to disable this function given current phial prices? Should I make a feature request for this?

  2. #2

    Default

    It looks like this behavior still occurs. Is this something that should be made into a feature request? Or would it best be handled as a bug report?

  3. #3
    Senior Member Theraze's Avatar
    Join Date
    Mar 2010
    Posts
    8,741

    Default

    Well, it's working the way it's designed to, so it's definitely not a bug. It could arguably be New Content due to a KoL change, but several years later it's not really that new. So probably a Feature Request would be most accurate.

  4. #4

    Default

    Moved the thread, because why not?

    Removing the line that actually uses a phial would be easy. However, that would just mean trying the elemental test and failing instead (repeatedly, I think?), which doesn't sound like an improvement. So the logic for that whole function needs to be reworked, which first requires understanding all of it.

    Looks like it's mostly in BasementRequest.canHandleElementTest() that would need refactoring, with a bit of supporting code elsewhere that could be removed afterward.

  5. #5

    Default

    Removing the line that actually uses a phial would be easy. However, that would just mean trying the elemental test and failing instead (repeatedly, I think?), which doesn't sound like an improvement. So the logic for that whole function needs to be reworked, which first requires understanding all of it.

    Looks like it's mostly in BasementRequest.canHandleElementTest() that would need refactoring, with a bit of supporting code elsewhere that could be removed afterward.
    Originally Posted by lostcalpolydude View Post
    This behavior still is occurring. If there is an easy fix it seems worth doing. Based on what the code does now, if phials were excluded I would expect mafia to quit running adventures because the test could not be passed. Certainly that would be preferable to using a phial that is now worth 100-200k (versus the 300 meat value when the code was first written).

  6. #6

    Default

    This behavior still is occurring. If there is an easy fix it seems worth doing. Based on what the code does now, if phials were excluded I would expect mafia to quit running adventures because the test could not be passed. Certainly that would be preferable to using a phial that is now worth 100-200k (versus the 300 meat value when the code was first written).
    Originally Posted by the Tristero View Post
    The simple approach of removing the phial use would still leave mafia calculating that it can pass based on using a phial, so it would not abort (and wasting a few hundred turns could be considered worse than wasting a phial). Removing that from the code is nontrivial, as I remember.

    Until someone is inspired to properly fix this, not having a phial (or ingredients for one) should work? My basement diving has all been done manually (with lots of maximizer help, of course), so there's no chance of me ever testing any changes I might make to the automated basementing code.

  7. #7
    Developer
    Join Date
    Apr 2010
    Posts
    4,394

    Default

    Had a little look. It is a load of code.

    I think I'd want to:
    Add maximizer option to sort by bonus per price (for elemental tests), and bonus per price per X turns (maybe 10, for hp/stat tests).
    Use these in the relay browser decorator, and show more information there.
    Add basement.js support for changing elemental resist to show changing target.
    That should give the data basis that can then be used for automating the basement via a load of new code.

    This is explicitly not a promise to spend weeks working on something I will never use. I have several higher value projects that I have been wanting to do for years.

Similar Threads

  1. Replies: 0
    Last Post: 08-04-2013, 09:21 PM
  2. 11521: Hockey Elemental is "elemental"
    By RSS Bot in forum Latest SVN Changes
    Replies: 4
    Last Post: 10-01-2012, 01:08 PM
  3. Feature - Rejected Fernwarthy's Basement - Remove relay spam
    By Zaranthos in forum Bug Reports
    Replies: 10
    Last Post: 02-06-2012, 04:43 AM
  4. New Content - Rejected Elemental resistance changes
    By Veracity in forum Bug Reports
    Replies: 8
    Last Post: 12-29-2011, 04:16 AM
  5. Bug Ferny's Basement elemental predictions
    By bordemstirs in forum Bug Reports
    Replies: 0
    Last Post: 06-07-2011, 09:36 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •