Bug - Fixed Improve beehive logging

Veracity

Veracity

Developer
Staff member
I already improved this a lot, but it's still not quite what I want it to be.

Code: 
[400] The Black Forest
Encounter: All Over the Map
Took choice 923/1: fight blackberry bush, visit cobbler, or raid beehive
choice.php?pwd&whichchoice=923&option=1
Encounter: You Found Your Thrill
Took choice 924/3: head towards beehive
choice.php?pwd&whichchoice=924&option=3

[401] The Black Forest
Encounter: Bee Persistent
You lose 4 hit points
You lose 5 hit points
You lose 4 hit points
Took choice 1018/1: head towards beehive (1)
choice.php?pwd&whichchoice=1018&option=1

[402] The Black Forest
Encounter: Bee Rewarded
You lose 4 hit points
You lose 3 hit points
You lose 4 hit points
You lose 3 hit points
You lose 5 hit points
Took choice 1019/1: beehive (1)
choice.php?pwd&whichchoice=1019&option=1
You acquire an item: beehive
You lose 3 hit points
You lose 3 hit points
You lose 5 hit points
You lose 5 hit points
You lose 4 hit points
1) The initial "head towards beehive" option takes a turn - but doesn't show that in spoiler. This is easy
2) The last option that gives you the beehive takes a turn - and shows you - but we don't log the turn advancement.
3) Why do you get the beehive before you get stung repeatedly? I am sure that the response text has it in the expected order. This is something weird about how we process the results for the choice adventure.

I want this:

Code: 
[400] The Black Forest
Encounter: All Over the Map
Took choice 923/1: fight blackberry bush, visit cobbler, or raid beehive
choice.php?pwd&whichchoice=923&option=1
Encounter: You Found Your Thrill
Took choice 924/3: head towards beehive (1)
choice.php?pwd&whichchoice=924&option=3

[401] The Black Forest
Encounter: Bee Persistent
You lose 4 hit points
You lose 5 hit points
You lose 4 hit points
Took choice 1018/1: head towards beehive (1)
choice.php?pwd&whichchoice=1018&option=1

[402] The Black Forest
Encounter: Bee Rewarded
You lose 4 hit points
You lose 3 hit points
You lose 4 hit points
You lose 3 hit points
You lose 5 hit points
Took choice 1019/1: beehive (1)
choice.php?pwd&whichchoice=1019&option=1

[403] The Black Forest
You lose 3 hit points
You lose 3 hit points
You lose 5 hit points
You lose 5 hit points
You lose 4 hit points
You acquire an item: beehive
 
Veracity

Veracity

Developer
Staff member
This is interesting because there are several choices along the way where you can continue - and use a turn - or give up - and not use a turn. It also meant that my multis who have never gotten a beehive could give up just before the end and try again later, to let me test new code.

Revision 15380 makes it log like this when you give up:

Code: 
[228080] The Black Forest
Encounter: All Over the Map
Took choice 923/1: fight blackberry bush, visit cobbler, or raid beehive
choice.php?pwd&whichchoice=923&option=1
Encounter: You Found Your Thrill
Took choice 924/3: head towards beehive (1)
choice.php?pwd&whichchoice=924&option=3

[228081] The Black Forest
Encounter: Bee Persistent
You lose 3 hit points
You lose 3 hit points
You lose 4 hit points
You lose 4 hit points
Took choice 1018/2: give up
choice.php?pwd&whichchoice=1018&option=2

[228081] ...next encounter...
which is correct, and like this if you go all the way:

Code: 
[516555] The Black Forest
Encounter: All Over the Map
Took choice 923/1: fight blackberry bush, visit cobbler, or raid beehive
choice.php?pwd&whichchoice=923&option=1
Encounter: You Found Your Thrill
Took choice 924/3: head towards beehive (1)
choice.php?pwd&whichchoice=924&option=3

[516556] The Black Forest
Encounter: Bee Persistent
You lose 5 hit points
You lose 3 hit points
You lose 3 hit points
You lose 5 hit points
Took choice 1018/1: head towards beehive (1)
choice.php?pwd&whichchoice=1018&option=1

[516557] The Black Forest
Encounter: Bee Rewarded
You lose 4 hit points
You lose 4 hit points
You lose 3 hit points
You lose 5 hit points
Took choice 1019/1: beehive (1)
choice.php?pwd&whichchoice=1019&option=1

[516557] The Black Forest
You lose 3 hit points
You lose 5 hit points
You lose 5 hit points
You lose 5 hit points
You lose 4 hit points
You acquire an item: beehive

[516558] ... next encounter...
which is probably correct. Perhaps the "You acquire an item: beehive" should have the same turn number as the following adventure, but KoL doesn't actually increment the turn number in the charpane until after you take the adventure, and I think it would be confusing to have that have the same turn number as the subsequent adventure.

I noticed one oddness: it takes 3 turns to get to the beehive. What happens if you get the "You Found Your Thrill" choice with only 2 turns left and try to get to the beehive? Answer: you can get all the way to the choice with the beehive - and take that choice - but rather than giving you stings and the beehive (and using a turn), it gives you the choice again with the test "You can see the beehive! It's right in front of you!" and a single choice: "Flee". Here's how we log that:

Code: 
[182500] The Black Forest
Encounter: All Over the Map
Took choice 923/1: fight blackberry bush, visit cobbler, or raid beehive
choice.php?pwd&whichchoice=923&option=1
Encounter: You Found Your Thrill
Took choice 924/3: head towards beehive (1)
choice.php?pwd&whichchoice=924&option=3

[182501] The Black Forest
Encounter: Bee Persistent
You lose 4 hit points
You lose 4 hit points
You lose 4 hit points
You lose 3 hit points
Took choice 1018/1: head towards beehive (1)
choice.php?pwd&whichchoice=1018&option=1

[182502] The Black Forest
Encounter: Bee Rewarded
You lose 5 hit points
You lose 4 hit points
You lose 5 hit points
You lose 4 hit points
Took choice 1019/1: beehive (1)
choice.php?pwd&whichchoice=1019&option=1

[182502] The Black Forest

[182503] The Black Forest
Encounter: Bee Rewarded
Took choice 1019/2: give up
choice.php?pwd&whichchoice=1019&option=2
Notice the extra section there where you expect it to log all the bee stings and the beehive, but those didn't happen. KoL did, however, refresh the charpane after that, so when it presented the same choice again, the turn counter was incremented.

I don't know what the "right" way to log that is. But it's definitely the abnormal case, so I'm not going to worry about it. Well, maybe I will think about it, but I won't worry too much if I change nothing. :)

I think this is fixed enough.
 
You must log in or register to reply here.
Top