Bug - Fixed Warn about crafting turns ignores triple reagent for saucerors

Veracity

Developer
Staff member
I am a Sauceror in a Standard run.
I don't have Inigo's up, but I do have the Rapid Prototyping skill, which gives me 5 free crafts per day.
KoLmafia correctly takes that into account when deciding how many turns of free crafting I have available.
"get _rapidPrototypingUsed" returns 1; I have used one turn of it today.

I told the Item Manager to make 6 milk of magnesium.
Since I am a Sauceror, that will use 2 of each ingredient and will take two turns.

The item manager warns me:

You will run out of free crafting turns before you finished crafting

Well, actually, no I will not.

It calculates the number of turns via concoction.getAdventuresNeeded( count ), where concoction is, in fact, a Concoction. That method does not take the concoction's "yield" into account. It could use this:

Code:
	public int getYield()
	{
		if ( KoLCharacter.tripleReagent() && this.isReagentPotion() )
		{
			return 3 * this.yield;
		}

		return this.yield;
	}
which, as you can see, takes the triple reagent factor into account. But it doesn't.

It should.

(I could have just said "no problem", but I canceled and made 1 (yielding 3) and then 1 again (yielding 3 more). I didn't get warned either time, obviously, since I had first 4, and then 3 turns of free crafting left when I made those requests. "get _rapidPrototypingUsed" now returns 3.)
 
Last edited:
Top