Page 1 of 3 1 2 3 LastLast
Results 1 to 10 of 21

Thread: Tattoos.ash - Updated

  1. #1
    Senior Member Raven434's Avatar
    Join Date
    May 2007
    Location
    Virginia
    Posts
    461

    Post Tattoos.ash - Updated

    Hi,

    I have updated this script. I am very much a newb at ash programming.

    The subversion info:

    Original script from: http://kolmafia.us/index.php/topic,5...9.html#msg2569 - 19 October 2006
    Updated by Hippymon 13 November 2007
    Updated by Raven434 - 2009-02-13

    There are 49 outfit based tattoos now, up from Hippymon's last update of 38.

    Data obtained from http://kol.coldfront.net/thekolwiki/...fits_by_number
    New tat #10 added in
    Modded - there is no #13 listed in the outfits_by_number page

    I need to account for there be no entry 13 in the table, due to Jick. LOL
    Attached Files
    Last edited by Raven434; 02-14-2009 at 02:38 PM.

  2. #2
    Minion Bale's Avatar
    Join Date
    Jun 2008
    Posts
    13,287

    Default

    Just a small tip. You could leave out entry 13 in the table if you used

    Code:
    void get_tats_main(){
    	foreach key in Tat;
    		get_tats(key);
    }
    That would only match keys that you actually use. Hence, if you deleted Tat[13].gear it would work perfectly.

    Or else you could do this:

    Code:
    void get_tats_main(){
    	for a from 1 upto 49
    		if(a != 13) get_tats(a);
    }
    Not that there's anything wrong with your code. I just thought I'd show you a couple of things since you say that you're a newb.
    If people like my scripts, please send me stuffed Hodgmen.
    Universal Recovery, OCD Inventory Control, CounterChecker, newLife, ChIT.


  3. #3

    Post

    another small tip would be to have visit_url outside of the loop, no need to request the page each time, easiest way would be..
    Code:
    void get_tats_main(){
    	string html = to_lower_case(visit_url("account_tattoos.php"));
    	foreach key in Tat {
    		if (contains_text(html, to_lower_case(Tat[key].Img))) {
    			if (have_outfit(Tat[key].gear)) {
    				outfit(Tat[key].gear);
    				visit_url("town_wrong.php?place=artist");
    			} else print(Tat[key].gear + " is incomplete."); 
    		}
    	}
    }
    also making sure everything is in lower case helps avoid case-sensitivity, "Dnatat.gif" wasnt being detected as the page has "dnatat.gif"

  4. #4
    Senior Member Raven434's Avatar
    Join Date
    May 2007
    Location
    Virginia
    Posts
    461

    Default

    Awesome!

    Thanks for both tutorials!

    I'll make the updates.

    :-)

  5. #5
    Senior Member zarqon's Avatar
    Join Date
    Nov 2007
    Location
    Seoul, Korea
    Posts
    3,559

    Default

    Another option for skipping 13 is continue:

    Code:
    for a from 1 to 49 {
       if (a == 13) continue;
       get_tats(a);
    }
    Sig by JakAtk
    My scripts: Prefref Plus | Skillref Plus | One-Click Wossna | Om*****st (??) | Psychose-a-Matic | RandBot
    Combat suite: Best Between Battle | Mercenary Mood | SmartStasis | BatMan | BatMan RE
    For script authors: ASH Wiki | ZLib | BatBrain | CLI Links | Drag-n-Drop Inventories | CanAdv | Script Registry | Map Manager
    If you appreciate my work, help me become BAT KING OF THE WORLD! Thanks to all donators!

  6. #6

    Default

    Does something like this exist that doesn't try to get tattoos you already have? This changed outfits and visited the artist a bunch of times and didn't get me any missing tattoos.

  7. #7
    Junior Member
    Join Date
    May 2009
    Posts
    6

    Default

    Found a small bug:

    Tat[7].gear = "eXtreme-Cold Weather gear";
    Should be:
    Tat[7].gear = "eXtreme Cold-Weather gear";
    The hyphen seems to be in the wrong spot, causing this outfit check to fail.

  8. #8
    Junior Member
    Join Date
    Jul 2008
    Posts
    11

    Default

    I fixed the script to:

    use a map from outfit name to tattoo gif file name
    fixed some typos
    made it only hit the server once
    had it checkpoint your current outfit iff you were going to actually unlock a new tattoo
    report which outfits you needed for tattoos you couldn't get yet
    include all 56 tattoos known to date
    Attached Files
    Last edited by Batrachomyomachia; 11-04-2009 at 06:09 AM.

  9. #9
    Junior Member
    Join Date
    Jul 2009
    Posts
    4

    Default updated tattoo script

    Since I've found it a big pain to check all my tattoos (instead of just the outfit ones), I've made significant changes to the base script in this thread to now check against all known tattoos. A couple things it does:

    -Only hits the server once to grab the tattoo page
    -Checks against all outfit, class, ascension, and misc tattoos (except for the few 1 off specialized tattoos given to certain players)
    -Checks the 'level' of your hobo tattoo if present
    -Provides a complete, color coded listed of haves vs. missing
    -Provides a summary of total number have vs missing

    Note it DOES NOT automatically try to put on outfits and visit the artist like the previous versions do. This script is purely for informational purposes.

    The tattoos are hardcoded into the script unfortunately, so we'll need to update it as new outfits are released.

    Hope everyone finds this as helpful as I do!

    Version 1.0
    Version 1.1 - fixed summary total error
    Attached Files
    Last edited by xanth; 01-31-2010 at 01:30 AM. Reason: Updated version

  10. #10

    Default Updated 5-11-2010

    I can cut&paste with the best of em. :-)

    Tattoo original script updated with the latest outfit list.
    Attached Files

Similar Threads

  1. Bug - Fixed Updated consumable ranges
    By lostcalpolydude in forum Bug Reports
    Replies: 1
    Last Post: 07-23-2011, 06:35 AM
  2. Randomly switch tattoos
    By psly4mne in forum Informational Scripts
    Replies: 5
    Last Post: 07-07-2011, 12:01 AM
  3. Replies: 0
    Last Post: 05-13-2011, 04:50 PM
  4. Replies: 0
    Last Post: 07-28-2009, 10:40 AM
  5. MuseumStockUp v1.0 (Updated)
    By Presto Ragu in forum Item Handling Scripts
    Replies: 0
    Last Post: 04-18-2006, 07:06 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •