Bug - Fixed Piddles' "Belch the Rainbow" no longer recognized for damage

Using Piddles no longer shows an increase in elemental damage. Checked side pane, modtrace. The skill itself shows in the active effects list.

I'm guessing this is related to the Heavy Rains' beautiful rainbow skill implementation.

Your guess would be wrong. This has to do with the change to modifiers that requires the key to be exactly the name of the effect, not a canonicalized version.

I'm working on it.

Revision 14641 fixes this. We no longer have a map from effect ID to "display name"; we only have a map from effect ID to "data name" - the name which appears in statuseffects.txt.

There may be unanticipated side effects of this, which I will have to fix.