Bug - Cannot Reproduce SVN Repo File not updating properly

Bale

Minion
Hoookay, here's the thing. If there is not an existing /data/svnrepo.json and _svnRepoFileFetched is false, then KoLmafia will download svnrepo.json to /data. That works great, but its not the whole of the story.

If there is already a /data/svnrepo.json, then when _svnRepoFileFetched is false it does not overwrite the existing file with new data from github.

I added a new script to the SVN repo yesterday, if someone else does not find Best PVP Gear as an action script in svnrepo.json, then I am not the only one with this problem.


Code:
 {
  "repo": "https://svn.code.sf.net/p/zekaonar/code-0/PVPBestGear/", 
  "author": "zekaonar", 
  "name": "Best PVP Gear", 
  "forumThread": "http://kolmafia.us/showthread.php?15347-Best-PVP-Gear-optimizes-balances-for-8-mini-games", 
  "shortDesc": "Optimizes and balances gear for PvP mini-games", 
  "category": "action", 
  "longDesc": "This script will help you optimize your gear for the PVP mini-games: Laconic Dresser, Verbosity Demonstration, Showing Initiative, The Egg Hunt, Meat Lover, Broad Resistance Contest, Lightest Load and Letter of the Moment. The script will check which mini-games are active and will retrieve the letter of the moment on each run.<p>There are options to buy cheap mall gear (default is 1k or less) superior to what you possess and provide a comprehensive list of the best gear in-game with wiki links to research how you may acquire it."
 },
 

roippi

Developer
Can't reproduce, worked for me. Mafia asks for and checks the last-modified header for the file and doesn't replace if the server responds with a 304, so maybe that happened to you?
 

Bale

Minion
I tried it several times in a row and it kept failing, except for the time I deleted the file before trying it... Now it works.

I must have gotten a bad time for the server when it kept 304ing me.

Never mind. Cannot Reproduce.
 
Top