Feature - Implemented Add image proxy field to skills.

Bale

Bale

Minion
Items and Effects have a proxy field for image. (Items actually have two image proxy fields!)

Unfortunately skills do not have a proxy field for their image. I suspect that this is a hold-over from the ancient days of KoL when skills did not have an image although I'd have to do some research into the relevant dates of KoL and Mafia updates to be sure. Just for consistency's sake skills should also have that proxy field.

This came to my attention today when I went to add an image in a script. And the field was not there! It would be nice if skills could also have an image proxy field.

Please?
 
D

Darzil

Developer
They don't have the images in classskills.txt either, so I guess they'd have to be added there first.
 
D

Darzil

Developer
If you, or someone else, can get me all (or at least most of) the images for skills in a copy of classskills.txt, with the image in the third column (ie after name, before the numerics) I will update Mafia to read the new file format, add them into Skills Database, and make them available via proxy. I'd probably also update the code in some of the display panels which use skill images to get them directly from this code rather than being hard coded.

Can't say fairer than that?
 
H

heeheehee

Developer
Staff member
If someone else wants to do the merging, the following snippet will extract the skill images for everything that has images in the skill descriptions. There is a surprising number of skills that do not have these.

Code: 
foreach sk in $skills[] {
	string page = visit_url("desc_skill.php?whichskill=" + sk.to_int());
	matcher m = create_matcher("<img src=\".*?/([^/\"]*?)\"", page);
	if (m.find()) {
		print(sk + ": " + m.group(1));
	}
}

The following do not have images in their descriptions; however, a number do have associated images.
Code: 
> Walberg's Dim Bulb
> Spirit of Cayenne
> Spirit of Peppermint
> Spirit of Garlic
> Spirit of Wormwood
> Spirit of Bacon Grease
> Spirit of Nothing
> Get a You-Eye View
> Vicious Talon Slash
> All-You-Can-Beat Wing Buffet
> Tunnel Upwards
> Tunnel Downwards
> Rise From Your Ashes
> Antarctic Flap
> The Statue Treatment
> Feast on Carrion
> Give Your Opponent "The Bird"
> Ask the hobo for a drink
> Ask the hobo for something to eat
> Summon hobo underling
> Rouse Sapling
> Spray Sap
> Put Down Roots
> Fire off a Roman Candle
> Spring Raindrop Attack
> Summer Siesta
> Falling Leaf Whirlwind
> Winter's Bite Technique
> The 17 Cuts
> Recite 'The Spirit of Crimbo'
> Disarm
> Entangle
> Strangle
> Consume Burrowgrub
> Play an Accordion Solo
> Play a Guitar Solo
> Play a Drum Solo
> Play a Flute Solo
> Open the Bag o' Tricks
> Apprivoisez la tortue
> Give Your Opponent the Stinkeye
> Bashing Slam Smash
> Turtle of Seven Tails
> Noodles of Fire
> Saucemageddon
> Funk Bluegrass Fusion
> Extreme High Note
> Goldenshöwer
> Shoot Web
> Wrath of the Volcano God
> Wrath of the Lightning God
> Wrath of the Trickster God
> Squeeze Stress Ball
> Feed
> Quick Attack
> Rive Armor
> Brutal Strike
> First Aid
> Firebolt
> Chillblain
> Forceblast
> Vampiric Tendrils
> Draw New Tiles
> Run Away
> Kodiak Moment
> Grizzly Scene
> Bear-Backrub
> Bear-ly Legal
> Bear Hug
> I Can Bearly Hear You Over the Applause
> Unleash Nanites
> Air Blast
> Haggis Kick
> Rage Flame
> Doubt Shackles
> Fear Vapor
> Tear Wave
> Hide Behind a Tree
> Dive Into a Puddle
> Hide Under a Rock
> Hammer Ghost
> Fire Rocket
> Great Slash
> Get a Good Whiff of This Guy
> Blinding Flash
> Wink at
> Talk About Politics
> Pocket Crumbs
> Air Dirty Laundry
> Rage of the War Snapper
> Voice of She-Who-Was
> Will of the Storm Tortoise
> Soul Bubble
> Soul Finger
> Soul Blaze
> Soul Food
> Soul Rotation
> Soul Funk
> Dismiss Pasta Thrall
> Summon Snowcones
> Summon Stickers
> Summon Sugar Sheets
> Summon Clip Art
> Summon Rad Libs
> Summon Smithsness
> Summon Candy Hearts
> Summon Party Favor
> Summon Love Song
> Summon BRICKOs
> Summon Dice
> Summon Resolutions
> Summon Taffy
> Summon Hilarious Objects
> Summon Tasteful Items
> Summon Alice's Army Cards
> Summon Geeky Gifts

Technically, WAlberg's dim bulb is the only skill that has a skill desc but no image on that page; however, many other skill images can be gleaned from the CAB.
 
Last edited:
H

heeheehee

Developer
Staff member
Yup. There's also some images associated for the combat skills granted by items, which are visible in the CAB, so technically all of those through Soul Funk can be gotten.

I can save whoever some effort right now by confirming that the image for each ULEW skill (saucemageddon, noodles of fire, funk bluegrass fusion, etc) is just that of the corresponding weapon (windsor pan of the source, wrath of capsaician pastalords, ...).

edit: I also filed a bug report in-game regarding Walberg's not having an image; we'll see what happens there.
edit edit: "It is [an oversight]; it's on the long list of things to fix, someday :)"
 
ckb

ckb

Minion
Staff member
I am bumping this because it is semi-related to my other feature request on skill type and because I also endorse the usefulness of this feature.
Thank you.
 
Bale

Bale

Minion
Darzil said:
If you, or someone else, can get me all (or at least most of) the images for skills in a copy of classskills.txt, with the image in the third column (ie after name, before the numerics) I will update Mafia to read the new file format, add them into Skills Database, and make them available via proxy. I'd probably also update the code in some of the display panels which use skill images to get them directly from this code rather than being hard coded.
Click to expand...

Here it is! I also updated the version number in the first line from 3 to 4.
 

Attachments

  • classskills.txt
    26.4 KB · Views: 424
You must log in or register to reply here.
Top